Akhil Narang
b9e204bbbf
Merge pull request #27832 from akhilnarang/refactor-role-settings
...
refactor: make desk settings user specific
2024-09-27 13:27:41 +05:30
Sumit Bhanushali
7e18a3944c
Merge pull request #27913 from frappe/app_logo
...
fix: default to frappe logo when more than 2 app logos are present
2024-09-27 13:17:42 +05:30
Sumit Bhanushali
759f8306b6
fix: default to frappe logo when more than 2 app logos are present
2024-09-27 13:03:56 +05:30
Akhil Narang
fe48e775fb
chore: make the sections collapsible
...
Don't change the settings based on user type
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-27 11:41:53 +05:30
Akhil Narang
0b80d69c59
Merge pull request #27901 from akhilnarang/sentry-fixes
...
Sentry fixes from support
2024-09-27 11:27:20 +05:30
David Arnold
7bc23e783e
Merge pull request #27907 from blaggacao/fix/cli-wrapper-helper
...
fix: cli helper wrapper (oversight #27753 )
2024-09-26 12:51:53 +02:00
David
b66d16da5d
fix: cli helper wrapper (oversight #27753 )
2024-09-26 12:38:59 +02:00
Akhil Narang
1ad4113167
fix(query_report): fix crash
...
```
TypeError: i.get_value is not a function. (In 'i.get_value()', 'i.get_value' is undefined)
at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1332:21)
at filter([native code])
at frappe.views.QueryReportget_filter_values(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1332:5)
at erpnext.financial_statementsonload(../../../../../apps/erpnext/erpnext/public/js/financial_statements.js:119:24)
at ChartWidget.setup_filter_dialog(../../../../../apps/frappe/frappe/public/js/frappe/widgets/chart_widget.js:415:54)
at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/widgets/chart_widget.js:386:12)
```
Sentry support: 22569
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-25 17:23:56 +05:30
Akhil Narang
0393faf375
fix(list_view): fix crash when $result is undefined
...
```
TypeError: Cannot read properties of undefined (reading 'find')
at frappe.views.ListViewget_count_element(../../../../../apps/frappe/frappe/public/js/frappe/list/list_view.js:643:23)
at frappe.views.ListViewfreeze(../../../../../apps/frappe/frappe/public/js/frappe/list/list_view.js:500:9)
at frappe.views.BaseListrefresh(../../../../../apps/frappe/frappe/public/js/frappe/list/base_list.js:524:8)
at frappe.views.ListViewrefresh(../../../../../apps/frappe/frappe/public/js/frappe/list/list_view.js:306:16)
at frappe.views.ListView.refresh(../../../../../apps/frappe/frappe/public/js/frappe/utils/utils.js:879:19)
at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/list/list_view.js:253:10)
at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)
```
Sentry support: 22590
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-25 16:59:06 +05:30
Rushabh Mehta
b82f20fd97
Merge pull request #27774 from shivamsn97/develop
...
refactor: fix for #27773 by fixing string replacement method while renaming doc
2024-09-25 16:53:17 +05:30
Rushabh Mehta
30cef42d8f
Merge pull request #27898 from rmehta/fix-error-not-found
...
fix(style): update error, not found pages
2024-09-25 16:46:35 +05:30
Rushabh Mehta
6445b08b7c
fix(test): remove test for /search
2024-09-25 16:03:46 +05:30
Rushabh Mehta
6d44f1aa75
fix(style): unsubscribe.html
2024-09-25 15:52:31 +05:30
Rushabh Mehta
23f52c1720
fix(style): update error, not found pages
2024-09-25 15:46:24 +05:30
Sumit Bhanushali
f2cf034821
Merge pull request #27896 from frappe/login_ws_fix
...
fix: show first workspace of current selected app on app switch
2024-09-25 12:01:27 +05:30
Sumit Bhanushali
6aec385018
fix: show first workspace of current selected app on app switch
2024-09-25 11:38:26 +05:30
Sumit Bhanushali
6a12d167ca
Merge pull request #27881 from frappe/login_ws_fix
...
fix: reroute to /app when loggedin user does not have access to defau…
2024-09-25 11:22:40 +05:30
Akhil Narang
8260574f0d
Merge pull request #27659 from barredterra/mandatory-field-msg
...
fix: message for missing mandatory fields
2024-09-24 20:37:48 +05:30
Frappe PR Bot
9116f739e0
chore: update POT file ( #27889 )
2024-09-24 14:55:03 +00:00
Raffael Meyer
c73734715d
fix: update message needed for test
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-09-24 16:28:04 +02:00
Frappe PR Bot
e9ad54a687
fix: sync translations from crowdin ( #27838 )
2024-09-24 16:24:23 +02:00
Raffael Meyer
06e963c365
fix: extract translatable strings from the whole repo ( #27848 )
2024-09-24 15:55:46 +02:00
David Arnold
887ec49229
Merge pull request #27851 from blaggacao/fix/file-uploader
...
feat: enhance constructor configurability and fix UI issues
2024-09-24 15:50:43 +02:00
David
06126d3439
fix: button alignment
2024-09-24 15:37:01 +02:00
David
d6136b0df1
feat: add more config options
2024-09-24 15:36:58 +02:00
Sumit Bhanushali
02b21ae317
fix: reroute to /app when loggedin user does not have access to default workspace
2024-09-24 11:30:21 +05:30
P-Godfroid
2349221255
fix(translation): search placeholders ( #27812 )
...
* Translatable placeholder
* Translatable Search word.html
* " instead of ' for commiter tool.js
* Cleaner way to translate.js
* So the issue was prettier.js
* Style : prettier.js
* style(translation): line break removed from string
2024-09-24 10:57:40 +05:30
Akhil Narang
c4b7401882
chore: add in a patch to migrate desk settings from role to user [untested]
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-24 10:46:52 +05:30
Akhil Narang
895ca9a30b
refactor: make desk settings user specific
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-24 10:46:23 +05:30
Rushabh Mehta
99f233c6c7
Merge pull request #27879 from rmehta/fix-update-app-patch
...
fix(patch): update_app.py
2024-09-23 23:07:27 +05:30
Rushabh Mehta
34a0faa073
fix(patch): update_app.py
2024-09-23 22:54:35 +05:30
Rushabh Mehta
39611babde
Merge pull request #27878 from rmehta/fix-current-app-1
...
fix(minor): set defaiult workspace app in desktop.py
2024-09-23 22:31:45 +05:30
Rushabh Mehta
e01bdd9283
fix(minor): set defaiult workspace app in desktop.py
2024-09-23 22:18:59 +05:30
Rushabh Mehta
94d58fa23a
Merge pull request #27877 from rmehta/fix-current-app
...
fix(minor): guess correct current app
2024-09-23 22:11:32 +05:30
Rushabh Mehta
f438c6d709
fix(minor): guess correct current app
2024-09-23 21:58:11 +05:30
Rushabh Mehta
1a0d82f63c
Merge pull request #27876 from rmehta/fix-workspace-app
...
fix(minor): Set default app in Workspace and Module Def
2024-09-23 21:25:51 +05:30
Rushabh Mehta
5099041947
fix(minor): workspace/patches/update_app.py
2024-09-23 21:12:02 +05:30
Rushabh Mehta
384f4c9e21
fix(minor): don't set default app for custom modules
2024-09-23 21:03:21 +05:30
Rushabh Mehta
f24f327596
fix(minor): workspace/patches/update_app.py
2024-09-23 20:52:29 +05:30
Rushabh Mehta
dc21fbcb56
fix(minor): set default app as frappe in workspace if no app or module defined
2024-09-23 20:50:43 +05:30
Rushabh Mehta
7acf1fd346
fix(minor): set default app in module and workspace
2024-09-23 20:43:12 +05:30
Rushabh Mehta
5437e895de
fix(minor): set default app in module and workspace
2024-09-23 20:42:38 +05:30
Akhil Narang
895c589034
Merge pull request #27873 from barredterra/s3-error-logic
...
fix: don't catch S3 upload error prematurely
2024-09-23 18:41:44 +05:30
barredterra
8d52eeafe0
fix: don't catch S3 upload error prematurely
2024-09-23 14:59:24 +02:00
Akhil Narang
a04aba0408
Merge pull request #27868 from akhilnarang/fix-format_timedelta
...
fix: don't call `.total_seconds()` if the object isn't of type `datetime.timedelta`
2024-09-23 17:44:16 +05:30
Rushabh Mehta
4fd7840d28
Merge pull request #27778 from frappe/pot_develop_2024-09-15
...
chore: update POT file
2024-09-23 17:27:55 +05:30
Rushabh Mehta
72f236aa9f
Merge pull request #27819 from rmehta/fix-icons
...
fix(style): Update icons, new design for /me
2024-09-23 17:24:55 +05:30
Rushabh Mehta
d49340245e
fix(sidebar): set current app based on breadcrumb
2024-09-23 17:11:47 +05:30
Shariq Ansari
d965281c0d
Merge pull request #27866 from shariquerik/interaction-fix
...
fix: also assign if ToDo is created via interaction modal
2024-09-23 17:00:46 +05:30
Rushabh Mehta
70c98abc84
fix(minor): only select public workspaces by default
2024-09-23 16:53:31 +05:30
