Commit graph

44457 commits

Author SHA1 Message Date
Suraj Shetty
bc2b41d2f5 perf: Simplify dynamic route evaluation to speed up route resolution
validate complete route only if starting of the path matches with the webform route

This avoids the expensive matching from huge route_map (in sites with lots of web forms)
2023-12-08 21:15:34 +05:30
Suraj Shetty
7452e71d02 perf: Use get_cached_doc instead of get_doc
- Makes document pages with no-cache load a bit faster
2023-12-08 20:55:25 +05:30
Shariq Ansari
c312f66e96
Merge pull request #23272 from blaggacao/fix/list-view-settings
fix(list_settings): don't count tags to total fields
2023-12-08 19:39:17 +05:30
David Arnold
8c4d3e5ed9
fix: revert wrong cleanup attempt 2023-12-08 13:40:51 +01:00
mergify[bot]
bfc2c07630
fix: undefined variable name fixed in dark.scss (backport #23646) (#23693)
Co-authored-by: MasterCat <mastercat@link-igor.de>
2023-12-08 17:57:18 +05:30
Fisher Yu
84fcd857e4
feat(minor): child table field as standard filter in list view (#23625) 2023-12-08 16:56:40 +05:30
sibi kumar k
01d6679c8c
fix: Add filter in Workspace Card Links Block (#23578) 2023-12-08 16:47:23 +05:30
Shariq Ansari
32e1c715fe
Merge pull request #23672 from shariquerik/check-if-autoname-is-prompt 2023-12-08 16:46:42 +05:30
Akhil Narang
e1f6237cec
Merge pull request #23682 from akhilnarang/fix-sentry-user-name
fix(sentry): set the user's name correctly
2023-12-08 16:29:03 +05:30
Akhil Narang
faef64bab4
fix(sentry): set the user's name correctly
https://docs.sentry.io/platforms/python/enriching-events/identify-user/

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-08 16:13:15 +05:30
Shariq Ansari
52cea3e01c chore: better code 2023-12-08 15:49:33 +05:30
Shariq Ansari
adbd88d394 test: fixed failing test 2023-12-08 15:20:50 +05:30
Ankush Menat
57699a54b1
fix: Show server script name in traceback (#23676)
* fix: Show server script name in traceback

* chore: typo

Co-authored-by: Sagar Vora <sagar@resilient.tech>

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-12-08 15:01:13 +05:30
Shariq Ansari
b98c550823
Merge pull request #23677 from shariquerik/priortize-link-title-fix 2023-12-08 14:12:19 +05:30
Ponnusamy
95e161389b
chore: typo (#23675) 2023-12-08 13:57:46 +05:30
Shariq Ansari
f54f2419bb fix: prioritize link_title if value != link_title 2023-12-08 13:12:05 +05:30
Suraj Shetty
0d2a249687
Merge pull request #23673 from surajshetty3416/fix-espresso-style 2023-12-08 11:06:40 +05:30
Suraj Shetty
b04a6247ce fix: Color indicator style 2023-12-08 11:04:30 +05:30
Shariq Ansari
78cf0cd142 fix: check if autoname is promt before setting __newname 2023-12-08 10:53:58 +05:30
Md Hussain Nagaria
cfc781e5b6
fix(Virtual DocType): don't call db get_value in link field validation (#23620)
* fix(Virtual DocType): use get_doc to validate link field instead of db get_value

* refactor: use is_virtual_doctype util & always return a dict
2023-12-07 21:58:05 +05:30
Shariq Ansari
2522cbf6ab
Merge pull request #23665 from shariquerik/handle-format-using-filter-value 2023-12-07 20:46:03 +05:30
Shariq Ansari
b483800a06 fix: pass filter to formatter to handle custom logic 2023-12-07 19:45:32 +05:30
Ankush Menat
a1bfdf28a2
Merge pull request #23659 from shariquerik/ar-export-excel-fix
fix: use encoded filename for arabic (latin) language while exporting
2023-12-07 18:10:42 +05:30
Shariq Ansari
f679f65aa5 test: unit test to check arabic filename export 2023-12-07 13:42:24 +05:30
Shariq Ansari
4c9dea8d62 fix: use encoded filename for arabic (latin) language while exporting 2023-12-07 12:46:27 +05:30
Trusted Computer
61425cf858
fix: remove redundant breadcrumbs
Remove redundant frappe.breadcrumbs.add from notifications_settings
2023-12-07 10:22:13 +05:30
Sagar Vora
d74e5d2e8a chore: fix typo in comment 2023-12-07 09:31:53 +05:30
Raffael Meyer
76afbaaa40
Merge pull request #23609 from barredterra/de-morgan 2023-12-06 22:21:01 +01:00
Raffael Meyer
8eb6c0f1e5
Merge pull request #23619 from barredterra/clear-checked-items-in-report 2023-12-06 18:13:04 +01:00
Ankush Menat
fc5d946abb
Merge pull request #23640 from ankush/sentry_tweaks
fix: set correct sentry tags
2023-12-06 19:25:11 +05:30
Ankush Menat
f87b52a93c fix: set correct sentry tags 2023-12-06 19:20:54 +05:30
Ankush Menat
bbeeebbbbb
Merge pull request #23623 from barredterra/bulk-submit-cancel
feat: scoped progress bar on bulk submit/cancel
2023-12-06 18:35:24 +05:30
ajiragroup
8a2b9407c8
fix: Modified Number system for Nepal (#23613)
* Update utils.js

Further refined number system for Nepal. Numbering in Nepal does not continue as 100 Crores/1000 Crores as in India, but it proceeds as:
-> 1 Arba  for 100 Crore
-> 1 Kharba for 100 Arba (10,000 Cr)

* Update number_systems.js

Added number system for Nepal.
 Numbering in Nepal does not continue as 100 Crores/1000 Crores as in India, but it proceeds as:
-> 1 Arba  for 100 Crore
-> 1 Kharba for 100 Arba (10,000 Cr)

* chore: simpler condition

* style: format

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-06 15:21:41 +05:30
Ankush Menat
382c5ebdf1
Merge pull request #23621 from maharshivpatel/fix-primary-action-update
fix: only update primary action if it is new action is provided
2023-12-06 12:36:30 +05:30
barredterra
68c0e6f85f refactor: better parameter name 2023-12-05 19:39:47 +01:00
barredterra
54a83892bb fix: better error message 2023-12-05 19:37:02 +01:00
barredterra
9ada76df6c chore: deprecate old show_progress 2023-12-05 19:30:43 +01:00
barredterra
09395420b8 feat: task_id for submit_cancel_or_update_docs 2023-12-05 19:30:13 +01:00
barredterra
105c4a20fb refactor: better variable names 2023-12-05 19:19:56 +01:00
barredterra
a9c4894ccf fix: task_id parameter for publish_progress 2023-12-05 19:16:27 +01:00
Maharshi Patel
cb3205e569 fix: only update primary action if it is new action is provided
Currently, the primary action is updated even if the new action is None.
This breaks some old code that relies on the primary action being None
when no action is provided. (used to update primary action label)

I changed the code to only update the primary action
if the new action function is provided
2023-12-05 23:31:58 +05:30
barredterra
1b328854cc fix(Report View): clear checked items 2023-12-05 18:00:23 +01:00
Ankush Menat
b23ee471c3
Merge pull request #23616 from frappe/revert-19935-wkhtmltopdf_log_v14
Revert "feat: wkhtmltopdf logging"
2023-12-05 21:11:54 +05:30
Ankush Menat
b0c2f56dae Revert "feat: wkhtmltopdf logging (#19935)"
This reverts commit 6354a018de.
2023-12-05 21:11:35 +05:30
Ankush Menat
6e046a9752
Merge pull request #23604 from frappe/dependabot/github_actions/actions/labeler-5
build(deps): bump actions/labeler from 4 to 5
2023-12-05 19:19:41 +05:30
Shariq Ansari
69a96ad565
fix: strip html the printview's key value (#23606)
* fix: strip html the printview's key value

* fix: escape instead of strip html
2023-12-05 15:49:46 +05:30
barredterra
47f943b935 chore: git blame ignore rev 2023-12-05 11:17:15 +01:00
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
dependabot[bot]
811d167552
build(deps): bump actions/labeler from 4 to 5
Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](https://github.com/actions/labeler/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/labeler
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-04 18:03:58 +00:00
Bernd Oliver Sünderhauf
b45df8d726
fix: Reload whenever the effective language or timezone has changed. (#22952)
* fix: Reload whenever the effective language or timezone has changed.

* fix: Reload as well when rounding method is changed.
2023-12-04 22:42:17 +05:30