Commit graph

43838 commits

Author SHA1 Message Date
Faris Ansari
be85c246ff fix(socketio): send correct url for auth
in case, an app uses a different frontend stack on a different development server,
socketio should use the correct webserver port when authenticating
2023-10-26 15:27:27 +05:30
Ankush Menat
385fa8aaef
fix!: Correct between filtering (#22918)
* fix: Remove incorrect fallback

If you do +1 on date it will also start considering next date. This was
only done to accomodate date filter on datetime fields. Which also
doesn't really work.

* refactor: simplify fieldtype detection

* fix!: Correct datetime fallbacks for between filters

* chore: remove unncessary test

This is very specific and introduces flake when the job tests run before
it.
2023-10-26 06:23:14 +00:00
Ankush Menat
a643098a26
fix: Footer should show up once at end if not repeating header/footer (#22902)
* fix: Footer should show up once at end if not repeating header/footer

* fix: only show page number if repeating header

[skip ci]
2023-10-25 15:47:49 +05:30
Ankush Menat
287e13522c
fix: ignore workspace links on delete (#22895)
These can be manually modified later. It's not important to completely
block and prevent deletion.
2023-10-25 07:05:37 +00:00
Ankush Menat
d196dfeac4 fix: ignore perm while updating notification settings
If you can update user, do you should be able to update notif settings.
2023-10-25 11:22:56 +05:30
Raffael Meyer
65e859c938
Merge pull request #22889 from barredterra/basic-translation 2023-10-24 14:25:23 +02:00
barredterra
a7f0fa0377 fix: wrong german translation 2023-10-24 14:23:55 +02:00
dependabot[bot]
8b0efd5d4f
chore(deps): bump actions/setup-node from 3 to 4 (#22881)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-24 12:14:47 +05:30
Ankush Menat
a930872fd6
fix: pass default SSL context for imap/poplib (#22873) 2023-10-23 16:51:15 +05:30
Ankush Menat
9abb964d33
fix: don't encode / in html escaping (#22871)
This isn't really required and `/` is used in user facing text.
2023-10-23 16:12:52 +05:30
Ankush Menat
a3db75e161
fix: use frm.set_value for updating fields (#22860)
Just updating frm.doc object doesn't update the underlying model. In Frappe `frm.doc` is NOT the primary representation or source of truth for better or worse.
2023-10-23 14:14:30 +05:30
Maharshi Patel
c4c5f02f60
fix(minor): use inline-flex in page-actions btn (#22846)
Some times text and icons are in separate span and applying flex takes up the whole row. instead use inline-flex to avoid this.
2023-10-23 14:01:58 +05:30
surayp
68c28318dd
fix: escape print format code field(#22852) 2023-10-23 09:57:52 +05:30
Ankush Menat
6a9fee1b83
Merge pull request #22857 from CodeVenturers/open-contrib
fix(UX): resolve page not found error
2023-10-22 17:48:53 +05:30
Vishnu VS
2e431f75fb
fix: resolve page not found error 2023-10-22 15:55:11 +05:30
Ankush Menat
135fb6a486 chore: remove py2 compatibilty code 2023-10-21 13:40:04 +05:30
Shariq Ansari
5ec9ed09a9
Merge pull request #22646 from barredterra/fix-column-formatting
fix: list view formatting logic
2023-10-21 11:52:56 +05:30
Ankush Menat
ca29b0b685
Merge pull request #22839 from akhilnarang/use-python-gzip
refactor: use gzip library's compress() and decompress() methods directly
2023-10-21 11:18:25 +05:30
Akhil Narang
1119919971
refactor: use gzip library's compress() and decompress() methods directly
The util methods were added for python2.7 compat, mark them as deprecated

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-20 21:17:35 +05:30
Ankush Menat
44fa8e33d3
Merge pull request #22840 from maharshivpatel/fix-desk-minor-style
fix: minor desk style inconsistencies
2023-10-20 18:10:32 +05:30
Maharshi Patel
8973ee35d4 fix(minor): slides border and remove width
- remove unnecessary width from slides to make it a bit more responsive
- change border color to --border-color ( more subtle )
2023-10-20 17:43:32 +05:30
Shariq Ansari
ea44391f7a
Merge pull request #22836 from maharshivpatel/fix-website-styles-for-espresso 2023-10-20 17:38:30 +05:30
Maharshi Patel
b1e12a6109 fix: minor desk style inconsistencies
- made onboarding widget button default from primary
  as it takes too much attention
- removed desk navbar dropshadow
- made sidebar text smaller and added padding to plus icon and hover effect
- as we need border in tree view btn-group added those styles in tree.scss
- made hover black on workspace links
- dark mode misc
2023-10-20 16:52:55 +05:30
Maharshi Patel
527c3ca418 fix: use flex in empty-apps-state
- changed empty-apps-state to flex and replaced box-shadow with border
2023-10-20 14:45:44 +05:30
Maharshi Patel
fba6b37a3c fix: website comments and card style
- fix website comments section and changed comment button to primary
- replaced shadow with border on card style for website
- removed line-height from avatar as it is unnecessary
2023-10-20 14:43:07 +05:30
Maharshi Patel
281f30e649 fix(minor): website padding and like icon
- fix padding on navbar, dropdown
- fix like icon on blog page
- updated update password page
2023-10-20 14:39:51 +05:30
Maharshi Patel
d2137dbfb2 fix: change website base style
- added base text style as per espresso design
- added kbd style
- as new primary is black we need underline to indicate links
2023-10-20 14:32:45 +05:30
Maharshi Patel
c6e180e9b1 fix: login page style based on the new design
- hide the footer :P on login page.
- moved padding from container to .page-card and removed unnecessary
  style
- removed autofill custom color, doesn't feel natrual for some reason
- moved .page-card-head style out of .page-card
2023-10-20 14:28:49 +05:30
Maharshi Patel
1faa7639b9 fix: move app_logo and title outside page card
- moved app_logo and title outside page card and used logo_section macro
where possible
- also changed some titles to be more descriptive
2023-10-20 14:26:05 +05:30
Maharshi Patel
3f9d9a0e57 fix: add espresso variables to website as well 2023-10-20 14:22:07 +05:30
Ankush Menat
08b92858a3
fix: ignore duplicate perm check on assign hooks (#22832)
* fix: Ignore permissions while assigning if flag set

* fix: Avoid double permission checks on assignment rule

When it's triggered via doc events either:
- Permission check is done or
- Permission checks are not applicable
2023-10-20 06:18:19 +00:00
Corentin Flr
1a589d9354
fix: Fix get_message_log extra json.loads (#22827) 2023-10-19 23:32:09 +05:30
Suraj Shetty
716ff2add2
Merge pull request #22693 from maharshivpatel/fix-attach-before-doc-save 2023-10-19 15:55:10 +05:30
Ankush Menat
14279bf74a
ci: update ci config to consider v15 (#22822) 2023-10-19 15:39:05 +05:30
Shariq Ansari
4d54e8a088
Merge pull request #22809 from niraj2477/fix-permission-manager 2023-10-19 13:30:52 +05:30
Shariq Ansari
72ba005e51 revert: setting options as string 2023-10-19 13:25:39 +05:30
Shariq Ansari
94459a058d fix: set v as value if v is not an object 2023-10-19 13:24:02 +05:30
Ankush Menat
bdc5aba7ad
refactor: Use client.set_value instead of db.set_value (#22814) 2023-10-19 13:07:37 +05:30
Suraj Shetty
0d4c7ac82d
Merge pull request #22801 from bosue/improve_marking_matches 2023-10-19 12:35:47 +05:30
Shariq Ansari
7388f98251
Merge pull request #22813 from shariquerik/workflow-fix 2023-10-19 12:17:22 +05:30
ranjit-git
3351dd9020
fix: escpae filename
filenamexss
2023-10-19 12:11:42 +05:30
Maharshi Patel
409a3a8105 Merge branch 'develop' into fix-attach-before-doc-save 2023-10-19 11:40:20 +05:30
Shariq Ansari
ff5c6e3394 chore: updated workflow builder banner 2023-10-19 11:34:47 +05:30
Shariq Ansari
6b5b21f343 chore: show beta indicator 2023-10-19 11:28:44 +05:30
Shariq Ansari
3aa37bc84c fix: reload workflow data after save 2023-10-19 11:21:56 +05:30
14987
86611be0c6
fix: Update type of perm level option in permission manager 2023-10-18 19:15:10 +05:30
Ankush Menat
710171972f
Merge pull request #22795 from ssuda/fix-cron-twice
fix: cron job firing immediately after save
2023-10-18 18:20:39 +05:30
Ankush Menat
05d6f5cc8a test: Add cold start tests 2023-10-18 17:55:48 +05:30
Sagar Vora
93a8c37977 fix: type hint for keyword-only parameter for_update
[skip ci]
2023-10-18 17:36:45 +05:30
Maharshi Patel
7b4d8629dd Merge branch 'fix-attach-before-doc-save' of https://github.com/maharshivpatel/frappe into fix-attach-before-doc-save 2023-10-18 17:27:32 +05:30