Sagar Vora
c5face41b3
fix: clear notifications cache when deleting a Notification
2022-08-22 19:04:18 +05:30
Sagar Vora
2866721a78
test: clear lang_full_dict from local cache
2022-08-22 19:04:18 +05:30
Sagar Vora
63e760e3ad
chore: remove old code where User Permissions were set in tabDefaultValue
2022-08-22 19:03:30 +05:30
Shariq Ansari
d0111f7d14
Merge pull request #17847 from shariquerik/edit-public-workspace-fix
2022-08-22 15:31:49 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
...
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
b30a78aa40
perf: install hiredis for faster response parsing ( #17893 )
2022-08-22 11:39:18 +05:30
Ankush Menat
794a2b8101
Merge pull request #17894 from ankush/db_no_getall
...
chore: db.get_all -> get_all
2022-08-22 11:38:04 +05:30
Ankush Menat
1de22b6082
chore: ignore fluff change in blame
...
[skip ci]
2022-08-22 11:35:53 +05:30
Ankush Menat
2eec621e95
chore: db.get_all -> get_all
...
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
4241f8c8c0
perf: simpler/faster preload header computation
...
We parse entire response to find preload headers, instead just use
include_style and include_script to include assets directly into preload
headers. This shaves off ~13% overhead in response.
2022-08-21 18:46:58 +05:30
Ankush Menat
48869d506f
perf: dont order by for uniq searches
2022-08-21 17:37:40 +05:30
Ankush Menat
61a9349789
perf: use is_virtual_doctype and remove limit
...
This reduces 1 query for each child table read
Removed limit cause with 1000+ doctypes in frappe+erpnext this cache
will just keep getting trashed for no reason. There's clear upper bound
on size so no need to limit it here.
2022-08-21 17:37:40 +05:30
Ankush Menat
786df3fbeb
perf: ~33% faster Desk response
...
- hardcode `/app` resolution
- use cached website settings everywhere. It was mixing cache and DB
everywhere and re-quering same thing (why ?)
2022-08-21 17:35:07 +05:30
Ankush Menat
04aeeabb2b
fix(recorder): make whole order button clickable
2022-08-21 17:35:07 +05:30
Ankush Menat
69a8027935
fix: jump to field shows column/section breaks
2022-08-21 13:00:34 +05:30
mergify[bot]
d3da57cee2
fix: Turkey number format corrected ( #17886 ) ( #17888 )
...
(cherry picked from commit b0a808b2c4c156c8374664f32b8a1a0106eb3b90)
Co-authored-by: Türker Tunalı <turker.tunali@gmail.com>
[skip ci]
2022-08-20 19:51:04 +05:30
Shariq Ansari
d274b56817
chore: code cleanup
2022-08-19 15:56:44 +05:30
HENRY Florian
11a17d3867
feat: STARTTLS authentication for IMAP ( #17683 )
...
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-08-19 13:40:06 +05:30
Ankush Menat
f002016eb6
chore: limit over-logging of handled exception ( #17878 )
...
[skip ci]
2022-08-19 12:53:51 +05:30
mergify[bot]
eaf3aa28ee
Merge pull request #17860 from pps190/fix-dataimport
...
fix: data import preview link warning
2022-08-18 15:47:23 +00:00
mergify[bot]
d1ce02474a
Merge pull request #17826 from resilient-tech/perf-custom-fields-creation
...
perf: ~65% faster `create_custom_fields`
2022-08-18 15:30:26 +00:00
Ankush Menat
9fa24c2b46
Merge pull request #17872 from ankush/exceptions_logging
...
fix: pop pwd from form dict, disable auth logging
2022-08-18 18:58:17 +05:30
Ankush Menat
b2b0b64d8c
refactor: add default to pop
...
[skip ci]
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-08-18 18:34:52 +05:30
Ankush Menat
f2b6c937c9
fix: pop pwd from form dict, disable auth loggin
...
- This prevents accidental logging of this info somewhere down the line.
- Disable exception logging for auth failures
2022-08-18 15:32:42 +05:30
Faris Ansari
82fef72ce1
fix(db-query): parenttype condition on child table left join ( #17865 )
...
joining only on name is incorrect because parent primary keys are not unique across tables
How was this working all this time? 🥲
2022-08-18 09:04:40 +00:00
Ankush Menat
48a735ccce
Merge pull request #17862 from ankush/boto3_bump
...
chore(deps): bump boto dependency
2022-08-17 20:56:25 +05:30
Devin Slauenwhite
87972656d4
fix: convert pk from db to str.
2022-08-17 10:52:31 -04:00
Ankush Menat
821a4df192
chore(deps): bump boto dependency
2022-08-17 20:18:14 +05:30
mergify[bot]
615b27b675
Merge pull request #17854 from netchampfaris/text-editor-has-content
...
fix: has_content check for fieldtype TextEditor
2022-08-17 11:57:36 +00:00
phot0n
613d8472b4
test: skip badly written test temporarily
2022-08-17 16:39:42 +05:30
Ankush Menat
1c9ea57279
fix: dont use sendmail with now=True
2022-08-17 16:39:42 +05:30
Ankush Menat
3e2d2a703a
test: Use FrappeTestCase everywhere
2022-08-17 16:39:42 +05:30
Ankush Menat
41af9621cd
test: undo custom field creation
2022-08-17 16:39:42 +05:30
Shariq Ansari
fe10649c1b
Merge branch 'develop' into edit-public-workspace-fix
2022-08-17 15:50:23 +05:30
Faris Ansari
10e49a19b8
test: Text Editor only image content
2022-08-17 15:45:11 +05:30
Ankush Menat
040a7ba021
fix(UX): better indicator for "is private" uploads
2022-08-17 14:58:01 +05:30
Ankush Menat
5062b9b26a
fix: undefined "self"
...
This is JS not python xD
2022-08-17 14:58:01 +05:30
Faris Ansari
d11692c52f
fix: has_content check for fieldtype TextEditor
...
When a TextEditor field contains only an image, while checking for
content, HTML tags are stripped off including the only image.
This change adds a loose but explicit check for img tag.
2022-08-17 14:40:40 +05:30
Ankush Menat
a01967c182
fix: incorrect attachment limit message ( #17848 )
2022-08-16 20:57:19 +05:30
Shariq Ansari
de4e3f0c8c
fix: make fields that needs to be updated from UI read_only
2022-08-16 18:24:14 +05:30
Shariq Ansari
521102b589
fix: update public workspace name with json file
2022-08-16 18:23:23 +05:30
Ankush Menat
3ec4a618e3
test: FrappeClient tests not skipped ( #17843 )
2022-08-16 14:10:12 +05:30
Rushabh Mehta
6a2c70b426
Merge pull request #17785 from rmehta/editable-form
...
feat: Form Editor
2022-08-16 12:29:48 +05:30
gavin
29b991749f
docs: Update README shields ( #17841 )
...
* docs: Update README shields
* docs: Set shields colour to success instead of green
2022-08-16 12:28:37 +05:30
Ankush Menat
d61705f528
perf: use cached docs for system settings
2022-08-16 12:24:42 +05:30
Ankush Menat
c9da8d87e5
ci: dont submit coverage if tests din't run
2022-08-16 11:49:08 +05:30
Ankush Menat
b7a7f97a7a
refactor: convert get email count query to ORM
...
- also fix capitalization of column names on postgres
2022-08-16 10:53:28 +05:30
Ankush Menat
4391f8d0f1
ci: dont check python syntax for patch test
...
patch test runs across multiple versions, doesn't make sense here.
2022-08-16 10:53:28 +05:30
Ankush Menat
9f31723555
refactor: directly map function over lambda call
2022-08-16 10:53:28 +05:30
Ankush Menat
53af10a064
refactor!: python pretty_date consistent with JS
...
Python pretty date was ceiling month and week instead of flooring them,
this is incorrect AND inconsistent with popular JS library pretty date
that we use on client side
2022-08-16 10:53:28 +05:30