Ankush Menat
c8ec528aa7
Merge pull request #29196 from ankush/fix/meta_mutation
...
fix: Don't assume homogenous data in meta tables
2025-01-16 20:41:02 +05:30
Maharshi Patel
6a861fc3c8
chore: added ipv6 to hosts file ( #29199 )
...
macos takes 5-10 second on dns when *.local is used unless ipv6 is added to hosts file.
source: https://stackoverflow.com/questions/10064581/how-can-i-eliminate-slow-resolving-loading-of-localhost-virtualhost-a-2-3-secon/17982964#17982964
Adding this even though it's edge case because i spent few days debugging something else to make it faster.
Co-authored-by: Maharshi Patel <maharshipatel@Maharshis-MacBook-Pro.local>
2025-01-16 19:23:32 +05:30
Ankush Menat
e6bad301b8
refactor: Use @cached_property instead of implmenting it
2025-01-16 19:19:56 +05:30
Ankush Menat
b3859d9fa3
fix: Don't assume homogeneous data in meta tables
...
Steps to reproduce:
- enable developer mode (doesn't happen in prod)
- Save a document with set only once fields
- Reload the page (requests meta again which is now polluted)
This is new category of bug surfaced because meta objects now live
longer than request and all kinds of weird `self._cached_property`
starts getting serialized.
Co-Authored-By: ruthra kumar <ruthra@erpnext.com>
2025-01-16 19:10:16 +05:30
Suraj Shetty
9a1eab7512
Merge pull request #29142 from iamejaaz/child-table-ui-29106
2025-01-16 16:19:06 +05:30
Ejaaz Khan
98be3f46f3
refactor: change height and add condition on prevent default
2025-01-16 15:58:25 +05:30
Ankush Menat
430c0c7c7a
fix(DX): Log all exceptions in developer mode ( #29195 )
...
ALL exceptions - even validation errors. This is excessive logging but
in development mode it should be fine and even helpful in debugging few
issues.
2025-01-16 15:50:56 +05:30
Ankush Menat
9c2bd23606
fix: don't override setstate ( #29194 )
...
Meta sometimes break because of this, I don't quite know why but this
change isn't that useful, so best to revert it for now.
2025-01-16 15:50:47 +05:30
Ejaaz Khan
fc9c75de2c
feat: enhance horizontal scrolling in child table
2025-01-16 14:50:50 +05:30
Raffael Meyer
9307ee8886
fix(Contact): export company name and department in vCard ( #29190 )
2025-01-15 14:16:03 +00:00
Ankush Menat
4116a33560
perf: speed up oauth bearer token query ( #29184 )
...
* perf: index user and make not_nullable
* refactor: simpler expiry setting
* perf: don't fetch all tokens
2025-01-15 13:24:46 +00:00
Ankush Menat
5874d6bf12
perf: Add prefix index for file_url ( #29185 )
...
Currently it's full table scan, that too on a TEXT field filter.
It's used for finding file docs when `fid` isn't specified. No idea
where we are STILL having private file URLs without fids.
In any case, this is still required.
2025-01-15 13:03:24 +00:00
Akhil Narang
638b118875
Merge pull request #29123 from akhilnarang/escape-path
...
fix(not_permitted_page): escape path
2025-01-15 16:45:13 +05:30
Ankush Menat
d219353877
fix: edge case for redirects on / ( #29180 )
...
Because all slashes are stripped this endpoint becomes `""` which is not
a valid key for redis hash.
2025-01-15 09:05:19 +00:00
Ankush Menat
584727f5e7
perf: negative website redirect caching ( #29179 )
2025-01-15 14:21:56 +05:30
Shariq Ansari
d6386e6e06
Merge pull request #28767 from frappe/remove-billing-pages
2025-01-15 13:21:32 +05:30
Bread Genie
0e61d4e84e
fix: don't add login to fc option in dropdown
...
for now
2025-01-15 12:53:13 +05:30
Ejaaz Khan
3675a5416d
refactor: move scrollbar to the bottom of the table
2025-01-15 12:49:56 +05:30
Akhil Narang
ad0e4e25f5
Merge pull request #29172 from akhilnarang/strip-html-user-name
...
fix(user): strip html tags from user name
2025-01-15 12:29:58 +05:30
Akhil Narang
5b9fde293e
Merge pull request #29171 from akhilnarang/strip-html-activity-log
...
fix(activity_log): strip html from full name before inserting
2025-01-15 12:29:39 +05:30
Ankush Menat
8d780d7245
Merge pull request #29170 from ankush/perf/jenv
...
perf: persistent jenv, ~7x faster `/login`
2025-01-15 12:17:26 +05:30
Ankush Menat
ba6e3f6cd1
test: igore edge case of invalid strings
...
We parse them as None instead of 1-1-1 etc
2025-01-15 12:07:06 +05:30
Akhil Narang
89c945f902
fix(user): strip html tags from user name
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-15 11:54:09 +05:30
Ankush Menat
9ebfea1d08
perf: avoid duplicate template caching
2025-01-15 11:53:00 +05:30
Ankush Menat
829062b1e3
fix: make shared jenv thread-safe
...
A new copy is created for each request, but cache is shared.
2025-01-15 11:53:00 +05:30
Ankush Menat
2c2ec13874
perf: reuse jenv across requests
2025-01-15 11:53:00 +05:30
Ankush Menat
b2ff5e6125
perf: use cached navbar
2025-01-15 11:53:00 +05:30
Akhil Narang
b87e0a874f
fix(activity_log): strip html from full name before inserting
...
People can pass in HTML in the login page, it gets rendered here
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-15 11:46:51 +05:30
Akhil Narang
8b631dc0ed
Merge pull request #29156 from akhilnarang/partial-revert-26183
...
fix(csvutils): drop sniffer code
2025-01-15 11:20:18 +05:30
Akhil Narang
e5a3802dc5
feat(csvutils): make sniffer usage optional
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-15 10:58:41 +05:30
Ankush Menat
9fac1a06f6
Merge pull request #29159 from ankush/perf/faster_render
...
perf: ~3x faster `/app` loading
2025-01-15 09:47:08 +05:30
Frappe PR Bot
116f23c4e1
fix: sync translations from crowdin ( #29120 )
2025-01-14 23:24:22 +01:00
mahsem
2e3b6c9031
feat: datepicker_swedish ( #29161 )
2025-01-14 23:02:24 +01:00
Raffael Meyer
3b7df82a80
chore: remove unused method ( #29163 )
2025-01-14 21:39:09 +00:00
Ankush Menat
01f9787736
fix: catch template error for on-disk paths too
2025-01-14 20:04:36 +05:30
Ankush Menat
129212a916
perf: cache unseen notes
2025-01-14 19:43:22 +05:30
Ankush Menat
0ff3e6fd4c
perf: cache meta tags existence
2025-01-14 19:19:36 +05:30
Ankush Menat
dc7636de8f
perf: use cached user document
2025-01-14 19:01:31 +05:30
Ankush Menat
9bd6c95b3f
perf: don't yaml-parse empty string and get nothing back
...
*surprise*
2025-01-14 18:52:50 +05:30
Ankush Menat
8682014259
perf: use client cached navbar
2025-01-14 18:49:19 +05:30
Ankush Menat
f963758a1d
perf: Avoid duplicate queries
2025-01-14 18:48:28 +05:30
Ankush Menat
a8265bdc30
perf: avoid unnecessary query for user type
...
WHY?
2025-01-14 18:45:08 +05:30
Ankush Menat
80f324cc04
perf: cache simple jinja templates
2025-01-14 18:26:56 +05:30
Ankush Menat
a89fd99794
perf: keep jloader across requests
...
This doesn't have anything that needs to be created for each request.
2025-01-14 18:18:19 +05:30
Ankush Menat
e768f679ff
perf: Speedup rendering of simple templates
...
Also, slowdown rendering of complex ones. Nothing comes free.
2025-01-14 18:11:27 +05:30
Akhil Narang
d9b9940a79
fix(csvutils): drop sniffer code
...
This seems to break certain CSVs, which the default excel dialect can handle fine
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-01-14 17:19:13 +05:30
Ankush Menat
c72e91f465
fix: backward compatible date parsing ( #29155 )
...
Even though we never use tz aware object in frappe this function
previously used to retain them, so keep TZinfo for sake of compat.
Nothing should be affected ideally.
2025-01-14 11:05:55 +00:00
Ankush Menat
7f30905b10
Merge pull request #29154 from ankush/perf/redundant_translations
...
perf: Dont send useless translations
2025-01-14 15:47:58 +05:30
Ankush Menat
b32f74e6af
perf: Dont send useless translations
...
src => target same strings are not useful to anyone, unnecessary
computations.
2025-01-14 15:46:21 +05:30
Ankush Menat
7ae7e87178
Merge pull request #29150 from ankush/perf/misc_page_render
...
perf: speedup `get_website_settings`
2025-01-14 15:32:22 +05:30
