Commit graph

34254 commits

Author SHA1 Message Date
Suraj Shetty
cbd94bd33d ci: Set name for coverage data upload 2021-09-02 10:53:53 +05:30
Suraj Shetty
ba73d99377 ci: Enable code coverage for postgres build as well 2021-09-02 09:36:57 +05:30
Suraj Shetty
cf028964f3 CI: Use codecov coverage reporting
Why?
- Coveralls had login issues and we were not able to view files to find the actual uncovered lines
- Codecov has better reporting (status checks & commit diff coverage, ), UX (better folder/file navigation, faster page loads), and has more features.
- Codecov will not require additional step of
coverage wrap-up for parallel builds (it manages it internally somehow).
2021-09-02 09:36:25 +05:30
mergify[bot]
386b579405
Merge pull request #13989 from gavindsouza/get-single-value-oof
fix(frappe.utils.data): Deprecate `cast_fieldtype` to use `cast` for consistent return types
2021-09-01 08:57:49 +00:00
Suraj Shetty
a194a05c06
Merge pull request #14054 from shariquerik/show-docstatus-in-list-view
fix: Show docstatus in list view through status indicator pill
2021-09-01 13:09:06 +05:30
Rushabh Mehta
12e1dd367f
Merge pull request #14077 from shariquerik/workspace-2_0-fixes
fix: Workspace 2.0 issues
2021-09-01 12:54:23 +05:30
Shariq Ansari
95ba4a53c1 fix: error while deleting links in cards 2021-09-01 12:41:53 +05:30
Suraj Shetty
3d5e7b64ea
ci: Update auto-close condition 2021-09-01 12:13:11 +05:30
Suraj Shetty
5c0c9d5417
ci: Update mergify.yml 2021-09-01 12:06:46 +05:30
Shariq Ansari
0ca9df7ecb
Merge branch 'develop' into workspace-2_0-fixes 2021-09-01 10:45:39 +05:30
gavin
8394bbeb4c
chore(utils): Add type hints for get_timedelta, getdate
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-08-31 21:50:07 +05:30
Suraj Shetty
9d785b6d9f
Merge pull request #14050 from surajshetty3416/fix-link-selector 2021-08-31 20:05:11 +05:30
Shariq Ansari
6be64eb4f9 fix: Make min width of page action buttons to 35px 2021-08-31 17:22:48 +05:30
Rushabh Mehta
b4eba5497c
Merge pull request #14083 from rmehta/fixes-31-aug
fix(cleanup): cleanup email account, bug fix for web_template.js and more
2021-08-31 15:32:27 +05:30
Rushabh Mehta
cec53b595a fix(cleanup): cleanup email account, bug fix for web_template.js and more 2021-08-31 15:27:25 +05:30
Gavin D'souza
9a32513b47 chore: Update frappe.utils.data.cast docstring 2021-08-31 13:11:25 +05:30
Gavin D'souza
176d6d2d06 fix: Check if input is str is_invalid_date_string
This is sort of a breaking change? Because if an int/dict/list/tuple was
passed instead of a str, object doesnt have .startswith (AttributeError)
would be raised instead of just returning None.
2021-08-31 13:07:22 +05:30
Gavin D'souza
8622142d7d fix: Use get_timedelta in cast, add to safe_exec list
* Return date and datetime objects for Date and Datetime field types
  respectively if Falsy output is set
2021-08-31 13:06:10 +05:30
Gavin D'souza
3858e95e80 feat(utils): Add util get_timedelta
get_timedelta returns None in case of invalid or imparsable inputs. This
behaviour is consistent wrt other utils. The util, to_timedelta tries to
convert to timedelta objects only if str object is passed. It returns
the same object if not string, which is absurd...given its called
`to_timedelta`.
2021-08-31 12:57:05 +05:30
Gavin D'souza
8e96d8d522 test: Add tests for str fieldstypes cast 2021-08-31 12:55:31 +05:30
Suraj Shetty
86af25a287
Merge branch 'develop' into fix-link-selector 2021-08-31 11:24:53 +05:30
mergify[bot]
56fcd3cfab
Merge pull request #13965 from deepeshgarg007/custom_doctype_length
fix: Length change for docfield not updated in Database
2021-08-31 05:49:11 +00:00
gavin
708a1118f7
Merge pull request #14071 from gavindsouza/b-start-retry
fix: Retry get_redis_conn until Redis is available
2021-08-31 11:15:46 +05:30
Deepesh Garg
62585b3ec2 Merge branch 'develop' of https://github.com/frappe/frappe into custom_doctype_length 2021-08-31 10:47:15 +05:30
Deepesh Garg
cd17ca274c fix: Check column length from information schema 2021-08-31 10:44:11 +05:30
Suraj Shetty
552dc47e90
Merge branch 'develop' into fix-link-selector 2021-08-31 09:24:52 +05:30
Saqib
0c7c1dcb89
feat: Bulk export from list view (#13906)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-30 20:02:29 +05:30
Gavin D'souza
be72397bca test: Add tests for frappe.utils.data.cast 2021-08-30 18:51:36 +05:30
Shariq Ansari
025be09772 fix: Home redirect issue and made default content as [] 2021-08-30 18:49:34 +05:30
gavin
8bd1b05727
Merge pull request #14075 from gavindsouza/roulette-gha-push
fix(ci): Run all builds on github push events
2021-08-30 17:22:48 +05:30
shariquerik
7c7eb68e4d fix: sider fix 2021-08-30 14:00:40 +05:30
Gavin D'souza
7e2e8c87ff Merge branch 'develop' into get-single-value-oof 2021-08-30 13:49:35 +05:30
Gavin D'souza
b8c51b13e2 fix: Revert to using cast_fieldtype in BaseDocument.cast
* reference: revert Breaking Change -
  https://github.com/frappe/frappe/pull/13989#discussion_r695624003
* Show deprecation warning unless `show_warning` is unset
2021-08-30 13:45:30 +05:30
Shariq Ansari
f84344592a
Apply suggestions from code review
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-30 13:31:07 +05:30
Suraj Shetty
93b7eb64ec
Merge pull request #14061 from ankush/gha_concurrency 2021-08-30 13:10:44 +05:30
Gavin D'souza
a5ded007a5 fix(ci): Run all builds on github push events
Issue: No PR number is detected on Push events and all builds are
skipped. We want the opposite to be true, so we're running all builds on
merges in hopes of testing better.
2021-08-30 12:54:37 +05:30
mergify[bot]
e8623474da
Merge pull request #13973 from deepeshgarg007/auto_email_report_null_values
fix: Handle null values in auto email report rows for XLSX format
2021-08-30 06:51:57 +00:00
Gavin D'souza
783165c01e fix: Retry get_redis_conn until "sure"
If ConnectionError or BusyLoadingError occurs, try every second for
up-to 10 times.

Why: `bench start` exits just as i run it at times. This happens when
the worker's processes each try to fetch a redis conn but redis isnt up
yet. The 3 workeer processes exit with 1 and our procman gives up too.
2021-08-30 12:00:31 +05:30
shariquerik
4f31f9c501 fix: Show Document Status (docstatus) as a title on hovering the Status Indicator Pill 2021-08-30 11:48:39 +05:30
Shariq Ansari
729ea3eafa
Merge branch 'frappe:develop' into show-docstatus-in-list-view 2021-08-30 11:44:36 +05:30
Suraj Shetty
8948eadaf5
Merge branch 'develop' into auto_email_report_null_values 2021-08-30 11:21:53 +05:30
mergify[bot]
f27d3acc1f
Merge pull request #13367 from kennethsequeira/get-frmt
feat: add number format parameter in doc.get_formatted
2021-08-30 04:33:31 +00:00
Suraj Shetty
37d3555f1e
Merge pull request #13532 from shariquerik/date-field-validation-fix
fix: datetime field form validation
2021-08-30 10:01:28 +05:30
Suraj Shetty
2150049821
Merge branch 'develop' into get-frmt 2021-08-30 09:52:49 +05:30
Suraj Shetty
9408714470
Merge branch 'develop' into show-docstatus-in-list-view 2021-08-30 09:49:20 +05:30
mergify[bot]
ecb06cd12f
Merge pull request #13905 from Komal-Saraf0609/folder-navigation
test: Navigating to folder nested inside 2 folders
2021-08-30 03:42:46 +00:00
Deepesh Garg
f340ea2fea Merge branch 'develop' of https://github.com/frappe/frappe into custom_doctype_length 2021-08-29 20:15:58 +05:30
Komal-Saraf0609
9df31cfed1 test: Corrected the selectors for clicking of a button to make it more readable 2021-08-28 01:55:46 +05:30
Komal-Saraf0609
9e90bf34c7
Merge branch 'frappe:develop' into folder-navigation 2021-08-28 01:50:16 +05:30
Ankush Menat
132864a776
ci: extend concurrency control to all long jobs 2021-08-27 23:08:09 +05:30