Commit graph

49841 commits

Author SHA1 Message Date
Abdeali Chharchhoda
d4a2fe36d3 Merge branch 'develop' into new-ui-for-api-key 2025-05-29 23:13:10 +05:30
Ankush Menat
fd29e9c464
fix: Smaller batch size for global search (#32720)
10K is quite large for a single batch.
2025-05-29 17:13:01 +00:00
Ankush Menat
f17658c4c6
fix: Sample link counts and flush frequently (#32713)
We recently applied limit on how many links can be buffered. That
pretty much "samples" only records created at start of the hour.

This change makes it flush 4x frequently and samples 10% of input to
reduce updates. Again, statistically this serves same purpose.
2025-05-29 12:18:28 +05:30
Ankush Menat
4d8ebcce29
perf: Apply backpressure on link counts (#32712)
Context: This is QoL feature to highlight most used items. But in high
throughput environments where a lot of new documents are being created
this becomes a bottleneck.

Fix: Limit the size of counts that can be buffered before they're flushed.

Statistically this will still work just as well as it did before.
2025-05-29 11:55:35 +05:30
Ejaaz Khan
6516e43127
Merge pull request #32706 from iamejaaz/39776-webform-default-field-filter
fix: default fields filter not working in web form
2025-05-28 19:24:28 +05:30
Ankush Menat
8a3f65338c
Revert "perf: cache fetch from value too (#32700)" (#32708)
This reverts commit f8e9e82260.
2025-05-28 13:31:07 +00:00
Ankush Menat
ba96408d23
fix: checkboxes can never be mandatory (#32707) 2025-05-28 13:24:49 +00:00
Ejaaz Khan
7597bfac3a fix: default fields filter not working in web form 2025-05-28 17:34:08 +05:30
Ankush Menat
f8e9e82260
perf: cache fetch from value too (#32700)
Consider any "items" table in ERNext, same item and warehouses are used
10s of times in a single document, every one of them triggers fetch from
query, even though it can't possibly change during the DB transaction.

This change now caches the fetched value too.
2025-05-28 15:56:52 +05:30
Ankush Menat
03713cfd80
perf: faster time parsing (#32701)
Same as previous date and datetime improvement, this uses C parser
instead of python `parser`.
2025-05-28 15:56:34 +05:30
Soham Kulkarni
27b6171a05
Merge pull request #32696 from Vengadesh27/filter_css
fix: adjust left margin to prevent label overlap
2025-05-28 13:13:31 +05:30
Ankush Menat
e82dd4e49b
Merge pull request #32698 from ankush/sys_console_perms
fix!: change default sys console permissions
2025-05-28 09:53:45 +05:30
Ankush Menat
3d677a1b47 fix(dx): Add title for code copy button 2025-05-28 09:31:41 +05:30
Ankush Menat
222095f243 fix!: change default permissions for system console
- Restrict to admin by default
- System manager can be re-enabled using role permission manager
2025-05-28 09:28:26 +05:30
Vengadesh
ea361a01f0 fix: adjust left margin to prevent label overlap 2025-05-28 01:04:28 +05:30
Soham Kulkarni
0ee0f6ba46
Merge pull request #32666 from sokumon/text-editor-issues
fix(TextEditor): UX issues
2025-05-27 16:50:26 +05:30
Ejaaz Khan
d48269180d
Merge pull request #32608 from Vengadesh27/duplicate_row
feat: Duplicate Row Button in Child Table for Duplicating Multiple Rows
2025-05-27 15:47:13 +05:30
Ejaaz Khan
c123bd28cf
Merge pull request #32690 from iamejaaz/39492-between-filter
fix: remove between filter for time field
2025-05-27 15:38:23 +05:30
Ejaaz Khan
c17b9bd25b fix: remove between filter for time field 2025-05-27 15:13:01 +05:30
Ejaaz Khan
b1b9efb158
Merge pull request #32688 from iamejaaz/36457-report-permission
fix: exclude if owner from accessing all report
2025-05-27 14:53:37 +05:30
Ejaaz Khan
9112ec2d97 fix: exclude if owner from accessing all report 2025-05-27 14:35:21 +05:30
Soham Kulkarni
162cc31dc0
Merge pull request #32681 from sokumon/number-card-issue
fix(number_card): undefined issue
2025-05-27 02:07:31 +05:30
sokumon
0081f5bc91 fix: undefined issue 2025-05-27 01:12:27 +05:30
Ankush Menat
78f7fa1429
perf: hoist constant computations for child table column order (#32677)
These don't/shouldn't change during execution of the function.
2025-05-26 19:39:29 +05:30
MochaMind
87f043b37f
fix: sync translations from crowdin (#32618) 2025-05-26 15:40:10 +02:00
Ankush Menat
e2d619504f
perf: batch bulk_insert (#32675)
* fix: reduce bulk insert batch size

Back when this feature was added it used to lazily evaluate the input.
Now the iterator is consumed upfront so large batch sizes == huge memory usage.

* perf: bring back iterator for bulk_insert

Bulk insert used to support iterator for consuming arbitrarily large
amount of data and inserting it. Since child table support was added, it
can't do it anymore because that requires collecting values.

This change now brings back iterators by batching input iterator (by
default 1000) documents.

This is almost as good as original change from design POV. Performance
is still meh for flat documents.
2025-05-26 13:36:53 +00:00
Ankush Menat
fe6ae9cd87
Merge pull request #32674 from ankush/perf_faster_imports
perf: faster imports
2025-05-26 15:55:53 +05:30
Ankush Menat
9920c8d033 fix: duplicate follow
This exists in `doc.insert()` not need to add it here too
2025-05-26 14:43:06 +05:30
Ankush Menat
c2d2fda212 perf: avoid clearing cache for newly imported documents 2025-05-26 14:42:54 +05:30
Ankush Menat
d3c88556bc perf: Skip version checking on new docs 2025-05-26 14:38:26 +05:30
Ankush Menat
cc1e843260 perf: Skip realtime notifications while importing 2025-05-26 14:31:46 +05:30
sokumon
633d2c3f84 fix: update image alignment package 2025-05-26 14:07:28 +05:30
sokumon
850f50cb4c fix: handling of enter on table cell 2025-05-26 01:06:01 +05:30
Ankush Menat
74aed9e231
refactor: redo maintenance cron logic (#32661)
The effect is same as before, except this allows migrating jobs between
old vs new queues without causing double executions on day of
migrations.
2025-05-25 05:02:29 +00:00
Ankush Menat
ca6c57faac
chore: nudge for using better console (#32656) 2025-05-23 12:52:43 +00:00
Soham Kulkarni
d3a5e8d13e
Merge pull request #32652 from sokumon/show-request-ip
fix: show request ip for easier debugging
2025-05-23 15:24:07 +05:30
sokumon
4900d60a35 fix: show request ip for easier debugging 2025-05-23 14:55:16 +05:30
Ankush Menat
04144d7544
Merge pull request #32642 from ankush/drop_down_console
feat: Dropdown Console
2025-05-23 14:11:22 +05:30
RitvikSardana
2f3295d685
Merge pull request #32651 from RitvikSardana/email-threading-fw
fix: find message id from in_reply_to field in communication
2025-05-23 13:27:52 +05:30
Ankush Menat
48496060e9 fix: warnings, log links, freeze window 2025-05-23 13:06:01 +05:30
RitvikSardana
9ff04c3f6f fix: find message id from in_reply_to field in communication 2025-05-23 12:47:48 +05:30
Ankush Menat
9a9fa28075 feat: show execution time
Since it's keyboard driven this also serves as "some UI feedback".
2025-05-23 12:38:16 +05:30
Abdeali Chharchhoda
4603a974ed Merge branch 'develop' into new-ui-for-api-key 2025-05-23 12:25:56 +05:30
Ankush Menat
7238bb00c1 fix: robust waiting for ace to be ready 2025-05-23 12:22:54 +05:30
Ankush Menat
726fb17e69 refactor: insert using editor, nothing else. 2025-05-23 12:09:39 +05:30
Ankush Menat
7387cc5fb5 refactor: use async everywhere 2025-05-23 12:02:52 +05:30
Ankush Menat
d9a36686d4 fix: focus on previous location 2025-05-23 11:59:33 +05:30
Ankush Menat
004af01a13 fix: hide from those who don't have perms 2025-05-23 11:51:36 +05:30
Ankush Menat
9fa2edf461 fix: unexpected commits 2025-05-23 11:51:36 +05:30
Ankush Menat
eef059231a fix: escape minimizes the system console
Better UX compared to opening it again and again.

This works as a scratch pad for WIP code.
2025-05-23 11:51:36 +05:30