Commit graph

48811 commits

Author SHA1 Message Date
Ejaaz Khan
d5b532d498 style: format code 2025-02-28 13:29:50 +05:30
Ankush Menat
17d6d81fb5
feat: mini pretty dates (#31331)
Narrow format pretty dates for list views, works the same way as client
side function.
2025-02-20 05:18:45 +00:00
Akhil Narang
6113452b73
Merge pull request #31320 from akhilnarang/drop-deprecated-method
refactor: utcfromtimestamp -> fromtimestamp(timezone.utc)
2025-02-19 18:09:01 +05:30
Sagar Vora
c8e4be7f5d
Merge pull request #31322 from sagarvora/fix-use-decorator 2025-02-19 17:44:00 +05:30
Sagar Vora
60b889c3b8 fix: ensure correct context in sys.exc_info 2025-02-19 17:33:53 +05:30
Ankush Menat
4997e5d223
fix: clear cache after db transaction ends (#31315)
This reduces probability of stale cache, but it's still very easily
possible because of repeatable read (!)
2025-02-19 11:44:37 +00:00
Akhil Narang
53b45f34bf
refactor: utcfromtimestamp -> fromtimestamp(timezone.utc)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-19 16:51:38 +05:30
Sagar Vora
a257a6a43e
Merge pull request #31312 from sagarvora/fix-desk-page-method 2025-02-19 16:44:00 +05:30
Ejaaz Khan
9bf5b9c0b9
Merge pull request #31305 from GuruWithin/fix-awesomplete-listitem-position
fix: allow Dynamic Link fieldtype in grid row click handler
2025-02-19 16:36:06 +05:30
Akhil Narang
e181bf118c
Merge pull request #31308 from akhilnarang/fix-xss
fix(send_message): escape HTML in the text
2025-02-19 16:33:40 +05:30
Sagar Vora
1af78e43b2 fix: update whitelisted methods 2025-02-19 16:32:09 +05:30
Sagar Vora
bb897cc61c
Merge pull request #31311 from sagarvora/remove-unused-import
chore: remove unused import
2025-02-19 14:53:13 +05:30
Sagar Vora
055f0b5a45 chore: remove unused import 2025-02-19 14:41:07 +05:30
Sagar Vora
c626229c7e
Merge pull request #31307 from sagarvora/fix-s69 2025-02-19 13:11:16 +05:30
Sagar Vora
4f374ee1c9 fix: ignore disable_traceback if _dev_server is True 2025-02-19 12:59:14 +05:30
Sagar Vora
1693991702 fix: remove dev server condition 2025-02-19 12:54:21 +05:30
Sagar Vora
fa252691b6 test: update status codes 2025-02-19 12:41:17 +05:30
Sagar Vora
09459d1d27 fix: ensure exception is always returned 2025-02-19 12:38:43 +05:30
Sagar Vora
d3bb578c2f fix: update type hints to allow integers 2025-02-19 12:31:12 +05:30
Akhil Narang
f2d0baf79d
fix(send_message): escape HTML in the text
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-19 12:23:47 +05:30
Sagar Vora
eded5eac24 fix: explicitly check type of form name 2025-02-19 12:17:31 +05:30
Sagar Vora
f4062b4d7a fix: ensure consistent error in response 2025-02-19 12:10:59 +05:30
Ankush Menat
e16f3b1c84
fix: set default, don't override cache headers (#31306)
Oof.
2025-02-19 11:28:34 +05:30
GuruWithin
1c85d9960a fix: allow Dynamic Link fieldtype in grid row click handler 2025-02-19 00:16:35 +05:30
Ejaaz Khan
91eee4fdf9
Merge pull request #31215 from aerele/report-custom-column
fix(report): add custom column based on link column
2025-02-18 23:23:01 +05:30
s-aga-r
85f7fb7922
refactor: Frappe Mail API (#29200) 2025-02-18 16:29:02 +05:30
Nihantra C. Patel
aed69f92f7
fix: hide create button for cancelled doc in dashboard links (#31295) 2025-02-18 14:55:39 +05:30
Akhil Narang
ef4ffbb304
Merge pull request #31290 from akhilnarang/fix-reportview-edit-if-has-table
fix(report_view): don't disallow editing just if a table exists
2025-02-18 11:24:48 +05:30
Akhil Narang
ccd8fb1f8b
Merge pull request #31269 from frappe/revert-29104-develop
Revert "fix: Improper routing for Report links when added to cards in workspaces"
2025-02-18 11:20:08 +05:30
Ankush Menat
611a03d1a2
Merge pull request #31283 from ankush/perf/rq_no_fork
perf: Support running RQ worker without forking
2025-02-17 19:16:21 +05:30
Ankush Menat
e2bd3abd62 fix: make nofork workers exit periodically 2025-02-17 18:55:25 +05:30
Ankush Menat
de7e6d0ba5 fix: force init background jobs 2025-02-17 18:47:59 +05:30
Ankush Menat
644bc5530e fix: Support stop-job, kill-horse etc 2025-02-17 18:40:11 +05:30
Ankush Menat
9dd005b21e refactor: separate worker type for nofork 2025-02-17 18:21:07 +05:30
Ankush Menat
0cebc61de1 fix: Exit worker on timeout exception
- Timeout in same process can leave bad state, so start a new worker.
- This isn't exactly costly, earlier we were forking all the time.
- Timeouts by definition can't happen too frequently.
2025-02-17 17:57:21 +05:30
Akhil Narang
24c2dfdf88
fix(report_view): don't disallow editing just if a table exists
If a table exists, go with the previous result. Else check and parse read_only conditions

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-17 17:49:52 +05:30
Ankush Menat
3b4e1bbb48 perf: Support running RQ worker without forking
Frappe does everything required to run jobs without forking.
- We cleanup locals
- Global caches are invalidated appropriately
- We destroy connections and open a new one for job/request

So we don't have any safety benefit much from forking for every job.
There can still be some code out in wild that relies on this behaviour
though!

Pros:
- Almost zero-overhead background jobs, just like web requests.

Cons:
- Timeout need to be implemented separately now
- Unknown side effects!
- Some features like "stop job" will need separate implementations.
2025-02-17 16:20:52 +05:30
venkat102
af39cc43ad fix: update doctype value 2025-02-17 12:29:14 +05:30
Ankush Menat
d0c3a8ee56
fix: check scheduler process status in health report (#31284)
Currently it's just checking if the scheduler is enabled or not. This PR
also adds a check to see if the process is running or not.
2025-02-17 05:04:07 +00:00
Ankush Menat
5fe0742ab9
fix: Avoid recency filters on dashboard connection filters (#31280) 2025-02-17 04:27:53 +00:00
Akhil Narang
02bcf6f1e9
Merge pull request #31268 from akhilnarang/fix-custom-report-link-list
fix: set `report_ref_doctype` for custom reports
2025-02-14 17:23:38 +05:30
Akhil Narang
051e0a6d4e
Revert "fix: Improper routing for Report links when added to cards in workspaces" 2025-02-14 16:30:59 +05:30
Akhil Narang
b5ee3b29cf
fix: set report_ref_doctype for custom reports
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-14 16:25:48 +05:30
Ejaaz Khan
44e9752bb1
Merge pull request #31263 from iamejaaz/grid-row-open-issue
fix: link field option disappear
2025-02-14 11:36:53 +05:30
Ejaaz Khan
ef27287c25 fix: link field option disapper 2025-02-14 11:15:00 +05:30
Ejaaz Khan
a1e9ecf9a4
Merge pull request #31259 from frappe/revert-28899-clean-communication-html
Revert "fix(_get_communications): clean email content before returning"
2025-02-14 00:26:45 +05:30
Ejaaz Khan
701e744211
Revert "fix(_get_communications): clean email content before returning" 2025-02-13 23:32:55 +05:30
Soham Kulkarni
54007f4a46
Merge pull request #31222 from sokumon/safari-icon
fix: replace espresso icon
2025-02-13 19:39:36 +05:30
Akhil Narang
c64aa6822e
Merge pull request #31245 from akhilnarang/bump-cryptography
chore(deps): bump cryptography to 44.0.1
2025-02-13 09:10:15 +05:30
Ejaaz Khan
29265f8df4
Merge pull request #29862 from iamejaaz/refactor-auto-repeat-29378
refactor: add validation and refactor code of auto repeat
2025-02-12 23:04:31 +05:30