Shivam Mishra
de00a651cc
Merge pull request #8656 from gavindsouza/id-name
...
fix: added title_field to filters, removed search icon
2019-11-04 14:02:29 +05:30
mergify[bot]
346819ccca
Merge pull request #8721 from ruchamahabal/auto_repeat_remove_old_traces
...
fix(patch): update status and set auto repeat as not submittable
2019-11-04 08:00:07 +00:00
mergify[bot]
cf1fcba9e5
Merge pull request #8754 from prssanna/dashboard-fix
...
fix(Dashboards): Fix dashboard date range
2019-11-04 07:52:34 +00:00
mergify[bot]
56e07fc2a3
Merge pull request #8709 from hrwX/list_form_int_fix
...
fix: convert number to string if title_field is Int
2019-11-04 07:46:44 +00:00
mergify[bot]
77d7f8fc92
Merge pull request #8649 from Alchez/dev-dashboard-internal-links
...
feat: allow internal links from parent document to show in dashboard
2019-11-04 07:42:02 +00:00
Faris Ansari
63af4c5b0a
fix: Update stale message
2019-11-04 13:05:36 +05:30
prssanna
160ecf1003
fix(Dashboards): Fix dashboard date range
2019-11-04 12:58:24 +05:30
mergify[bot]
0b72155c35
Merge pull request #8733 from makeen/develop
...
fix(API): allow update from request data (develop)
2019-11-04 07:27:52 +00:00
Faris Ansari
4bc53f901e
style: Fix formatting
2019-11-04 12:53:42 +05:30
mergify[bot]
0f5dbc031f
Merge pull request #8730 from frappe/sahil28297-patch-1
...
fix(email_queue): use send_one as email_queue is now an object
2019-11-04 07:18:39 +00:00
Suraj Shetty
7b05814dc7
fix: Handle null value
2019-11-04 12:20:33 +05:30
mergify[bot]
0f62dcae04
Merge pull request #8587 from prssanna/group-by-dashboard
...
feat(Dashboards): Add group by dashboard chart type
2019-11-04 06:31:53 +00:00
Rucha Mahabal
1eab4ad342
fix: codacy
2019-11-03 15:41:27 +05:30
Rucha Mahabal
5c64fbdb20
fix(patch): update status and set auto repeat as not submittable
2019-11-03 15:36:22 +05:30
mergify[bot]
72274be822
Merge pull request #8707 from ioweb-gr/develop
...
fix: add support for utf-8 characters in pdf filename during downloads
2019-11-03 09:55:06 +00:00
mergify[bot]
2321dac55d
Merge pull request #8748 from RJPvT/patch-3
...
feat: enable indicator for cancelled
2019-11-03 09:15:21 +00:00
RJPvT
c2687b4978
feat: enable indicator for cancelled
2019-11-03 09:34:58 +01:00
mergify[bot]
0ed43c118f
Merge pull request #8722 from surajshetty3416/add-parent-to-custom-docperm
...
fix: Add parent field to Custom DocPerm
2019-11-03 08:01:28 +00:00
mergify[bot]
546c1905bc
Merge pull request #8740 from frappe/Query-Report-QP
...
fix(Query Report View): Do not force set filters from URL Args
2019-11-03 06:49:25 +00:00
mergify[bot]
e5fca3d703
Merge pull request #8741 from cclauss/patch-1
...
fix(data_migration): Undefined name e in data_migration_run.py
2019-11-03 06:30:12 +00:00
mergify[bot]
69d4efd3af
Merge pull request #8742 from gavindsouza/reload-dev
...
fix: reload via navbar does not reroute to homepage
2019-11-02 14:18:18 +00:00
Gavin D'souza
6a5692e728
fix: reload via navbar doesnt re-route to homepage
2019-11-02 19:23:42 +05:30
Christian Clauss
fac8dbff01
Undefined name: e in data_migration_run.py
...
The current code raises a NameError which is never logged.
[flake8](http://flake8.pycqa.org ) testing of https://github.com/frappe/frappe on Python 3.8.0
$ __flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics__
```
./frappe/data_migration/doctype/data_migration_run/data_migration_run.py:417:63: F821 undefined name 'e'
self.update_log('pull_failed', {migration_id_value: cstr(e)})
^
./frappe/patches/v5_0/fix_email_alert.py:12:37: F821 undefined name 'email_alert'
notification.days_in_advance = -email_alert.days_in_advance
^
2 F821 undefined name 'e'
2
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org ) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2019-11-02 13:12:45 +01:00
Saif
daf1553d70
fix(Query Report View): Do not force set filters from URL Args
...
No need to force set filters from URL Args
It is already set in the method `set_route_filters` to the Query Report's model
Currently if there are URL Arguments then even if you change the filters in the report view, the URL Args will override them.
2019-11-02 11:05:16 +05:00
Revant Nandgaonkar
a633d22945
Merge pull request #8720 from revant/port-code
...
fix: add missing code for social login key
2019-11-01 13:50:37 +05:30
makeen
efe94886a8
Update api.py
2019-11-01 00:53:29 +01:00
mergify[bot]
0e38a965ad
Merge pull request #8670 from Alchez/dev-search-with-special-char
...
fix: include items with hyphen in global search irrespective of query
2019-10-31 17:24:58 +00:00
sahil28297
d53dc85fc1
fix(queue): use send_one as email_queue is now an object
...
TypeError: 'EmailQueue' object is not callable
2019-10-31 18:55:03 +05:30
Suraj Shetty
2816a87ca4
fix: Add parent field to Custom DocPerm
2019-10-31 17:04:45 +05:30
Suraj Shetty
6b08730a09
style: fix codacy
2019-10-31 15:14:37 +05:30
mergify[bot]
340b2b036a
Merge pull request #8711 from hrwX/no_customize_form_for_custom_dt
...
fix: Reroute to doctype if custom doctype
2019-10-31 09:43:21 +00:00
mergify[bot]
fdb0beb197
Merge pull request #8715 from prssanna/notifications-fix
...
fix: Red badge icons on dashboard not working
2019-10-31 09:42:46 +00:00
Suraj Shetty
93583e4e66
fix: Route to Customise Form if meta does not exists
2019-10-31 14:51:32 +05:30
Suraj Shetty
3bb28ee013
fix: Remove unwanted check
2019-10-31 14:47:55 +05:30
mergify[bot]
991f559f05
Merge pull request #8719 from thefalconx33/float_parse_fix
...
fix: number format issue while parsing float values
2019-10-31 09:15:03 +00:00
Suraj Shetty
2345d90598
fix: typo in email template ( #8717 )
...
fix: typo in email template
2019-10-31 14:16:56 +05:30
mergify[bot]
f772151bd1
Merge pull request #8710 from scmmishra/clear-filter-patch
...
fix: hide clear-filter by default
2019-10-31 08:41:56 +00:00
Rucha Mahabal
6d9d110a6a
fix: ignore validations for frappe.flags.in_patch
2019-10-30 19:49:59 +05:30
Revant Nandgaonkar
314aed831b
fix: add missing code for social login key
...
add missing code for using custom social login key
2019-10-30 17:26:45 +05:30
prssanna
05a845547a
fix: codacy
2019-10-30 17:25:12 +05:30
thefalconx33
69fbdf4208
fix: parsing of float value
2019-10-30 16:59:18 +05:30
prssanna
7b7130d979
fix: codacy
2019-10-30 16:51:49 +05:30
Shivam Mishra
30052bb403
fix: typo in email template
2019-10-30 14:15:28 +05:30
prssanna
325a2c864e
fix: Allow show_open_count_list to be called outside class
2019-10-30 12:07:44 +05:30
Shivam Mishra
8334845627
fix: hide clear-filter by default
2019-10-30 11:41:49 +05:30
Himanshu Warekar
e6ca8545a4
fix: reroute to doctype if custom
2019-10-30 11:09:02 +05:30
Himanshu Warekar
b305301f24
fix: convert int to string if title_Field
2019-10-30 10:54:08 +05:30
Shivam Mishra
9bbd627db8
Merge pull request #8702 from hrwX/align-dropdown
...
fix(Select): specify top for dropdown arrow
2019-10-30 10:37:59 +05:30
IOWEB TECHNOLOGIES
a4585bfcd9
add support for utf-8 characters in pdf filename during downloads
2019-10-29 23:33:23 +02:00
Suraj Shetty
642c025652
Merge pull request #8705 from surajshetty3416/grid-arrow-fix
...
fix(grid): Arrow Key Navigation
2019-10-29 22:08:44 +05:30