Commit graph

44099 commits

Author SHA1 Message Date
Akhil Narang
e1bbcd73ab
fix: 0 is falsy, set correct defaults
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 16:14:50 +05:30
Akhil Narang
e3f6437245
fix(postgres): properly change nullability and default values
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 16:14:50 +05:30
Akhil Narang
ea7f611745
fix: adapt tests to actually work
Couldn't seem to sanely get postgres default state

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 16:14:50 +05:30
Akhil Narang
75c8445b6a
refactor: cleanup column definition
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
5598fe241e
fix: use default default if a custom default isn't specified
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
b901f37267
feat(postgres/schema): add support for setting fields as not-nullable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
558ac413ce
fix(mariadb/schema): use correct default value
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
731c5c8cd5
refactor(db_query): check for docfield not_nullable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
10ad99869a
feat: use user-specified default value if passed
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
8d91e4524f
feat(exporter): handle docfield being non-nullable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
8d540963c8
refactor(mariadb/schema): use sql_ddl() method
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
ccc2bdad52
fix: go back to original transaction handling mechanism
This reverts the following:
07acfeed47 chore: move check_implicit_commit() call back to its original location
fc38a0b503 chore: simplify transaction handling
1e29e81543 chore: rework implicit commit checks
ae0a3fd202 feat: allow ignoring implicit commit warning

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
4855ec76c2
chore: use index to access table column instead of getattr
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
7d3295f09e
fix(doctype): update query was broken
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
5a4053fe2c
chore: make use of non_nullable to avoid ifnull usage
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
12a0afd91f
refactor: cleanup DbColumn.get_definition()
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
b88f3597fa
chore: add in tests for non-nullable field
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
5e6be19fe3
chore(DbColumn): force constructor arguments to be kwargs
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
6b49b5f32a
chore: move check_implicit_commit() call back to its original location
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
806748b063
chore: simplify transaction handling
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
fe549ecc49
chore: don't check for semgrep here
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
f9b9184223
chore: rework implicit commit checks
Add in some more "reset" queries
- begin
- start

Also check *after* resetting

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
58b8b26b93
chore(mariadb): switch to using query builder for update statement
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
e41fa2dfc7
feat: migrate columns to be non-nullable if required
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
6550e0769b
feat: allow ignoring implicit commit warning
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
4f9ee8b633
feat(DbColumn): set non_nullable attribute and make use of it for column definition
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
15c925ccc7
feat: check for docfield not_nullable property to decide whether a field can be nullable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
390d4e1b13
chore: drop unused variables and parameters
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
75709eede7
feat: set a non-null value if docfield isn't set as nullable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
18867b273f
chore: make return type annotation make more sense
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
0026a6ceac
feat(docfield): add in a nullable checkbox field
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:55 +05:30
mergify[bot]
a7171918ee
Merge pull request #22592 from blaggacao/feat/into-child-mapper
feat(model): implement into-child table mapper
2023-11-16 07:17:16 +00:00
David Arnold
0ff08e4e0f
build(python): restricted python goes up to 3.11 only (#23229) 2023-11-15 18:23:42 +05:30
Suraj Shetty
3cd1fe0636
Merge pull request #22824 from bosue/bolden_match_part 2023-11-15 12:48:59 +05:30
Suraj Shetty
54c9ba715d
Merge pull request #23165 from hyaray/patch-1 2023-11-15 12:43:24 +05:30
Suraj Shetty
8f2db21f64
Merge pull request #23143 from blaggacao/fix/float-input-formatting 2023-11-15 12:33:46 +05:30
RitvikSardana
0c4245634f
feat: Apply Filters to Link Fields Via Form Builder (#22844)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-15 11:34:19 +05:30
Raffael Meyer
5d66112518
Merge pull request #23224 from barredterra/email-linking 2023-11-15 01:44:47 +01:00
barredterra
0911299ace test: mark as spam 2023-11-15 01:05:40 +01:00
barredterra
1aea320dfe refactor: mark as spam 2023-11-15 01:05:32 +01:00
barredterra
73a0ed9f15 fix: set status last 2023-11-15 00:44:22 +01:00
barredterra
6e753cf118 refactor: deduplication logic 2023-11-15 00:33:19 +01:00
barredterra
46a34e25e8 test: parse links in email 2023-11-15 00:01:13 +01:00
barredterra
329531bf6e feat: link communication by email 2023-11-14 23:27:27 +01:00
barredterra
2507c6af97 fix: check the correct email account 2023-11-14 23:25:34 +01:00
barredterra
02e3e23b4c refactor: email linking 2023-11-14 23:24:36 +01:00
David Arnold
91e22446d2
Merge remote-tracking branch 'upstream/develop' into feat/into-child-mapper 2023-11-13 10:03:38 +01:00
David Arnold
3559c8bc18
Merge remote-tracking branch 'upstream/develop' into fix/float-input-formatting 2023-11-13 10:00:16 +01:00
Suraj Shetty
49beb0c48e
Merge pull request #23203 from surajshetty3416/auto-format-vue-files 2023-11-13 12:40:47 +05:30
Suraj Shetty
a306818e49 ci: Ignore website theme file which has jinja in it 2023-11-13 11:53:55 +05:30