vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
42771 commits 1 branch 0 tags 587 MiB
Commit graph

42771 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ankush Menat
e51646faf6
Merge pull request #21762 from ankush/perf_requests 
perf!: Reduce db call and reads in typical requests
 2023-07-22 18:27:22 +05:30
mergify[bot]
a86125ac41
Merge pull request #21763 from resilient-tech/fix-preferred-language-setter 
fix: no API call required to set cookie in browser
 2023-07-22 12:47:08 +00:00
Ankush Menat
2c99583247 perf: Lazily fetch shared documents 
We eagerly fetch shared documents for ANY `get_list` query, even when
user has full read acess doctype, where it's moot to consider adding
shared document as separately.

This eliminates one entire db call from get_list and in most cases
get_list will translate to single DB call, hence probably worth the
additional complexity.
 2023-07-22 18:04:35 +05:30
Sagar Vora
d2becc7f1d fix: no API call required to set cookie in browser 2023-07-22 17:54:41 +05:30
Ankush Menat
eed90a871b perf!: halve search_link page size 
20 results are rarely scrolled by user.

Most users end up typing more characters to narrow down results. This
way on large table we end up reading significantly fewer rows.

The way relational DBs work is they keep filtering and reading rows one
by one until limit is hit, so smaller the limit the better.
 2023-07-22 15:09:14 +05:30
Ankush Menat
f989b83d33 perf: drop total_comments 
Can be done client side, also not used anywhere.
 2023-07-22 15:09:11 +05:30
Shariq Ansari
319da422f9
Merge pull request #21761 from shariquerik/separate-fetch-from-control 2023-07-22 14:20:33 +05:30
Ankush Menat
740fe1fc91 perf: reduce 1 query in getdoc 2023-07-22 14:16:08 +05:30
Shariq Ansari
95167a19df fix: remove store from each control 2023-07-22 13:07:50 +05:30
Shariq Ansari
c58f4e152c fix: separate fetch from field code from text control 2023-07-22 12:53:45 +05:30
Ankush Menat
9608c32db7
perf: lazy load dashboard links (#21752) 2023-07-21 13:10:30 +05:30
Faris Ansari
ebacca3863
fix: better job naming for enqueue_doc (#21755) 
DocType.method instead of frappe.utils.background_jobs.run_doc_method
 2023-07-21 11:45:06 +05:30
Ankush Menat
fb2ab0b5be
Merge pull request #21737 from ankush/perf/workflow_transitions 
perf: workflow transitions and bulk workflow
 2023-07-20 17:30:40 +05:30
Gughan Ravikumar
b2d32a2d63
Don't allow export of Virtual DocFields (#21749) 2023-07-20 17:25:12 +05:30
Ankush Menat
c90374c286 perf: Lazily compute common workflow transitions 2023-07-20 16:45:23 +05:30
Ankush Menat
e2bd9d5269 fix(rq_worker): show current job iff for same site 2023-07-20 14:05:24 +05:30
Ankush Menat
96e6291692
fix: don't allow setting 0 as max backups (#21747) 
This causes new backups to get deleted immediately.

If you want only 0 backups, then don't take backups.
 2023-07-20 13:52:54 +05:30
Shariq Ansari
a34d87d440
Merge pull request #21706 from shariquerik/oauth-confirm-screen 2023-07-20 12:22:07 +05:30
Ankush Menat
c2a5adadbe
fix: actually debounce list view updates (#21738) 
Immediately debouncing and executing creates a new function everytime and doesn't actually "debounce" it just "delays". 🗿

[skip ci]
 2023-07-19 20:42:43 +05:30
Ankush Menat
948b24ee04 fix: duplicate on_row_checked call 2023-07-19 19:38:07 +05:30
Ankush Menat
06a905f600 fix: disable list view updates during bulk approval 
Also defer document refreshes by up to 5 seconds.

Rarely anyone needs truly realtime list view updates. It's better batch
them over at least 5 or so seconds if there's a high volume of changes.
 2023-07-19 19:38:05 +05:30
Ankush Menat
453892cdef
fix!: Dont show bold fields in quick entry. (#21733) 
IDK if "BOLD" implies it should be shown in quick entry.
Frequent misunderstanding: https://github.com/frappe/frappe/issues/21726
 2023-07-19 17:27:26 +05:30
Ankush Menat
892c5e30a2 refactor: Simpler workflow caching 
Entire document is cached, so no need to create another layer of cache.
 2023-07-19 16:45:44 +05:30
Ankush Menat
d68e46d2cc fix: disable workflow emails by default 
make it opt-in instead.
 2023-07-19 16:45:44 +05:30
Ankush Menat
42aff950ce
feat(DX): normalize queries in recorder (#21735) 
Attempt to normalize query by removing "variables"
This gives a different view of similar duplicate queries.

These two are distinct queries:
```sql
select * from user where name = 'x'
select * from user where name = 'z'
```

But their "normalized" form would be same:
```sql
select * from user where name = ?
```

This helps highlight queries ran in loop which might not register as
duplicate but are possibly "duplicate".
 2023-07-19 16:45:30 +05:30
Shariq Ansari
ce79dd0b89 fix: increase form builder height 2023-07-19 12:44:40 +05:30
Ankush Menat
6dda420176 ci: dont run tests on every push 
Rationale:
- PRs already run test by merging PR in develop branch (this is how
  github works)
- Running tests on practically identical code JUST after merge rarely
  helpes. This has found failures from conflicting changes maybe once or
  twice a year. That much CO2 is not justified.
- Instead added daily scheduled tests so things like cypress dashboards
  still work and a *bisect* if requried in future can be done.
 2023-07-19 12:15:41 +05:30
Ankush Menat
03a582d7cd
build(deps): update pyyaml to 6.0.1 (#21728) 2023-07-19 11:41:17 +05:30
Ritwik Puri
5b547d5665
Merge pull request #21724 from phot0n/allow-bulk-retry-email 
fix: allow users having access to email queue to bulk retry sending
 2023-07-19 02:12:59 +05:30
phot0n
df3f6b3a9f fix: allow users having access to email queue to bulk retry sending 2023-07-19 02:11:10 +05:30
Shariq Ansari
264372a2a3 fix: show list of user details that we are giving access to if scope is openid 2023-07-18 20:53:31 +05:30
Suraj Shetty
688fa27456
Merge pull request #21718 from barredterra/clear-language-cache 2023-07-18 17:27:09 +05:30
barredterra
c39473b9b0 fix: invalidate cache when language is updated 2023-07-18 13:02:08 +02:00
barredterra
588bbd9d1c fix: include languages when clearing website cache 2023-07-18 12:53:57 +02:00
mergify[bot]
9c481cfd68
Merge pull request #21680 from resilient-tech/compare-amended-from 
fix: compare with `doc.amended_from` while saving version for newly amended doc
 2023-07-18 04:22:32 +00:00
Gursheen Kaur Anand
149467a71b
fix: fetch portal sidebar items (#21703) 2023-07-18 09:34:52 +05:30
Shariq Ansari
ed9848a133
Merge pull request #21710 from shariquerik/page-layout-breaking 2023-07-17 19:05:15 +05:30
Shariq Ansari
a5025cbd0c build(deps): Again bump bootstrap to v4.6.2 2023-07-17 18:21:12 +05:30
Shariq Ansari
f4c4de4c6e
Merge branch 'frappe:develop' into page-layout-breaking 2023-07-17 18:20:14 +05:30
Shariq Ansari
06d8a6ba9b fix(UI): pae layout breaking after upgrading bootstrap to v4.6.2 2023-07-17 17:49:02 +05:30
Ankush Menat
e50ff81f41 Revert: bootstrap update 2023-07-17 17:06:47 +05:30
Sagar Vora
86f0c4e52c fix: store version for name 2023-07-17 16:13:44 +05:30
Sagar Vora
7d7c440a1b fix: compare with doc.amended_from while saving version for newly amended doc 2023-07-17 16:04:28 +05:30
Shariq Ansari
cbe9ec26bd fix: do not show Home primary button 2023-07-17 15:48:30 +05:30
Sagar Vora
d11768d928
Merge pull request #21707 from resilient-tech/social-login-links 2023-07-17 14:34:00 +05:30
Sagar Vora
4684e72142 fix: use current redirect URIs instead of legacy ones 2023-07-17 14:29:22 +05:30
Shariq Ansari
539607d87a fix(UX): OAuth confirm access screen 2023-07-17 13:09:38 +05:30
Ankush Menat
8436f775a5
feat(DX): PEP517 compatible build in new apps (#21704) 
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes https://github.com/frappe/frappe/issues/21612
 2023-07-17 12:56:41 +05:30
Deepesh Garg
e38078a69f
test: Patch hooks for testing (#21702) 
* test: Patch hooks for testing

* test: hooks patcher

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-07-17 12:41:27 +05:30
Raffael Meyer
b6cd6535db
feat: better Email search (#20323) 
* refactor: get_contact_list

* test: get_contact_list

* feat: search all emails, not just the primary one
 2023-07-17 00:40:17 +05:30