Commit graph

45797 commits

Author SHA1 Message Date
barredterra
e7b65db73a refactor: like and unlike 2024-03-19 19:42:12 +01:00
Ankush Menat
cc2c39d583
fix: avoid translating layout field labels (#25548)
- section
- tabs

Resolves https://github.com/frappe/frappe/pull/25482#discussion_r1530827772
2024-03-19 18:01:39 +00:00
Raffael Meyer
246f92dba0
refactor: remove dead code (likes-count) (#25528) 2024-03-19 23:25:00 +05:30
Ankush Menat
f4169d7870
Merge pull request #25506 from revant/feat-redis-sentinel-for-queues
feat: connect to redis sentinel for redis queue
2024-03-19 22:59:29 +05:30
Ankush Menat
e47e76897a
fix: notify on failed s3 backup upload (#25544) 2024-03-19 15:50:37 +00:00
Akhil Narang
288a7c3fc2
Merge pull request #25538 from akhilnarang/fix-undefined-document
fix: prevent TypeError if doc not defined
2024-03-19 17:34:43 +05:30
Akhil Narang
d978ca8ca5
Merge pull request #25533 from akhilnarang/fix-undefined-fields
fix: handle meta.fields being undefined
2024-03-19 17:34:16 +05:30
Akhil Narang
978e3407b6
fix: prevent TypeError if doc not defined
Happens here on a local setup if I click `Compose Email` button

communication.js:212 Uncaught TypeError: Cannot read properties of undefined (reading 'doc')
    at frappe.views.CommunicationComposer.guess_language (communication.js:212:32)
    at frappe.views.CommunicationComposer.setup_print (communication.js:536:8)
    at frappe.views.CommunicationComposer.prepare (communication.js:239:8)
    at frappe.views.CommunicationComposer.make (communication.js:41:8)
    at new frappe.views.CommunicationComposer (communication.js:16:8)
    at Object.primary_action (communication__list_js:34:3)
    at HTMLButtonElement.<anonymous> (list_view.js:1426:19)
    at HTMLButtonElement.dispatch (jquery.js:5135:27)
    at elemData.handle (jquery.js:4939:28)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-19 17:21:28 +05:30
Raffael Meyer
7be963345b
Merge pull request #25530 from earona/feat-doctype-extractor 2024-03-19 11:56:26 +01:00
Akhil Narang
674ca78cfe
fix: handle meta.fields being undefined
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-19 12:26:17 +05:30
Suraj Shetty
6992bbba8a
Merge pull request #23906 from Shankarv19bcr/multiselect_list
fix(UX): Multiselect List control
2024-03-19 10:51:17 +05:30
Exequiel Arona
9a0761f1c0
fix: suggested correction applied
frappe/gettext/extractors/doctype.py

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2024-03-19 00:04:22 -03:00
Exequiel Arona
9033f5c65d feat: add description of doctype to extractor 2024-03-18 19:26:32 -03:00
Frappe PR Bot
99a8ff885e
fix: sync translations from crowdin (#25508)
* fix: Spanish translations

* fix: French translations

* fix: German translations

* fix: Spanish translations

* fix: Arabic translations

* fix: Persian translations
2024-03-18 21:18:06 +05:30
Ankush Menat
fa6ec99c89
fix: escape text types before setting disp area (#25520) 2024-03-18 21:17:09 +05:30
Raffael Meyer
0ec8f8f108
fix: disable selected page length button (#25519) 2024-03-18 20:41:43 +05:30
Ankush Menat
d7f82bc260
fix: escape value in multiselect pill (#25516) 2024-03-18 20:11:28 +05:30
Ankush Menat
a87948befe
Merge pull request #25502 from ankush/signal
feat: debug stuck process by sending SIGUSR1
2024-03-18 19:35:10 +05:30
Ankush Menat
fdd74e3ac1 fix: set sane default timeout on SMTP 2024-03-18 19:19:32 +05:30
Ankush Menat
8a7beebf30
fix: handle distinct for fieldname (#25511)
`distinct count(fieldname)` is supported well but `count(distinct fieldname)` fails if fieldname contains full field with table name included. This PR just adds basic handling for it.

Needs to be rewritten entirely in QB __some day__.
2024-03-18 13:38:29 +00:00
Fisher Yu
41a7b42f16
fix: Translate form and workflow builder (#25482)
* Update AttachControl.vue

* Update ButtonControl.vue

* Update CheckControl.vue

* Update CodeControl.vue

* Update DataControl.vue

* Update ImageControl.vue

* Update LinkControl.vue

* Update RatingControl.vue

* Update SelectControl.vue

* Update SignatureControl.vue

* Update TableControl.vue

* Update TextControl.vue

* Update TextEditorControl.vue

* Update Section.vue

* Update Column.vue

* Update Tabs.vue

* Update Field.vue

* Update Sidebar.vue

* Update AddFieldButton.vue

* Update AddFieldButton.vue

* Update Section.vue

* Update WorkflowBuilder.vue

* Update Autocomplete.vue

* Update EditableInput.vue

* Update AttachControl.vue

* Update ButtonControl.vue

* Update CheckControl.vue

* Update CodeControl.vue

* Update DataControl.vue

* Update ImageControl.vue

* Update LinkControl.vue

* Update RatingControl.vue

* Update SelectControl.vue

* Update SignatureControl.vue

* Update TextControl.vue

* Update TextEditorControl.vue

* Update Field.vue

* Update EditableInput.vue

* Update TableControl.vue

* Update Column.vue

* fix: variable in translatable string

* fix: add context for row number label

* fix: translate labels in workflow builder

* style: formatting

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-18 18:41:50 +05:30
Akhil Narang
6c767bf8d6
fix: skip setting of contact full name if its too long (#25509)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-18 18:38:23 +05:30
David Arnold
56f1ed4fb3
fix: exclude irrelevant regional links (#25510) 2024-03-18 18:37:43 +05:30
Ankush Menat
6560d4587a fix: debug stuck process by sending SIGUSR1
It will print stack to stderr.
2024-03-18 11:59:47 +05:30
Revant Nandgaonkar
e9ece3b283 feat: connect to redis sentinel for redis queue 2024-03-18 06:10:31 +00:00
Ankush Menat
0a81407304
perf: Skip running webhook code if method is not supported (#25498)
E.g. `doc.run_method("autoname")` triggers webhook code for no reason.
2024-03-18 10:01:15 +05:30
Frappe PR Bot
59ba66f004
chore: update POT file (#25493) 2024-03-17 20:56:39 +05:30
Ankush Menat
adf24b24d4
perf: use base32 space for random names instead of base16 (#25497) 2024-03-17 20:02:57 +05:30
Ankush Menat
ef6af0b0ad
test: setup signal and faulthandler to debug stuck tests (#25494) 2024-03-17 11:01:34 +00:00
Ankush Menat
2f87a09ad9
test: fix timeout decorator (#25489) 2024-03-16 15:59:04 +05:30
Raffael Meyer
21cc09e28a
fix: allow page length 2500 (#25062) 2024-03-15 21:10:53 +05:30
Frappe PR Bot
f66ea45e29
fix: sync translations from crowdin (#25286)
* fix: Spanish translations

* fix: Spanish translations
2024-03-15 14:08:00 +00:00
Ankush Menat
ce124d8ec2
fix: Skip virtual doctype rename for dynamic links (#25479) 2024-03-15 14:01:40 +00:00
Ankush Menat
b28db475fd
fix: Skip virtual doctypes while renaming (#25473) 2024-03-15 18:56:22 +05:30
Ankush Menat
d4bb72b74f
Merge pull request #25419 from frappe/cust_form_text
fix: allow transitioning to long text
2024-03-15 18:14:10 +05:30
Ankush Menat
48c24c7c5b test: fixup timeouts
The tests were failing because they weren't able to complete in 20
seconds. Ugh!
2024-03-15 17:58:57 +05:30
Ankush Menat
0ca0e22376 ci: setup ssh if test failed 2024-03-15 16:25:51 +05:30
Ankush Menat
05f23dc4a9
test: return string (#25466)
Looks like formatted by mistake :dead:
2024-03-15 16:16:34 +05:30
Corentin Flr
71cfeb14c0
fix(ControlText): Preserve indentation when read only (#25262) 2024-03-15 16:15:12 +05:30
Corentin Flr
1b67db7aa1
feat(kb): Add list for help article (#25102) 2024-03-15 16:12:54 +05:30
Corentin Flr
e30fdb66a4
fix(QuickEntry): Don't allow Tab Breaks (#24950) 2024-03-15 16:11:26 +05:30
Corentin Flr
0cf58cac07
chore(weblist): Fix data-txt encoding, remove notxt (#25101) 2024-03-15 15:51:39 +05:30
Exequiel Arona
7042a6f63d
feat: add extractor for label of number card (#25414) 2024-03-15 15:48:10 +05:30
Raffael Meyer
bac6de26c0
fix: deterministic ordering (#25278)
* fix: deterministic ordering

* perf: use same order to avoid full table scan

* fix: Skip unique-ish keys from tie breaking

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-15 15:46:02 +05:30
Ankush Menat
7640ebad55
Merge pull request #24828 from marination/txt-attachment-privacy
fix: Use doctype setting to set auto-extracted file as private
2024-03-15 15:06:50 +05:30
Ankush Menat
02fd017204 fix: allow transitioning to long text 2024-03-15 15:00:07 +05:30
Ankush Menat
aa51492697 Merge branch 'develop' into txt-attachment-privacy 2024-03-15 14:53:45 +05:30
Kevin Shenk
396bc4102e
fix: default filter setup on todo list (#25455)
* fix: default filter setup on todo list

Since `frappe.route_options` is an empty object by default, the condition needs updated from `!frappe.route_options` to `!Object.keys(frappe.route_options).length`.

Also, `allocated_to` is a better default filter for the To Do list compared to the previous `owner` filter.

Further, this contained the only use of `page.add_sidebar_item()` in all of the current Frappe and ERPNext codebase, and that function neither makes sense or works anymore, so it should be removed.

* refactor: remove deprecated add_sidebar_item

* style: format files

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-15 09:20:54 +00:00
Ankush Menat
b6f65eaff7
Merge pull request #25459 from ankush/post_hog_memory_hog
perf: avoid importing posthog if not required
2024-03-15 11:43:36 +05:30
Ankush Menat
b7a5884344 perf: import sentinal locally 2024-03-15 11:31:04 +05:30