* fix: remove read_only decorator from get_desktop_page
get_desktop_page leads to a call to check_completions which calls save and thus with the read_only decorator calls save on the read replica
* fix: Move write operation out of read only request
* fix: deprecated initHighlighting
Deprecated as of 10.6.0. initHighlighting() is deprecated. Use highlightAll() instead.
---------
Co-authored-by: Apile Tyumre <apiletyumre@iridescentsun.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* fix: use actual file name for private files
* fix: add id to download button
* fix: add fid in view file too
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Users with only 'select' permission can now filter, order by, and
group by all permlevel 0 fields, not just search fields.
- Added _get_filterable_fields() returning all permlevel 0 fields
for select permission users
- Split permission checking into check_select_field_permission()
and check_filter_field_permission()
- select field validation uses check_select_field_permission
- Filter/order/group by validation uses check_filter_field_permission
* fix: update pagination count to reflect inline filter scope in Report View and show appropirate no data message
* refactor: more explicit messages and center no data message
* fix: Translate user facing string
---------
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* fix(schema): drop unique constraint and indexes for deleted doctype fields
* refactor(schema): rename a variable and remove commented code
* test: add test case for dropping unique constraint on field deletion from doctype
* fix(tests): prevent list mutation during iteration
* test(db): guard MariaDB-specific unique index test with db_type_is.MARIADB
* fix(schema): drop unique constraints and indexes for deleted fields on postgres
* fix(schema): make postgres unique cleanup idempotent for deleted fields
* fix(schema): make postgres unique cleanup idempotent on reload
* test: add test case for dropping unique constraint and index on field deletion for postgres
* fix(schema): make postgres unique cleanup idempotent
* fix(utils): add type hints to whitelisted methods
* fix(desktop): add type hints to whitelisted methods
* fix(listview): add type hints to whitelisted methods
* fix(access_log): add type hints to whitelisted methods
* fix(setup_wizard): add type hints to whitelisted methods
* fix(notification_settings): add type hints to whitelisted methods
* fix(calendar): add type hints to whitelisted methods
* fix(notifications): add type hints to whitelisted methods
* fix(query_report): add type hints to whitelisted methods
* fix(load): add type hints to whitelisted methods
* fix(save): add type hints to whitelisted methods
* fix(user): add type hints to whitelisted methods
* fix: correct Document import
* fix(list_view_settings): add type hints to whitelisted methods
* fix(reportview): add type hints to whitelisted methods
* fix(treeview): add type hints to whitelisted methods
* fix(linked_with): add type hints to whitelisted methods
* fix(bulk_update): add type hints to whitelisted methods
* fix(assign_to): add type hints to whitelisted methods
* fix(workspace): add type hints to whitelisted methods
* fix(kanban_board): add type hints to whitelisted methods
* fix(event): add type hints to whitelisted methods
* fix(email): add type hints to whitelisted methods
* fix(exporter): add type hints to whitelisted methods
* fix(permission_manager): add type hints to whitelisted methods
* fix(dashboard_chart): add type hints to whitelisted methods
* fix(number_card): add type hints to whitelisted methods
* fix(tag): add type hints to whitelisted methods
* fix: add hook to force type hints on all whitelisted endpoints
* fix: target_doc can be dict/json string
* fix: doc can be dict/json string
* fix(tests): add type hints to whitelisted methods in test
* fix: tree method is optional
* test: Fix test api types
* chore: drop dead code
* fix: document can be int
* fix: Number card input can be document
As utils in some other API calls
* fix: Always use session user
The only usage of this API that makes sense.
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
Currently you could be left with unusable sites
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* fix(apps): add type hints to whitelisted methods
* fix(recorder): add type hints to whitelisted methods
* fix(comments): add type hints to whitelisted methods
* fix(oauth2): add type hints to whitelisted methods
* fix(google_calendar): add type hints to whitelisted methods
* fix(print): add type hints to whitelisted methods
* fix(print_format_builder): add type hints to whitelisted methods
* refactor(network_printer_settings): remove unused args
* fix(document): add type hints to whitelisted methods
* fix(user_settings): add type hints to whitelisted methods
* fix(mapper): add type hints to whitelisted methods
* fix(connected_app): add type hints to whitelisted methods
* fix(google_contacts): add type hints to whitelisted methods
* fix(frappecloud_billing): add type hints to whitelisted methods
* test: rewrite test to fit the strict type check
* fix(social_login_key): add type hints to whitelisted methods
* fix(share): add type hints to whitelisted methods
* fix(webhook): add type hints to whitelisted methods
* fix(workflow): add type hints to whitelisted methods
* fix(workflow main): add type hints to whitelisted methods
* fix(workflow_action): add type hints to whitelisted methods
* fix: flexible type hint
* fix(client): add type hints to whitelisted methods
* fix: fix some of the tighter types
* fix(frappecloud_billing): add str typehint to whitelisted endpoint
* fix: target_doc can be dict/json string
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
fixes#31662
fixed select_all logic where disabled checkboxes did not trigger clicks and stayed in the opposite checked state.
although now it is not possible to trigger select_all if RolesEditor is disabled as the buttons to make that function call are also diabled, but this logic acts as a failsafe.
