Commit graph

43346 commits

Author SHA1 Message Date
Ankush Menat
f1ffc3fd39 test: fix bankers rounding test
One more `null` needs to be passed for "not passing precision"
2023-09-18 11:42:21 +05:30
Ankush Menat
7b91df0db6 Merge branch 'develop' into blaggacao/develop 2023-09-18 11:36:38 +05:30
David Arnold
2ddd808b58
test: add more test cases with number & currency formatting 2023-09-17 16:44:13 +02:00
David Arnold
0568795edd
Revert "fix: make flt value idempotent"
This reverts commit 4d0b0d35ef.
2023-09-17 15:39:57 +02:00
David Arnold
9f0c8be183
test: add failing test case for js flt 2023-09-17 15:36:36 +02:00
mergify[bot]
3239636e7d
Merge pull request #22187 from cogk/ux-list-view-sort-columns
feat(list): Sort by column by clicking on col title
2023-09-17 07:19:26 +00:00
Corentin Flr
2f1119bfcc
Merge branch 'frappe:develop' into ux-list-view-sort-columns 2023-09-17 08:57:37 +02:00
Ankush Menat
ea7b080e70 chore: nudge towards properly skipping onboarding
Escape doesn't totally skip
2023-09-15 19:14:24 +05:30
Ankush Menat
4ae3aaf6ac Revert "fix: defer first tour until awesomebar is triggered"
This reverts commit 60615a126c.
2023-09-15 19:04:55 +05:30
Shariq Ansari
4c4b4f61af
Merge pull request #22379 from shariquerik/nested-custom-reports-filter-fix
fix: nested custom reports filter not rendering
2023-09-15 18:51:14 +05:30
Shariq Ansari
6e62baeef9
Merge pull request #22108 from barredterra/open-file-from-picker
feat(File Uploader): open file details from search
2023-09-15 18:45:42 +05:30
Shariq Ansari
6ce30724cb
chore: linter fix 2023-09-15 18:33:18 +05:30
Shariq Ansari
655047c274 fix: stop parent click if external link icon is clicked 2023-09-15 18:23:23 +05:30
Shariq Ansari
a6468cab3a fix: using icon instead of svg 2023-09-15 18:20:02 +05:30
Shariq Ansari
27960cda57
Merge pull request #22422 from ssuda/workflow-builder-fix 2023-09-15 17:25:06 +05:30
Shariq Ansari
920a88e1ac feat: show preview on popover if file is image type 2023-09-15 17:17:22 +05:30
Shariq Ansari
cd5c43d657
Merge pull request #22282 from mterceno/fix-missing-keyboard-shortcut-on-document---Duplicate 2023-09-15 17:13:08 +05:30
Shariq Ansari
865e99929f
Merge pull request #22270 from barredterra/responsive-address-contact-list 2023-09-15 17:05:02 +05:30
Ankush Menat
4f92189a6c
Merge pull request #22399 from niraj2477/remove-stale-data
fix!: Sync deleted doctypes on migration
2023-09-15 16:38:48 +05:30
Ankush Menat
b409a05e8e fix: Ignore all non-import exceptions 2023-09-15 16:22:09 +05:30
Ankush Menat
c189b7e622 revert: syncing of report and pages 2023-09-15 16:22:06 +05:30
Ankush Menat
662b07170c test: orpahned doctype check after patch test 2023-09-15 16:18:25 +05:30
Ankush Menat
b9ee6827b4 refactor: stale object removal
- Do it after migration, post migration might use some old doctype.
- stale -> orpahn
- dont commit changes individually
- Remove table doctype too
2023-09-15 16:18:25 +05:30
Ankush Menat
b6d65fea06 ci: update patch workflow
- start with v13 DB, drop py3.7
- New flow v13DB -> V14 -> V15 (when released) -> PR commit
- Restart bench before final migrate
2023-09-15 16:18:25 +05:30
14987
2937ba38db fix: Update get_doc filter 2023-09-15 16:18:25 +05:30
14987
31a1d37f0a refactor: Fix ambigious var name 2023-09-15 16:18:25 +05:30
14987
b9449a4f13 fix: Delete stale doctypes, reports and pages 2023-09-15 16:18:25 +05:30
Sambasiva Suda
d312cb443c fix: saving workflow in workflow builder 2023-09-15 15:32:48 +05:30
Shariq Ansari
afd323ef23 fix: return report if not custom report 2023-09-15 15:18:23 +05:30
HENRY Florian
cf63690a3c
feat: use Link field for search in Role Permissions Manager (#22232)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-09-15 15:13:02 +05:30
Gursheen Kaur Anand
e03525efba
fix: remove items linked to non-existing doctypes from portal settings (#22417)
* fix: remove non-existing ref doctypes from portal settings

* fix: use separate list to iterate
2023-09-15 15:06:51 +05:30
0xsaif
87c1a9d7d7
refactor: Ensure admin receives a valid backup encryption key (#22411)
* refactor: Ensure admin receives a valid backup encryption key

- Added logic to retrieve or generate a backup encryption key if not present.

* refactor: simplify code

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-15 11:40:10 +05:30
Raffael Meyer
d43212792d
fix: update help links (#22413) 2023-09-15 11:37:27 +05:30
Ankush Menat
530c47ffe5
feat: after_response callback manager (#22398)
* feat: `after_response` callback manager

* perf: defer closing DB connection

* refactor: simplify after response hooks

* wip

* example usage

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>

* fix: Log request end if not already

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-09-14 10:56:08 +00:00
Suraj Shetty
2587d3e2e0
perf: Enqueue "removing of index" on web page save (#22409)
* perf: Enqueue "removing of index" on web page save

* fix: Enqueue after commit

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* fix: enqueue after commit

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-14 14:58:19 +05:30
Ankush Menat
909457de3d
fix: PDF and raw response (#22402) 2023-09-13 16:42:49 +00:00
Ankush Menat
9244140816
fix!: Bind development server only to localhost (#22397) 2023-09-13 17:26:19 +05:30
Ankush Menat
88896f8f41 fix: keep localhost for smtp checks 2023-09-13 17:06:28 +05:30
0xsaif
aa7ee1c6b9
refactor: force ipv4 localhost (#22394)
* reafctor: force ipv4 localhost

Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6

* revert: leave localhost usage in oauth tests

Change not required.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-13 16:23:23 +05:30
google-boy
9d8c6012a2
fix: Check if user has no associated email accounts. (#22355)
check that the return array does not exist, is not an array, or is empty 

http://stackoverflow.com/questions/24403732/ddg#24403771
2023-09-13 14:40:29 +05:30
Ankush Menat
970a740164
revert: #22308 (#22389)
* Revert "chore: move function to correct file"

This reverts commit ebfdfa283b.

* Revert "refactor!: merge get_site_url into get_url (#22308)"

This reverts commit 2001bc278f.
2023-09-13 14:34:52 +05:30
Alfredo Altamirano
39c06cffcd
fix: pass console to import file (#22385)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-13 14:28:52 +05:30
Deepesh Garg
b3742b45a8
Merge pull request #22104 from GursheenK/doc-comparator
feat: audit trail
2023-09-13 14:04:15 +05:30
Ankush Menat
b445c20e22
test: ignore whitespace changes while comparing HTML (#22386) 2023-09-13 08:18:56 +00:00
Ankush Menat
c55dcc439e
feat: max_file_size configurable from system settings (#22384)
also increase default max_file_size from 10MB to 25MB
2023-09-13 13:33:36 +05:30
Ankush Menat
0eb509aac3
refactor: Correct Content-Disposition headers (#22383) 2023-09-13 12:57:14 +05:30
Ankush Menat
64dd4b876b fix: UI test dont start without init 2023-09-13 12:33:49 +05:30
ViralKansodiya
b0bb9a55d5
fix: error while export a doctype report in excel (#22376)
* fix: error while export a doctype report in excel

* Update frappe/utils/response.py

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-13 12:13:31 +05:30
Ankush Menat
4b336b47a1 fix: broken link preview 2023-09-13 11:34:06 +05:30
Shariq Ansari
cfb6e36441
Merge pull request #22378 from shariquerik/workspace-has-role-fix 2023-09-13 11:29:44 +05:30