Sagar Vora
f4062b4d7a
fix: ensure consistent error in response
2025-02-19 12:10:59 +05:30
Ankush Menat
e16f3b1c84
fix: set default, don't override cache headers ( #31306 )
...
Oof.
2025-02-19 11:28:34 +05:30
Ejaaz Khan
91eee4fdf9
Merge pull request #31215 from aerele/report-custom-column
...
fix(report): add custom column based on link column
2025-02-18 23:23:01 +05:30
s-aga-r
85f7fb7922
refactor: Frappe Mail API ( #29200 )
2025-02-18 16:29:02 +05:30
Nihantra C. Patel
aed69f92f7
fix: hide create button for cancelled doc in dashboard links ( #31295 )
2025-02-18 14:55:39 +05:30
Akhil Narang
ef4ffbb304
Merge pull request #31290 from akhilnarang/fix-reportview-edit-if-has-table
...
fix(report_view): don't disallow editing just if a table exists
2025-02-18 11:24:48 +05:30
Akhil Narang
ccd8fb1f8b
Merge pull request #31269 from frappe/revert-29104-develop
...
Revert "fix: Improper routing for Report links when added to cards in workspaces"
2025-02-18 11:20:08 +05:30
Ankush Menat
611a03d1a2
Merge pull request #31283 from ankush/perf/rq_no_fork
...
perf: Support running RQ worker without forking
2025-02-17 19:16:21 +05:30
Ankush Menat
e2bd3abd62
fix: make nofork workers exit periodically
2025-02-17 18:55:25 +05:30
Ankush Menat
de7e6d0ba5
fix: force init background jobs
2025-02-17 18:47:59 +05:30
Ankush Menat
644bc5530e
fix: Support stop-job, kill-horse etc
2025-02-17 18:40:11 +05:30
Ankush Menat
9dd005b21e
refactor: separate worker type for nofork
2025-02-17 18:21:07 +05:30
Ankush Menat
0cebc61de1
fix: Exit worker on timeout exception
...
- Timeout in same process can leave bad state, so start a new worker.
- This isn't exactly costly, earlier we were forking all the time.
- Timeouts by definition can't happen too frequently.
2025-02-17 17:57:21 +05:30
Akhil Narang
24c2dfdf88
fix(report_view): don't disallow editing just if a table exists
...
If a table exists, go with the previous result. Else check and parse read_only conditions
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-17 17:49:52 +05:30
Ankush Menat
3b4e1bbb48
perf: Support running RQ worker without forking
...
Frappe does everything required to run jobs without forking.
- We cleanup locals
- Global caches are invalidated appropriately
- We destroy connections and open a new one for job/request
So we don't have any safety benefit much from forking for every job.
There can still be some code out in wild that relies on this behaviour
though!
Pros:
- Almost zero-overhead background jobs, just like web requests.
Cons:
- Timeout need to be implemented separately now
- Unknown side effects!
- Some features like "stop job" will need separate implementations.
2025-02-17 16:20:52 +05:30
venkat102
af39cc43ad
fix: update doctype value
2025-02-17 12:29:14 +05:30
Ankush Menat
d0c3a8ee56
fix: check scheduler process status in health report ( #31284 )
...
Currently it's just checking if the scheduler is enabled or not. This PR
also adds a check to see if the process is running or not.
2025-02-17 05:04:07 +00:00
Ankush Menat
5fe0742ab9
fix: Avoid recency filters on dashboard connection filters ( #31280 )
2025-02-17 04:27:53 +00:00
Akhil Narang
02bcf6f1e9
Merge pull request #31268 from akhilnarang/fix-custom-report-link-list
...
fix: set `report_ref_doctype` for custom reports
2025-02-14 17:23:38 +05:30
Akhil Narang
051e0a6d4e
Revert "fix: Improper routing for Report links when added to cards in workspaces"
2025-02-14 16:30:59 +05:30
Akhil Narang
b5ee3b29cf
fix: set report_ref_doctype for custom reports
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-14 16:25:48 +05:30
Ejaaz Khan
44e9752bb1
Merge pull request #31263 from iamejaaz/grid-row-open-issue
...
fix: link field option disappear
2025-02-14 11:36:53 +05:30
Ejaaz Khan
ef27287c25
fix: link field option disapper
2025-02-14 11:15:00 +05:30
Ejaaz Khan
a1e9ecf9a4
Merge pull request #31259 from frappe/revert-28899-clean-communication-html
...
Revert "fix(_get_communications): clean email content before returning"
2025-02-14 00:26:45 +05:30
Ejaaz Khan
701e744211
Revert "fix(_get_communications): clean email content before returning"
2025-02-13 23:32:55 +05:30
Soham Kulkarni
54007f4a46
Merge pull request #31222 from sokumon/safari-icon
...
fix: replace espresso icon
2025-02-13 19:39:36 +05:30
Akhil Narang
c64aa6822e
Merge pull request #31245 from akhilnarang/bump-cryptography
...
chore(deps): bump cryptography to 44.0.1
2025-02-13 09:10:15 +05:30
Ejaaz Khan
29265f8df4
Merge pull request #29862 from iamejaaz/refactor-auto-repeat-29378
...
refactor: add validation and refactor code of auto repeat
2025-02-12 23:04:31 +05:30
Ejaaz Khan
503d932212
Merge pull request #31195 from aerele/auto-email-multiselectlist
...
fix(auto email report): add get_data function to multiselectlist filters
2025-02-12 22:36:43 +05:30
Akhil Narang
68d52f6da7
chore(deps): bump pyopenssl to match cryptography
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-12 18:52:08 +05:30
Akhil Narang
681b63fb13
Merge pull request #31242 from akhilnarang/linked-doc-check-permission
...
fix(get_linked_docs): check if user can read doctype before fetching a list
2025-02-12 18:45:21 +05:30
Akhil Narang
9743f11ce5
chore(deps): bump cryptography to 44.0.1
...
This resolves GHSA-79v4-65xg-pq4g
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-12 18:37:41 +05:30
Akhil Narang
80d20ff745
fix(get_linked_docs): check if user can read doctype before fetching a list
...
Users might not have access to all the possible linked doctypes - they should still be able to access the others
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-12 18:34:43 +05:30
Brian Pond
00fb8e7a7a
fix: get_table_columns_description() for MariaDB database.py ( #28851 )
2025-02-11 17:57:52 +05:30
Corentin Forler
a4c4631c26
fix(rq): Replace ":" in job ID ( #31194 )
...
* fix(rq): Replace ":" in job ID
Required since python-rq >= 2.1
* fix: only check custom job IDs
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2025-02-11 10:53:27 +00:00
Ejaaz Khan
a9fb9ef817
Merge pull request #31221 from iamejaaz/30369-multi-select-report
...
fix: prefill values in the query report's multi select
2025-02-11 15:42:52 +05:30
Ankush Menat
7f0394bf86
fix: short-circuit large table checks ( #31223 )
...
This can become super slow on child tables, so first check if it's worth "checking" data.
2025-02-11 10:09:29 +00:00
Soham Kulkarni
561e3727aa
fix: add multicurrency support in number card and dashboard chart ( #31079 )
...
* fix: support display currency in number card
* fix: support multi currency for display in dashboard chart
* fix: add python files
2025-02-11 15:38:12 +05:30
Akhil Narang
5731f448c9
Revert "Merge pull request #30896 from dhiashalabi/fix/reorder-setlang-initialization" ( #31225 )
...
This reverts commit 60aa2f918a , reversing
changes made to d54f5e575a .
2025-02-11 15:19:36 +05:30
Corentin Forler
dd876a36c5
fix: Prevent HTML injection in Button attributes and documentation_url ( #31188 )
...
* fix: Prevent HTML injection in Button attributes
* fix: Prevent HTML injection in documentation_url
2025-02-11 15:16:30 +05:30
s-aga-r
f040fb446c
fix: allow multiple @rate_limit decorators to be considered ( #31209 )
2025-02-11 15:09:34 +05:30
sokumon
bd345d7872
fix: replace espresso icon
2025-02-11 14:56:34 +05:30
Ankush Menat
ef3b0ef008
perf: Only filter last 3 months of data by default on large tables ( #31216 )
...
Applying something basic like `order id like xyz` filter can result in
full table scan on years of data. This isn't necessary most of the time.
Interactive queries are usually done on recent data, so add this filter
to ensure only recent data is checked first.
Users can remove this filter if they want to.
2025-02-11 09:24:08 +00:00
Ejaaz Khan
f787bb3752
fix: prefill values in the query report's multi select
2025-02-11 14:49:24 +05:30
Maxim Sysoev
87b1e68081
feat: (UI) Show document title in Global Search result ( #29131 )
...
Showing title in n Global Search result, if title field set in doctype settings
2025-02-11 14:41:58 +05:30
venkat102
e2f1ecb780
fix: add custom column based on link column
2025-02-11 12:13:43 +05:30
Frappe PR Bot
a8589ef484
chore: update POT file ( #31197 )
2025-02-10 15:00:14 +01:00
Soham Kulkarni
d4fcdecee4
Merge pull request #31204 from sokumon/breadcrumb
...
fix: check if doc name is string
2025-02-10 14:52:03 +05:30
sokumon
e8cad36bb8
fix: check if doc name is string
2025-02-10 14:22:00 +05:30
Akhil Narang
8a758365eb
Revert "Merge pull request #28363 from frappe/expr-series" ( #31202 )
...
This reverts commit 91d553c9cf , reversing
changes made to d17136cd04 .
2025-02-10 06:46:45 +00:00