Sagar Sharma
d88d9f5186
fix: max_positive_value for Integer types ( #17712 )
...
* fix: max_positive_value for Integer types
* style: formatting
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-08-02 15:48:54 +05:30
Ankush Menat
e652811d55
fix: ignore virtual fields when doing db_update
2022-07-11 18:33:50 +05:30
Ankush Menat
261fbfcd11
Revert "fix(doc)!: Always cast datetime, date and time fields"
...
Revert "fix(doc)!: Always cast datetime, date and time fields (#15891 )"
This reverts commit d7789ab6ff
2022-07-05 13:43:32 +05:30
Himanshu
d7789ab6ff
fix(doc)!: Always cast datetime, date and time fields ( #15891 )
...
### BREAKING CHANGE
#### Datetime, Date and Time fields will always be cast to respective objects in `setattr`, this will ensure uniformity while accessing the values, no more `getdate`, `get_datetime`, `to_timedelta` wrapper.
- While importing data, the framework does check for `set_only_once`.
- In normal case scenarios, this will work flawlessly since most date fields might not be set_only_once.
- But in Subscription, the date field is set to `set_only_once` and in `after_insert`, `document.save` is called, and while doing so, `set_only_once` is checked [here](1944a547f9/frappe/model/document.py (L566)https://github.com/frappe/frappe/issues/15370 )
> no-docs
2022-07-05 07:07:16 +00:00
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features ( #17367 )
...
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Sagar Vora
c6d8f3bc7f
fix: dont clear _meta when caching doc ( #17115 )
...
fix: dont clear meta when caching doc
2022-06-22 12:13:35 +05:30
Gavin D'souza
5ec2690160
Merge branch 'develop' into refactor-file
2022-06-01 15:47:55 +05:30
Sagar Vora
a33c2e2abe
refactor(BaseDocument)!: improved get, set and extend methods ( #16540 )
...
* perf!: 80% faster doc.get for fields with `None` as value
* perf: quicker init child (#3 )
* refactor: avoid repitition and improve error message
* test: `doc.extend`
* fix: improve constant naming
* fix: minor improvements and tests
* refactor: improve naming
2022-05-04 18:37:06 +05:30
Suraj Shetty
ccc82e2c4c
Merge pull request #15538 from noahjacob/phone_field_control
...
feat: Phone Control Type
2022-04-28 10:27:52 +05:30
Sagar Vora
224dd319e8
perf(BaseDocument): remove duplicate code ( #16733 )
2022-04-26 15:52:03 +05:30
Ankush Menat
fb0cd4c3a9
Merge pull request #16649 from ankush/testing_overhaul
...
test: better test utils
2022-04-26 12:02:06 +05:30
Sagar Vora
fa7ea4bce8
perf(BaseDocument): ~50% faster as_dict ( #16549 )
...
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
2022-04-23 09:01:20 +05:30
Ankush Menat
f748ae85fc
fix: set docstatus to 0 if None present
2022-04-22 19:47:54 +05:30
Gavin D'souza
c691537e61
chore: Add typing for ease of development
2022-04-21 13:32:13 +05:30
Suraj Shetty
8f94cb655f
Merge branch 'develop' into phone_field_control
2022-04-19 16:28:18 +05:30
Gavin D'souza
4b51b72119
Merge branch 'develop' of github.com:frappe/frappe into refactor-file
2022-04-18 17:28:56 +05:30
Ankush Menat
b409a7eeba
fix: extend autoname validation to child items
2022-04-14 15:16:59 +05:30
Suraj Shetty
6b7fda495b
Merge branch 'develop' of https://github.com/frappe/frappe into phone_field_control
2022-04-14 14:19:35 +05:30
Suraj Shetty
48cd1c2ad4
refactor: Fix naming and simpify code
...
- Ability to clear code, by hiting backspace
2022-04-14 14:14:00 +05:30
Shridhar Patil
39f8267a15
feat: added support for data type json ( #16187 )
...
> Please provide enough information so that others can review your pull request:
Added json support for postgres and mariadb
> Explain the **details** for making this change. What existing problem does the pull request solve?
https://github.com/frappe/frappe/projects/4#card-50160428
> Screenshots/GIFs
---
**Previous attempts:**
https://github.com/frappe/frappe/pull/8128
https://github.com/frappe/frappe/pull/7096
Docs: https://frappeframework.com/docs/v13/user/en/basics/doctypes/fieldtypes#json
2022-04-14 04:21:41 +00:00
Gavin D'souza
97e911e069
Merge branch 'develop' of github.com:frappe/frappe into refactor-file
2022-04-13 10:49:26 +05:30
Noah Jacob
c2f2fc10e7
Merge branch develop into phone_field_control
2022-04-12 20:40:29 +05:30
Nabin Hait
b4476e0257
feat: Ignore permlevel for specific fields
2022-04-12 12:24:23 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black ( #16453 )
...
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Noah Jacob
2d3c1053a0
refactor(ui): updated validation messages with fieldname
2022-04-11 15:25:27 +05:30
Noah Jacob
bf92b363e2
Merge branch 'develop' into phone_field_control
2022-04-07 15:04:47 +05:30
Sagar Vora
73fc2f1d59
fix: require key in doc.get
2022-04-04 11:18:46 +05:30
Sagar Vora
e9b1cdcdca
refactor(BaseDocument)!: dont return __dict__ if key is falsy
2022-04-04 11:11:13 +05:30
Sagar Vora
aedd2fb2b6
Revert "perf: 80% faster doc.get for fields with None as value" ( #16490 )
2022-04-01 20:39:27 +05:30
gavin
4756efca91
Merge pull request #16477 from resilient-tech/perf-doc-get
...
perf: 80% faster `doc.get` for fields with `None` as value
2022-04-01 16:26:27 +05:30
Ankush Menat
046f5d31af
fix: don't update autoname field when using Document.save ( #16436 )
2022-04-01 14:00:27 +05:30
Sagar Vora
811c213082
perf: 80% faster doc.get for fields with None as value
2022-04-01 04:35:19 +05:30
Gavin D'souza
47cf46cd49
Merge branch 'develop' of github.com:frappe/frappe into refactor-file
2022-03-24 21:38:21 +05:30
Sagar Vora
4bb5ea609c
fix: get currency name from DB only if options are set and value is truthy ( #16382 )
...
* fix: call `frappe.db.exists` only if `options` are set and value is truthy
* fix: sider issue
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* fix: use `get_value` instead of `exists`
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* test: ensure currency formatting works without currency set in df options or param
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-03-23 19:28:01 +05:30
Noah Jacob
579d0643c4
Merge branch 'develop' into phone_field_control
2022-03-22 15:05:45 +05:30
mergify[bot]
f47331cd1d
Merge pull request #16200 from alyf-de/refactor-db-exists
...
refactor: `frappe.db.exists`
2022-03-21 05:47:27 +00:00
barredterra
c26cf25478
fix: avoid invalid call to frappe.db.exists
2022-03-17 02:46:00 +01:00
Gavin D'souza
c6bad81f24
fix: Use new direct import paths
...
The old paths worked too, but it's just better to use the new paths and
not go in circles ;)
2022-03-15 19:39:47 +05:30
phot0n
bebc8058b6
feat: integer primary keys
2022-03-11 23:46:00 +05:30
Suraj Shetty
7ee56ac5eb
Merge branch 'develop' into update-if-missing
2022-02-21 20:12:53 +05:30
Sagar Vora
24a750c048
chore: remove redundant code from update_if_missing
2022-02-16 10:53:03 +05:30
Suraj Shetty
d9ef033927
Merge branch 'develop' into perf-tree
2022-02-16 10:39:52 +05:30
mergify[bot]
a851af05ba
Merge pull request #15963 from resilient-tech/remove-unnecessary-code
...
perf: reduce loop in `doc.update`
2022-02-16 04:17:41 +00:00
mergify[bot]
4dae96d721
Merge pull request #15957 from resilient-tech/always-set-doctype-for-child
...
fix: always set `doctype` from `options` for child Document
2022-02-16 03:34:41 +00:00
mergify[bot]
1df33cbfcf
Merge pull request #15975 from resilient-tech/fix-limit-without-filter
...
fix: limit without filter
2022-02-15 13:40:56 +00:00
Sagar Vora
1a20f376f3
perf: reduce loop in doc.update
2022-02-15 15:29:04 +05:30
mergify[bot]
4b27569d13
Merge pull request #15962 from resilient-tech/ignore-doctype-in-setter
...
fix: Ignore `doctype` in setter
2022-02-15 09:31:20 +00:00
Sagar Vora
18ba5fcd49
perf: reduce one query in get_controller
2022-02-15 14:10:55 +05:30
Pruthvi Patel
7ce9f1eaa1
fix: limit without filter
2022-02-15 13:06:55 +05:30
Sagar Vora
8a264d05ca
fix: remove ignore_in_getter; cleaner implementation
2022-02-15 13:02:52 +05:30
