Commit graph

42272 commits

Author SHA1 Message Date
Ritwik Puri
fbc25d206e
Merge pull request #21304 from phot0n/fix-expiry-for-email-queue
feat: bulk retry for email queue & remove infinite* retry for certain smtp exceptions
2023-06-12 15:08:44 +05:30
Ankush Menat
8a30667a97
fix: Fetch non-cached version of Meta on Customize Form. (#21269)
* fix: Replace meta cache when uncached meta is requested

* fix: use meta from DB on customize form

* refactor: make cached kw only, use _dev_server
2023-06-12 14:59:42 +05:30
phot0n
f49818089a feat(minor): bulk retry for email queue
* chore: add retry_sending as a email queue class method
2023-06-12 14:38:43 +05:30
Ankush Menat
98260b3c88
fix(UX): show perm server messages on file uploader (#21331) 2023-06-12 13:53:08 +05:30
Ankush Menat
32f54b6734 chore: remove socketio from boilerplate workflow
[skip ci]
2023-06-12 12:14:05 +05:30
Ankush Menat
6f4a7ddf10 Revert "build(deps)!: Require NodeJS 18 as minimum version (#21303)"
This reverts commit 67cd951013.
2023-06-11 11:40:22 +05:30
Ankush Menat
4f797f0bcd fix: realtime log when commit/rollback happen in same req 2023-06-11 11:40:22 +05:30
Ankush Menat
687b660370 perf: Share queue connection for realtime 2023-06-11 11:40:22 +05:30
Ankush Menat
eb17c12dda fix: reuse redis connection if not rq auth 2023-06-11 11:40:22 +05:30
Ankush Menat
3414c0d063 refactor!: Merge redis_socketio and redis_queue
- realtime communication uses pub-sub and no storage. So using same
  redis server for both should be just fine.
- This is how FC works since quite a lot of time. We haven't seen any
  problem so far.
2023-06-11 11:40:22 +05:30
Ankush Menat
828490e01a chore: bump many more old packages 2023-06-10 20:47:27 +05:30
Ankush Menat
18e791a353 build(deps): PyPDF2 -> pypdf
closes https://github.com/frappe/frappe/issues/19861
2023-06-10 20:47:27 +05:30
Ankush Menat
699e744617 ci: restart bench in patch test
also show bench output
2023-06-10 20:47:27 +05:30
Ankush Menat
8485ac5d62 build(deps): bump many dependencies
test: change code to adapt to new werkzeug client

fix: avoid setting charset

utf8 is default and assumed now by werkzeug, setting this manually is
deprecated.

fix: use string instead of bytes for setting headers

DeprecationWarning: Passing bytes as a header value is deprecated and will not be supported in Werkzeug 3.0.
12:23:34 web.1         |   response.headers["X-Page-Name"] = path.encode("ascii", errors="xmlcharrefreplace")
2023-06-10 20:47:27 +05:30
Ankush Menat
84294900e5 build!: Remove setup.py 2023-06-10 20:47:27 +05:30
Ankush Menat
67cd951013
build(deps)!: Require NodeJS 18 as minimum version (#21303) 2023-06-10 19:22:57 +05:30
Suraj Shetty
aed9e912e4
Merge pull request #21174 from surajshetty3416/scroll-to-field-via-url 2023-06-10 19:05:19 +05:30
Suraj Shetty
321f4169dd Merge branch 'develop' of https://github.com/frappe/frappe into scroll-to-field-via-url 2023-06-10 17:33:47 +05:30
Suraj Shetty
895dab8535 fix: Pass URL hash separately 2023-06-10 17:33:42 +05:30
Raffael Meyer
ed3b764db9
build(deps): bump cryptography and pyOpenSSL (#21307)
cryptography to 41.0.1, pyOpenSSL to 23.2.0
2023-06-10 11:23:15 +05:30
phot0n
1f8598891e fix: remove infinite sending retries for certain exceptions for email queue
* chore: remove expired status & set_expiry job from email queue
2023-06-09 14:38:55 +05:30
Ankush Menat
774a75dbde
perf: use cached workflow doc for transitions (#21300)
* fix: expire `RECORDER_INTERCEPT_FLAG` in one hour

Leaving this running in prod can be dangerous.

* perf: Use cached doc in workflows
2023-06-09 12:43:40 +05:30
Sagar Vora
345da6e314
feat: support reordering standard fields in Form Builder (#21297) 2023-06-09 12:19:30 +05:30
Shariq Ansari
5fbdce888d
Merge pull request #21275 from 101v/new_dashbaorad_chart_for_query_report 2023-06-09 12:17:05 +05:30
Sagar Vora
15ce89fb72
fix: minor improvements to CustomizeForm.reset_layout (#21296) 2023-06-09 10:40:05 +05:30
Ankush Menat
6188d1476e fix: correct method for layout reset 2023-06-09 10:02:43 +05:30
Shariq Ansari
d1b86d9133
Merge branch 'develop' into new_dashbaorad_chart_for_query_report 2023-06-09 09:54:39 +05:30
Ankush Menat
155465c58d
fix: currency precision formatter (#21293) 2023-06-09 00:35:20 +05:30
Sagar Vora
e1764d5a4b
feat: log pid and user in request logs (#21267) 2023-06-08 19:43:29 +05:30
Ankush Menat
e98519211e
feat: let people reset layout back to original (#21290) 2023-06-08 18:07:12 +05:30
Ankush Menat
924ecc71f6
chore: vendor cgitb (#21288)
To Avoid:

```
/home/ankush/benches/develop/apps/frappe/frappe/utils/error.py:4: DeprecationWarning: 'cgitb' is deprecated and slated for removal in Python 3.13
  import cgitb
```
2023-06-08 17:52:21 +05:30
Devin Slauenwhite
19d211f1d2
feat: rearranging standard fields in customize form (#19822)
* feat: rearranging standing fields

* fix: fixed creation of property setter

* refactor: renamed setup_sortable

* fix: loading field_order property

* refactor: removed redundant db call

* fix: field_order not found

* test: Added tests for field order in customize form

* refactor: better naming

* refactor: simplified logic

* feat: Updating field order on custom field creation

* feat: Added support for custom fiels

* refactor: moving to meta

* refactor: changed property type to json

* fix: new standard field insert order.

* fix: don't modify insert_after of system generated custom fields.

# This is because system generated fields are to be treated as standard fields. If the user restores the form to default, this value will be used to reset the original position.

# The new position of form fields are stored in the field_order Property Setter.

* fix: treat system generated fields as standard fields when sorting.

* revert: check for is_system_generated

* Revert "fix: new standard field insert order."

This reverts commit 6cdbe42f28d5944165dd100a9bb9172463951fda.

* fix: prioritize field_order over insert_after.

# Use insert_after as fallback in event the field doesn't exist in field_order

* fix(test): delete existing custom field

* fix: order of standard fields without field_order property.

* Revert "Revert "fix: new standard field insert order.""

This reverts commit c830f1ba2fe1e602b09c11a897869d9992097c1e.

* test: field order of newly migrated standard fields.

* fix(test): clear test_standard_field from previous test run.

* fix: sort with insert_after for system generated fields.

* fix(test): reset standard field creation before re-run and after successful test.

* fix: insert_after position should be + 1

* chore: remove debug statement

* test: system generated customized fields

* chore: remove print

* chore: lint all

* fix: show quick link to Table MultiSelect DocTypes

* refactor: change backend implementation of `CustomizeForm` and `Meta`

* test: simplify tests

* fix: rename `idx` to `index` for clarity

* perf: define `existing_fields` conditionally

---------

Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
Co-authored-by: Aradhya Tripathi <67282231+Aradhya-Tripathi@users.noreply.github.com>
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-06-08 17:14:44 +05:30
Shariq Ansari
666813158c
chore: linter fix 2023-06-08 17:12:03 +05:30
Shariq Ansari
fa502278f4
chore 2023-06-08 16:53:17 +05:30
Shariq Ansari
108e128b46
chore: linter fix 2023-06-08 16:52:52 +05:30
Shariq Ansari
428eaf6a16
chore: linter fix 2023-06-08 16:52:24 +05:30
Shariq Ansari
eb2c97c9fa
Merge branch 'develop' into new_dashbaorad_chart_for_query_report 2023-06-08 16:37:31 +05:30
Ritwik Puri
76c3cd3f9c
Merge pull request #21246 from phot0n/minor-fixes-email
fix: minor fixes email
2023-06-08 16:30:36 +05:30
phot0n
129fdc803a chore: fix linter 2023-06-08 16:20:10 +05:30
phot0n
4ceafe14e3 chore: remove unused is_background_task and add_to_sent_list -> update_recipient_status_to_sent
* set status to be hidden in queue doc
* don't maintain a list of sent to recipeint, a boolean is enough to set the status to partially sent
2023-06-08 16:19:37 +05:30
phot0n
aac74726ff chore: add recipient to sent list regardless of email sending method 2023-06-08 16:19:37 +05:30
phot0n
df7afa93b8 chore: log traceback directly to the queue doc 2023-06-08 16:19:37 +05:30
phot0n
742a6082ac fix: remove unnecessary statuses from email queue and only append emails to sent if imap is enabled 2023-06-08 16:19:37 +05:30
phot0n
2b22556309 chore: remove deprecated send method from smtp 2023-06-08 16:19:37 +05:30
Vimal Patel
48b9128904 fix: remove redundant prepare_filter method 2023-06-08 11:26:22 +01:00
Vimal Patel
0d729e5e47 fix: New Dashboard Chart throws TypeError: format requires a mapping
closes #21250

backport version-14-hotfix
2023-06-08 11:18:44 +01:00
Vimal Patel
70944cabb3 fix: New Dashboard Chart throws TypeError: format requires a mapping
closes #21250
2023-06-08 11:11:33 +01:00
Vishal Kumar
a21412e12a
feat: allow no_smtp_authentication to be set from site config (#21274) 2023-06-08 13:15:43 +05:30
Ritwik Puri
3446ca9155
fix: consider default value for content in update_workspace2 patch (#21258) 2023-06-08 13:14:37 +05:30
Ankush Menat
39374f3906 chore: ignore redis.cache commit
[skip ci]
2023-06-08 11:48:06 +05:30