marination
f58b28865e
fix: Avoid renaming language or changing title manually
2024-06-06 18:27:52 +02:00
Corentin Flr
48e59248e6
chore: Reword "Recursive Fetch From" message ( #26706 )
2024-06-06 14:35:35 +00:00
David Arnold
a2bff44414
fix(UX): Show reference name in error log list view #26687
2024-06-06 16:19:36 +05:30
Ankush Menat
ab37665f5b
fix: recursive fetch from causes infinite loop ( #26695 )
2024-06-06 07:02:00 +00:00
Akhil Narang
b8ebd601f8
fix(package_release): set path to tarball
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-06-05 17:07:11 +05:30
Corentin Flr
5a8e00af38
fix(Error Log): Truncate title and convert text to string ( #26675 )
2024-06-04 18:36:32 +05:30
Ankush Menat
99f2360a12
fix: Always ensure amended_from is same doctype
2024-06-04 11:52:14 +05:30
Ankush Menat
15902a746e
fix: auto repeat on new doctypes
...
closes https://github.com/frappe/frappe/issues/24091
2024-06-04 11:50:54 +05:30
Dhia' Shalabi
e97a56b8c8
fix: delete old user notification settings when merging users ( #26604 )
2024-05-30 19:11:30 +05:30
RitvikSardana
394227a90f
fix: text editor fields exports HTML tags ( #26571 )
...
* fix: text editor fields exports HTML tags
* fix: use html2text to preserve text structure
2024-05-27 18:26:00 +05:30
Ankush Menat
0dfff8375c
fix: Broken scheduled job type sync
...
Jobs weren't gettng deleted if they were moved around in sections.
I feel we should just drop support for same job in multiple blocks. It's
trivial to get around this limitation by adding a separate function.
2024-05-27 17:26:11 +05:30
Ankush Menat
43c8ae0049
fix: Duplicate scheduled jobs run forever ( #26565 )
...
If same method is added in multiple places our code just finds 1 random
scheduled job type and updates it as "ran", in some unlucky situations
this behaviour won't be random and always run one and update another so
the job never gets marked as "ran" and keeps running on every tick.
2024-05-26 06:49:20 +00:00
Raffael Meyer
4a7de16019
fix: don't automatically add system manager ( #26540 )
...
* fix: don't automatically add system manager
* feat: remove User.a_system_manager_should_exist
* feat: remove User.add_system_manager_role
* feat: remove User.is_system_manager_disabled
* feat: remove User.get_other_system_managers
* feat: add "System Manager" role to User created by setup wizard
2024-05-24 08:29:30 +00:00
Rutwik Hiwalkar
7e18910dbd
fix: append download button to body and cleanup after click ( #26544 )
2024-05-24 08:24:08 +00:00
Rutwik Hiwalkar
75412ba872
Merge pull request #26514 from rutwikhdev/fix-download-redirect
...
fix: download file instead of open in new window
2024-05-22 19:04:21 +05:30
Ankush Menat
9e9e72bce5
fix: reload before saving on reconnect ( #26534 )
...
The doc we have might be "in future".
2024-05-22 16:31:07 +05:30
Rutwik Hiwalkar
c112380a6e
fix: download file instead of open in new window
...
- simulate a link click download the file when Download button is
clicked in File Doc
2024-05-21 18:33:04 +05:30
Ankush Menat
025727674f
fix: scheduled type syncing ( #26490 )
...
- Scheduled Job sync when type was changed from scheduled to some other
type didn't work.
- It updates on every save with message, bad DX IMO (can't save script
and edit without dismissing)
- This was because of complex walrus which was triggering rest of code
even when nothing changed. Maybe walrus opponents were onto something.
- `Truthy` couples two different operations and hence makes code
complicated. In most cases where these checks are required it's not
performance critical, we can do 1 more function call to avoid this
coupling of change + actual value.
2024-05-20 13:43:20 +00:00
Akhil Narang
3a4dd9a671
Merge pull request #26183 from vmatt/data_import_delimiter
...
feat(Data Import): custom csv delimiters, UTF-8 BOM handling
2024-05-15 16:45:31 +05:30
Akhil Narang
9986ea8171
chore: update labels and a comment
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-15 16:29:55 +05:30
Ankush Menat
6fb6c4035c
Merge pull request #26433 from ankush/query_optimzier
...
feat(recorder): Suggest index for optimizing query
2024-05-14 19:08:41 +05:30
Ankush Menat
b169f8780a
feat: Add identified index from UI
2024-05-14 18:54:38 +05:30
Ankush Menat
4e251e9b0b
feat(recorder): Suggest query index
2024-05-14 16:05:58 +05:30
Ankush Menat
49f8f4fe45
fix(UX): colour duration to highlight bad rows
2024-05-14 12:22:03 +05:30
Ankush Menat
bbf18d39cc
Merge pull request #26369 from gavindsouza/refactor-scheduled-server_script
...
refactor!: Server Script (Scheduler Event) & misc APIs
2024-05-13 20:25:29 +05:30
Ankush Menat
aba8d4e5b5
fix(DX): fix up column widths in recorder grid
...
Query is most important yet it was only taking 2 cols, unreadable.
2024-05-13 17:38:18 +05:30
Gavin D'souza
9c20649022
Revert "fix: ServerScript.safe_exec as a doc method"
...
This reverts commit cf2a3e926e
2024-05-13 11:31:19 +02:00
Mate Laszlo Valko
0f4e916c8d
fix: comments
2024-05-10 00:16:22 +02:00
Ankush Menat
53517630ae
fix: Increase folder link field size ( #26381 )
...
* fix: increase folder length to 255
File `name` is 255 because it's bootstrapped using mariadb.sql, so users
can create 255 char long folders but can't store anything in it.
* fix(UX): slightly better character len message
Highlight field by making it bold.
2024-05-09 12:10:21 +05:30
Akhil Narang
1cebdb257d
chore(doctype/file): update comments
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-08 16:19:10 +05:30
Mate Laszlo Valko
e69093c82b
feat: CSV import introduce FILE_ENCODING_OPTIONS constant in file.py, cleanup
2024-05-08 07:40:17 +02:00
Mate Valko
d3cfa26be7
fix: fallback to ',' when delimiter_options not defined
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-05-07 21:20:43 +02:00
Gavin D'souza
179305495a
perf: Use cached Server Script to execute doc method events
2024-05-07 17:33:41 +02:00
Gavin D'souza
cf2a3e926e
fix: ServerScript.safe_exec as a doc method
2024-05-07 17:30:46 +02:00
Gavin D'souza
ffbf7fb9d1
fix!: Document.has_value_changed returns Truthy or False
...
- Return changed value to avoid re-accessing previous object & it's
attribute
- Wrap returned value as Truthy to avoid breaking change in API
2024-05-07 17:29:48 +02:00
Gavin D'souza
10f0f0d2e9
fix!: Dont delete existing ScheduledJobType on change
...
Prior to this, any change in the cron would lead to previous SJT
documents & corresponding SJL documents deleted which may be
undesirable.
2024-05-07 16:58:40 +02:00
Ankush Menat
56233f3182
chore: dead hooks
2024-05-04 15:08:32 +05:30
Ankush Menat
1948422b63
Merge pull request #26292 from ankush/scheduler_reliability
...
fix: changes for scheduler reliability
2024-05-02 13:52:25 +05:30
Ankush Menat
86b1e9ec31
fix: update last_execution for no-log unconditionally
...
Cron jobs can now also disable logging.
2024-05-02 13:36:17 +05:30
Ankush Menat
b0aaeb5096
fix: Dont let one invalid cron fail scheduler
...
Scenario:
- One bad cron job exists
- When it fails nothing after that job is enqueued.
After this fix, that failure is skipped and rest of the jobs are enqueued.
2024-05-02 13:36:14 +05:30
Raffael Meyer
02ea846cd4
fix: automatic logo width ( #26273 )
2024-05-01 19:16:26 +05:30
Raffael Meyer
8eb8c64fbd
fix(Navbar Settings): reload page after save ( #26274 )
...
* fix(Navbar Settings): reload page after save
* test: file uploader flake
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-05-01 13:20:04 +00:00
Mate Valko
c662379a56
Merge branch 'develop' into data_import_delimiter
2024-05-01 01:01:13 +02:00
Raffael Meyer
0696123661
fix(Data Import): don't attempt to show logs for unsaved import ( #26263 )
2024-04-30 16:46:46 +00:00
Ankush Menat
1a3c23290f
refactor: avoid deprecated method
2024-04-30 20:22:42 +05:30
Raffael Meyer
774f5cc1c6
fix(Data Import): don't rely on permission for Data Import Log ( #26228 )
2024-04-30 18:00:24 +05:30
Mate Laszlo Valko
45eabd32cd
feat(Data Import): custom delimiters
2024-04-30 13:40:38 +02:00
Ankush Menat
f244f3c76f
fix: perm query for dashboard ( #26239 )
2024-04-30 09:43:51 +00:00
Ankush Menat
ff31290d33
Merge pull request #25971 from rutwikhdev/discard-transactions
...
feat: Discard transactions
2024-04-29 16:08:37 +05:30
Ankush Menat
ae4eb87458
feat: Limit OAuth Client by roles
2024-04-29 14:18:49 +05:30
