Commit graph

5850 commits

Author SHA1 Message Date
Shariq Ansari
61cac70b3e chore: moved workspaces section inside settings tab 2024-03-20 17:16:33 +05:30
Corentin Flr
e3d00e9117
fix(workspace): Don't allow Welcome as default workspace
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2024-03-19 16:24:13 +01:00
Gursheen Anand
351151b0ff fix: reset announcements after saving settings 2024-03-18 14:54:36 +05:30
Gursheen Anand
88d8b6ce6c feat: announcement widget in navbar settings 2024-03-18 14:45:08 +05:30
Ankush Menat
2f87a09ad9
test: fix timeout decorator (#25489) 2024-03-16 15:59:04 +05:30
Ankush Menat
d4bb72b74f
Merge pull request #25419 from frappe/cust_form_text
fix: allow transitioning to long text
2024-03-15 18:14:10 +05:30
Ankush Menat
48c24c7c5b test: fixup timeouts
The tests were failing because they weren't able to complete in 20
seconds. Ugh!
2024-03-15 17:58:57 +05:30
Ankush Menat
aa51492697 Merge branch 'develop' into txt-attachment-privacy 2024-03-15 14:53:45 +05:30
Ankush Menat
e76c29fcec
feat: Store printed PDF attachments on communication (#25439) 2024-03-14 11:45:03 +00:00
Ankush Menat
997d4a8285
perf: skip useless perm check (#25440) 2024-03-14 11:42:57 +00:00
Ankush Menat
bd661688e9
fix: dont allow querying files to website users (#25094)
* test: create desk user in file tests

* fix: dont allow querying files to website users

* test: make commiting test user optional
2024-03-14 16:43:21 +05:30
Ankush Menat
b331163ce9
Merge pull request #25409 from ankush/homepage_validate
fix: validate homepage paths
2024-03-13 23:55:23 +05:30
Ankush Menat
d758af5960 fix: clear routing cache on homepage change 2024-03-13 23:42:59 +05:30
Ankush Menat
d9d29430a9 fix: validate homepage paths 2024-03-13 21:00:51 +05:30
Ankush Menat
2c359f9bc1 fix: better filename for prepared report
avoid colons, windows doesn't like it
2024-03-13 18:17:37 +05:30
Ankush Menat
135fd33102 perf: compact prepared report files
No one reads these, no need to indent them.
2024-03-12 20:43:25 +05:30
Ankush Menat
fc7366deef
revert: fetch validations (#25343) 2024-03-11 14:59:18 +00:00
Ankush Menat
f7c0dd66fd refactor: migrate virtual doctypes to new API 2024-03-11 18:25:05 +05:30
Ankush Menat
1f35886995 test: flake from expecting a succesful job 2024-03-11 18:15:34 +05:30
Ankush Menat
4ab2ccd01f fix!: get_count accepts splatted arguments 2024-03-11 18:15:27 +05:30
Ankush Menat
a28921750d fix(DX): Avoid use of args in virtual doctype 2024-03-11 15:20:35 +05:30
Ankush Menat
448991d74a fix: avoid linking to ephemeral virtual docs 2024-03-10 12:49:19 +05:30
Corentin Flr
daa315f04a
fix(ModuleDef): Add list view filter options to app_name Select 2024-03-06 11:34:00 +01:00
Corentin Flr
3ec47b0975
feat(workspace): Allow user to choose a default workspace 2024-03-06 11:15:53 +01:00
Ankush Menat
457654cf40
fix: loosen validation on fetch from columns (#25247)
Any existing DB column can work so no need to check for meta explicitly.
2024-03-06 07:07:32 +00:00
Ankush Menat
081be53e17 fix(UX): Nudge to disable user instead of deleting 2024-03-06 12:11:35 +05:30
Ankush Menat
072c2a1ca3 fix: Delete EPS logs before deleting user 2024-03-06 12:06:08 +05:30
Ankush Menat
8ab2911654
ci: don't skip validations in CI (#25226) 2024-03-04 12:43:53 +00:00
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211)
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
f7bff58935
fix: use name for RQ worker instead of PID (#25175)
Also avoid complex naming schemes.
2024-02-29 14:38:48 +00:00
Ankush Menat
b044ffedf1 fix: Only validate fetch from when user modifies it 2024-02-28 20:42:49 +05:30
Ankush Menat
a4ddb7491d fix: specify print_language in communication attachments 2024-02-28 14:19:28 +05:30
Ankush Menat
91d10ffb31
Merge pull request #25128 from ankush/lang_print_format
fix: Use current language in attachment prints
2024-02-28 14:03:06 +05:30
Ankush Menat
870c92f7ea fix: Use current language in attachment prints 2024-02-28 13:50:48 +05:30
Ankush Menat
fe9fbf82d0
fix: validate fetch from (#25116) 2024-02-27 23:38:49 +05:30
Ankush Menat
c60edc9a77
refactor: file perm check (#25106) 2024-02-27 16:45:29 +00:00
Niraj Gautam
911846368f
feat: Add doc rename hook in server script (#25085)
* feat: Add doc rename hook in server script

* feat: Add test case for doc event in server script
2024-02-27 22:07:22 +05:30
Ankush Menat
01d29283f1
fix: restrict method for security critical endpoints (#25105) 2024-02-27 16:10:33 +00:00
Ankush Menat
c2638d90e5 Merge branch 'develop' into txt-attachment-privacy 2024-02-27 14:26:34 +05:30
Ankush Menat
24499d93f8 fix: notify user that they were impersonated 2024-02-24 18:31:10 +05:30
Ankush Menat
be47ee0e31 fix: track all impersonated changes 2024-02-24 18:25:09 +05:30
Ankush Menat
0fd4d6b67f fix: log activity for impersonations 2024-02-24 18:25:09 +05:30
Ankush Menat
c58ac809ac fix: Flag impersonated sessions 2024-02-24 18:25:09 +05:30
Ankush Menat
ecc9ff378e feat: impersonate any user as Administrator 2024-02-24 18:25:07 +05:30
Md Hussain Nagaria
690cb7d372
refactor: scheduled job type enhancements (#25007)
* refactor: remove autoname

* chore(Scheduled Job Type): enable show title in link

* chore: validate duplicate job

* test: throws on duplicate scheduled job

* feat: attach frequency and cron_format to `frappe.job`

* refactor: add unique constraint on db level

* fix: attach to frappe.job only if defined

* test: scheduled job name will get updated on frequency update

* test: wrap duplicate inserts in db savepoint/rollback

* fix: rollback without savepoint

* test: use loose Exception for raise assertion
2024-02-23 10:12:51 +00:00
Nikhil Kothari
bc68afa5b6
fix: spelling of "recording" in button (#25025) 2024-02-23 10:40:31 +05:30
Ankush Menat
73982c8e61 Merge branch 'develop' into txt-attachment-privacy 2024-02-22 17:20:30 +05:30
Ankush Menat
9d0a24f3de
fix: handle email without content adding links (#24994) 2024-02-21 19:18:21 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Ankush Menat
718b5b8bee
fix: Private images in PDFs from background jobs (#24980)
* refactor: Private images rendering in PDFs

Private images currently render fine if PDF is generated during a
request as we pass the cookiejar to WKHTML.

Background jobs however fail completeley because they can't retrieve
private images without cookiejar.

This PR converts all image types to base64 encoded sources in HTML
itself, so wkhtmltopdf doesn't have to a fire a request.

* test: private images in pdf
2024-02-21 10:38:02 +00:00