Commit graph

5850 commits

Author SHA1 Message Date
Ankush Menat
b794f868cc
fix: never apply role profiles to standard user (#24968) 2024-02-20 14:07:50 +00:00
Ankush Menat
e306e01660
Merge pull request #24947 from ankush/chore/remove_patch
fix: remove patch for hashing existing tokens
2024-02-19 18:44:39 +05:30
Ankush Menat
9a0fc2e9d9 fix: remove patch for hashing existing tokens 2024-02-19 18:38:21 +05:30
Ankush Menat
0a886b7ca8 perf: defer imports during CLI 2024-02-19 18:10:07 +05:30
Ankush Menat
e88c078c9d fix: validate cron format 2024-02-19 13:27:34 +05:30
Ankush Menat
68d1a9ec07 fix: delete cron jobs when switching server script type 2024-02-19 13:11:45 +05:30
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label (#24903) 2024-02-18 19:42:15 +05:30
marination
1f3e32a98d fix: Use regex in failing test 2024-02-13 13:30:37 +05:30
Ankush Menat
78264a7f16 fix(UX): usability of reset password page
- password managers use paste, added that event to trigger our code
- if no password policy then skip. Way too much needless business logic in HTML here.
2024-02-11 16:30:32 +05:30
Ankush Menat
38565a80e3 test: redo reset password tests 2024-02-11 14:30:50 +05:30
Ankush Menat
4c925e0325 refactor: Reset password flow
- Hash one time reset tokens instead of storing them as is
- Up the perm level
- Use better source of randomness for generating token
- minor code cleanup here and there
2024-02-11 14:25:26 +05:30
Ankush Menat
74071c1231 chore: remove default UI tours
Experiment 🤷
2024-02-11 14:25:26 +05:30
Corentin Flr
4f5de3b0de
fix(boilerplate): Fix WebsiteGenerator HTML templates (#24806) 2024-02-10 13:57:17 +05:30
Ankush Menat
19044c4be4
Merge pull request #24745 from niraj2477/multiple-role-profile
feat: Allow multiple role profile for user
2024-02-10 13:11:44 +05:30
Ankush Menat
7e8b671059 test: role ordering doesn't matter 2024-02-10 12:58:23 +05:30
Ankush Menat
fd2e6e4045 fix: disable role editor if role profiles are present 2024-02-10 12:52:38 +05:30
Ankush Menat
60aae9bbb2 fix: role profile > user dashboard links 2024-02-10 12:52:38 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Ankush Menat
638aeaddd8 refactor: remove code duplication for role profile logic 2024-02-10 12:52:38 +05:30
Ankush Menat
bfa1aebcc6 fix: deduplicate role profiles 2024-02-10 12:52:35 +05:30
Ankush Menat
f609025472 fix: roles getting re-inserted on every save 2024-02-10 12:24:19 +05:30
Ankush Menat
72b40135ce refactor: avoid implementing duplicate logic for role profile
Unless we are getting any performance benefit, I don't see the need to
have two different implementations for it.

also, queue job in long queue to reduce chance of failure
2024-02-10 12:24:19 +05:30
Ankush Menat
fbb4dd7e96 perf: use cached doc for fetching role profiles 2024-02-10 12:24:19 +05:30
Ankush Menat
ff35e4b854 refactor: backward compatiblity code for role_profile_name 2024-02-10 12:24:19 +05:30
marination
65c8a37636 test: Comment + Comm.n file extraction & Attachments default to public for Communication
- Note: DocType Communication's records are used for emails that have the file link embedded in its content
- fix: The files extracted from a Communication must be public so that they are visible in an email (link in email)
- Test: Check if file is created appropriately from a Comment and a Communication
2024-02-09 20:28:21 +01:00
Ankush Menat
4e1ed2908c
perf: use unique file url (#24830) 2024-02-09 14:52:30 +00:00
Ankush Menat
ed6613ce8e
test: use meta for fetching settings 2024-02-09 19:58:41 +05:30
Ankush Menat
7fbae4cfc8 Merge branch 'develop' into multiple-role-profile 2024-02-09 19:55:12 +05:30
marination
7445de9b1c fix: Use doctype setting to set auto-extracted file as private
- Use `make_attachments_public` to determine the file privacy while auto creating files from the text editor field
- Currently, all files in the text editor field are automatically public
2024-02-09 14:55:24 +01:00
Suraj Shetty
7991c896a8 fix: Unset contact_name to avoid linking of contact in case of failure 2024-02-09 16:21:29 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Abraham Kalungi
25a3baa632
fix: Remove Open Filter On Communication Doctype (#24800) 2024-02-07 13:13:04 +05:30
Ankush Menat
ca3ef817b0
fix: Avoid sending password back (#24794) 2024-02-06 20:05:42 +05:30
14987
56efb7d2f7
fix: Resolve lint issue 2024-02-06 16:27:34 +05:30
14987
a01868a0c9
fix: Modify function to update role of user on role profile change 2024-02-06 16:23:21 +05:30
14987
3a3dd14c2c
fix: Move old field to table multiselect 2024-02-06 16:20:59 +05:30
Robert Duncan
d6b126ac6f
fix: console import progress off-by-one (#24777)
* fix: importer console progress off-by-one

* fix: improve progress message

* chore: typo

---------

Co-authored-by: Robert Duncan <robir@puter.local>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-06 09:48:06 +00:00
14987
946de990d7
Merge branch 'develop' into multiple-role-profile 2024-02-06 14:56:35 +05:30
14987
47b54a884a
feat: Move old role profile to table multiselect 2024-02-06 13:03:32 +05:30
14987
ff56d9644c
Merge branch 'develop' into multiple-role-profile 2024-02-06 11:34:57 +05:30
Akhil Narang
eadce6ccb8
Merge pull request #24704 from blaggacao/feat/add-better-payment-lifecycle-events
feat: add more payment lifecycle events to server scripts
2024-02-06 11:00:48 +05:30
David Arnold
e511e854a3
feat: add more payment lifecycle events to server scripts 2024-02-06 02:10:08 +01:00
14987
9848742430
fix: Restore role profile name and hide it 2024-02-05 19:45:37 +05:30
Ankush Menat
1b8e9c3502
fix(UX): improve server script message (#24770) 2024-02-05 14:14:48 +00:00
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
14987
5a0ef6a651
feat(test): Add test case for multiple role profile assignments 2024-02-05 16:31:14 +05:30
14987
4ce976705a
fix(test): pass list for role profile in existing single role profile test 2024-02-05 16:31:14 +05:30
14987
f28ed485e2
fix: Update method for updating role in role profiles for user 2024-02-05 16:31:13 +05:30
14987
676d550449
fix: Update fields names for whitlist method 2024-02-05 16:31:13 +05:30
14987
16e696e998
fix(Schema): Update the field name in User schema 2024-02-05 16:31:13 +05:30