Commit graph

5850 commits

Author SHA1 Message Date
Ankush Menat
8f23dfcb4c
fix: Allow int fields to be unique (#24750)
PS: This will automatically make it mandatory because you can't have multiple default values of `0`.

close https://github.com/frappe/frappe/issues/19287
2024-02-05 16:29:56 +05:30
Niraj Gautam
1909fcdc22
Merge branch 'frappe:develop' into multiple-role-profile 2024-02-05 12:22:49 +05:30
Ankush Menat
9107627dac fix: recorder timezone bug
use system timezone to avoid showing incorrect timestamp
2024-02-05 11:37:24 +05:30
Ankush Menat
009b06d974 feat: Jobs/Request filtering 2024-02-05 11:33:31 +05:30
Ankush Menat
e494cb4f6e feat: configurable recording
Configurable behaviours:
- Record SQL queries
- Explain queries
- Record stack frames
- Run profiler
- Filter some requests
2024-02-05 11:33:31 +05:30
Ankush Menat
3c183344aa feat: profile requests using recorder
WIP:
- [x] Basic working feature
- [ ] Make this optional, this has insanely high overhead.
- [ ] Specify requests/function filter to profile/record. This will
  allow better recording in production sites.
- [ ] Make SQL profiling optional too
2024-02-05 11:33:31 +05:30
Ankush Menat
25692a3c81
fix: Set default for search result limit if empty (#24713) 2024-02-03 07:18:47 +00:00
Ankush Menat
7487df22c9 refactor: use frappe.get_system_settings
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Ankush Menat
c479a038a8
fix: Avoid enqueueing during install (#24679)
This isn't strictly required but if bench isn't running this can break
installation.
2024-02-01 14:12:54 +00:00
Raffael Meyer
4d63a12ab6
fix(Data Import): scheduler not needed in dev mode (#24667) 2024-02-01 17:11:41 +05:30
Ankush Menat
4553de8ba0
fix: never show virtual fields in list view (#24666)
* fix: never render virtual fields in list view

* fix: Hide "in list view" for virtual columns
2024-02-01 16:22:07 +05:30
Raffael Meyer
855202d20a
Merge pull request #24614 from barredterra/data-import-transatability 2024-02-01 11:37:41 +01:00
14987
cd24f32239
fix: Resolve lint issue 2024-02-01 16:01:36 +05:30
barredterra
281c1de639 fix(Data Export): translate multiselect 2024-02-01 10:51:57 +01:00
14987
ff6d64baa7
fix: Remove debug statement 2024-02-01 14:33:15 +05:30
14987
4549975dd2
fix: Update the user method to store multiple role according to role profile 2024-02-01 12:38:02 +05:30
14987
c06d205ea2
feat: Add child doctype for storing role profile of users 2024-02-01 12:36:34 +05:30
Ankush Menat
3634d11b6a
fix: Retry contact update if it fails due to conflict (#24654) 2024-02-01 05:14:00 +00:00
Ankush Menat
a25e68a763
fix: make rate_limiter respect multitenancy (#24634)
* fix: make rate_limiter respect multitenancy

* fix: lower rate limit window for password reset

* refactor: Use redis_wrapper
2024-01-31 09:16:27 +00:00
Ankush Menat
dedadbb0d9 perf: optional faster perm check for files 2024-01-31 10:49:18 +05:30
Akhil Narang
db1e692d4f
chore: reword checkbox
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-30 17:08:14 +05:30
Akhil Narang
ba64285c66
Revert "fix(data_import): respect the value of show_failed_logs checkbox"
This reverts commit 34f03a2de2.
2024-01-30 17:07:47 +05:30
barredterra
b59ba82ae6 fix(Data Import): translatability 2024-01-30 11:48:19 +01:00
Shariq Ansari
dc7637991e
Merge pull request #24582 from shariquerik/if_owner_and_report_perm_fix
fix: do not allow to set if_owner & report perm together
2024-01-30 14:28:37 +05:30
Ankush Menat
797cd696a7 Merge branch 'develop' into fix-fieldlevel-access-to-shared-document-list 2024-01-29 19:39:56 +05:30
Shariq Ansari
d89cec362c fix: do not allow to set if_owner & report perm together 2024-01-29 16:46:42 +05:30
Ankush Menat
63e2e2db56
feat: Configurable search link limit (#24539) 2024-01-26 06:31:11 +00:00
Shariq Ansari
4fecf0c07b fix: create custom doctype from customize form 2024-01-24 23:56:16 +05:30
RitvikSardana
cdfd1edf9d fix: improve new doctype dialog api 2024-01-24 23:56:08 +05:30
RitvikSardana
35a8a64879 fix: prefill doctype dialog with 'Is Child Table' 2024-01-24 23:56:07 +05:30
Ankush Menat
d697b8ede4
fix: update all users after commit (#24522) 2024-01-24 15:24:43 +00:00
Rucha Mahabal
0dfba5c6b9
Merge pull request #24378 from ruchamahabal/card-descriptions
feat: tooltip descriptions for Workspace Cards
2024-01-24 12:49:05 +05:30
barredterra
9d6cbd0c15 fix: typos 2024-01-24 02:41:03 +01:00
Rucha Mahabal
84a4c512c0 refactor: change fieldtype from Small Text to HTML Editor for card descriptions 2024-01-23 17:43:33 +05:30
Rucha Mahabal
c4fa8ea34c chore: set concise card descriptions 2024-01-23 17:43:33 +05:30
Rucha Mahabal
0b584814d4 feat: add card descriptions for Build workspace 2024-01-23 17:43:33 +05:30
Ankush Menat
ee6743c26b
fix: avoid mutating list while iterating over it (#24438) 2024-01-18 05:44:30 +00:00
Ankush Menat
c177431557
perf: Document objects without circular references (#17080)
* perf: `Document` objects without circular references

Circular references are usuallly considered bad for GC, avoiding them
since they don't seem to be necessary.

* fix: explicitly convert to weakref
2024-01-17 17:22:55 +05:30
Ankush Menat
ea08418d7d
fix: ignore unique fieldname validation during migrate (#24413)
This can be addressed later instead of failing a migrate
2024-01-17 08:52:05 +00:00
Ankush Menat
484049c5ae
fix: simultenous sessions ux (#24387)
* fix: set 2 as simultaneous_sessions by default

* fix: Correct offset for simultaneous_sessions

* refactor: use freeze_time instead of patching

* chore: misleading docstring

* test: set lower simultaneous_sessions for test
2024-01-16 13:36:05 +00:00
Ankush Menat
d5d9b12472
test: flaky server tests (#24301)
* Revert "fix(test_recorder): get the correct request (#24143)"

This reverts commit 745080c56e.

* test: disable recording before running assertions

* test: Dont set emails in test for broken email setup
2024-01-15 08:09:46 +00:00
Corentin Flr
f8ff2308e2
Merge branch 'frappe:develop' into fix-fieldlevel-access-to-shared-document-list 2024-01-15 01:32:51 +01:00
Ankush Menat
b3eaec4347
fix: misc (#24303)
* fix(DX): improve logging in various places

* fix(ux): misc RQ worker and job fixes
2024-01-13 10:54:38 +05:30
RitvikSardana
1666b0104f
fix: convert status field data to String before guessing the style (#24226)
* fix: status field should only be of type 'Select'/'Data'/'Check'

* chore: change code position

* fix: convert status field data to string to handle all cases

* chore: use cstr

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-01-12 17:41:21 +05:30
Ankush Menat
4dc9cd39ae chore: rename permission debugger to inspector 2024-01-11 22:01:38 +05:30
Ankush Menat
5ef8577cff
fix!: Stricter requirement for permission hooks (#24253)
BREAKING CHANGE:

before: `has_permission` hooks need to explicitly return "False" to block a user.

after: `has_permission` hook need to explicitly return "True" (or truthy) value to allow user. They will be blocked otherwise.

Why? Everything related to permission should be block by default and allow if some checks pass.
2024-01-11 01:35:08 +05:30
Ankush Menat
9620a3c596 Merge branch 'develop' into po-translation 2024-01-10 16:17:47 +05:30
Ankush Menat
914406d31b feat: extend perm debugging to popular controllers
- [x] File
- [x] Communication
2024-01-10 15:16:52 +05:30
Ankush Menat
3a8fc90961
feat: permission debugger (#24239)
* feat: permission debugger

This PR adds a virtual doctype that can run has_permission for
doctype-docname-user-ptype combinations and spit out detailed log for
why/where some permissionw as denied or granted.

This isn't supposed to be programatic, it's just textual dump of what code is doing.

IMO a better debugger can be written but that will require extensive
rewrite of perm checks first. All debugging, error messages in current
systems are bolted on top with hacks to avoid messing with
implementation.

* fix: capture UP pass check

* fix: reset docname on changing doctype

* fix: docname is optional

* fix: debug doctype perms
2024-01-10 09:29:13 +00:00
Akhil Narang
076687bdbf
Merge pull request #24188 from akhilnarang/dont-convert-email-lowercase
fix(communication): don't change email case
2024-01-08 17:14:05 +05:30