Commit graph

37300 commits

Author SHA1 Message Date
Maharshi Patel
96745b8f46 fix: on load of beta print format set iframe height
there was a edge case where when print format beta was set to default which never ran code which sets the size for container that holds format.
fixed that by make iframe height to 100vh minus navbar and heading on load of beta print format
2024-09-02 11:51:39 +05:30
Deepesh Garg
85b96ba162 feat: Custom timeouts for prepared report 2024-08-31 22:03:25 +05:30
Akhil Narang
ba42903429
Merge pull request #27580 from akhilnarang/disallow-uninstalling-frappe
fix: don't allow uninstalling frappe...
2024-08-30 18:18:55 +05:30
Akhil Narang
30f5669489
fix: don't allow uninstalling frappe...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-30 18:04:32 +05:30
Akhil Narang
d35dbf0d5b
fix(assign_to): escape HTML
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-30 17:30:15 +05:30
Shariq Ansari
cc5db784f3 fix: boot.default_path is moved to boot.apps_data.default_path 2024-08-30 17:20:36 +05:30
Shariq Ansari
aa99faddea test: fixed failing user test 2024-08-30 16:48:21 +05:30
Shariq Ansari
f2e8f05558 fix: redirect to /app if no apps are installed 2024-08-30 16:23:24 +05:30
Gavin D'souza
0ea610a314
fix: Pass doc.name as label fallback in search_link
Populate desk link titles when relevant information is available via
search_link endpoint
2024-08-30 12:16:29 +02:00
Shariq Ansari
2973739f2e fix: show Apps if multiple app or show CRM if only CRM is installed in dropdown 2024-08-30 15:42:58 +05:30
Shariq Ansari
9133f2a9c5 fix: added apps data in boot 2024-08-30 15:42:58 +05:30
Shariq Ansari
a7543a5b24 fix: consider default path for Website User if applicable 2024-08-30 15:42:58 +05:30
Shariq Ansari
ad077644c5 fix: changed default check icon 2024-08-30 15:42:58 +05:30
David
1619cc0e58
feat: add cache control 2024-08-30 09:08:42 +02:00
Gavin D'souza
7f7c97d499
fix: Set doc title name as fallback
When the title field is unset for a document, it's value gets unset in a
link field on click. Added this fallback on the endpoint so that
clicking on field doesn't add an additional API call to fetch the title
via Desk.

Co-authored-by: Marica Dsouza <maricadsouza221197@gmail.com>
2024-08-29 20:07:31 +02:00
Raffael Meyer
cad512e5a0
fix(query report)!: skip empty filters in print (#27016) 2024-08-29 13:58:21 +02:00
Akhil Narang
37732496ad
Merge pull request #27542 from akhilnarang/clear-all-user-sessions
fix(sessions): logout properly when user requests logout on password change
2024-08-29 11:21:13 +05:30
Gavin D'souza
074da5c553
fix: Separate meta.get_valid_fields from *columns 2024-08-28 18:12:42 +02:00
Akhil Narang
cdfbbde3d5
Merge pull request #23691 from phot0n/fix-email-bulk-retry
refactor(minor): email retry
2024-08-28 16:54:48 +05:30
Gavin D'souza
151de897f1
fix: Use doc.get to safely check for attr
This bypasses the bungle during site creations when meta isn't present in
the database yet
2024-08-28 11:59:25 +02:00
avc
09ab0caab0
Merge branch 'frappe:develop' into fix-report-excel-translation 2024-08-28 11:44:57 +02:00
Gavin D'souza
12e3cee4a6
fix!: Skip virtual fields in meta.get_valid_columns 2024-08-28 11:42:43 +02:00
Raffael Meyer
594b0a2536
Merge branch 'develop' into address-autocomplete 2024-08-28 11:14:43 +02:00
David Arnold
b0362684ef
Merge pull request #26752 from blaggacao/perf/make-get-requests-potentially-cachable
perf: make get requests cacheable
2024-08-28 10:44:19 +02:00
Akhil Narang
848bbe2382
Merge pull request #27539 from frappe/gavindsouza/website_search-norerun
fix(website_search): Avoid recursive loop if _items_to_index is falsy
2024-08-28 10:59:29 +05:30
Akhil Narang
5570aa71be
fix(sessions): logout properly when user requests logout on password change
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-27 17:58:20 +05:30
Corentin Forler
22324ab9e8
fix: Set undefined values to zero in round_floats_in 2024-08-27 14:19:57 +02:00
gavin
3544b87f58
fix(website_search): Avoid recursive loop if _items_to_index is falsy 2024-08-27 14:11:37 +02:00
Akhil Narang
dcd14d07dc
Merge pull request #27515 from Ninad1306/map_docs_fix
fix: Update Child table from the Last Source Doc
2024-08-27 13:29:20 +05:30
David Arnold
33de9ea8c6
Merge pull request #27237 from blaggacao/feat/datatable-tree-depth-on-query-reports
feat: set variable datatable tree depth
2024-08-27 09:36:19 +02:00
Akhil Narang
beadf189bf
Merge pull request #27528 from akhilnarang/escape-html-awesomebar
fix(search_utils): escape HTML before displaying in awesomebar
2024-08-27 11:26:24 +05:30
Rushabh Mehta
dfd7606d03
Merge pull request #27499 from rmehta/espresso-sidebar
feat(design): espresso style sidebar
2024-08-27 09:16:57 +05:30
Rushabh Mehta
2823f1a595 fix(minor): style fixes 2024-08-27 08:59:00 +05:30
Rushabh Mehta
25d1218f20
Merge pull request #27441 from cogk/fix-form-geolocation-field-in-tabbed-layout
fix(form): Fix Geolocation/Signature fields in tabbed layout
2024-08-26 23:44:11 +05:30
Sumit Bhanushali
895a81cccd fix(ChildTable): apply depends_on on field update 2024-08-26 22:31:46 +05:30
Rushabh Mehta
8793ca506f fix(tests): workspace 2024-08-26 22:04:20 +05:30
Rushabh Mehta
77b11dd1ce fix(tests): workspace tests and more style fixes 2024-08-26 18:15:59 +05:30
Akhil Narang
fbdd9e2484
fix(search_utils): escape HTML before displaying in awesomebar
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-26 16:21:57 +05:30
Rushabh Mehta
72eb501de3 fix(minor): breadcrumbs without app icon 2024-08-23 22:15:35 +05:30
Rushabh Mehta
b31cf8ba79 fix(style): sidebar overlay + polishes 2024-08-23 22:15:35 +05:30
Rushabh Mehta
087ee41ea1 feat(design): espresso style sidebar 2024-08-23 22:15:33 +05:30
Akhil Narang
7828c51d90
fix(grid): this is defined here, meant to this if this.grid_rows_by_docname was defined
Followup to #27495

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-23 16:07:22 +05:30
Akhil Narang
09c28f1fd1
Merge pull request #27495 from akhilnarang/fix-grid-error
Each individual commit message has details
2024-08-23 14:48:13 +05:30
Ninad1306
827acd2975 fix: update child table value from the last doc 2024-08-23 12:47:08 +05:30
Akhil Narang
9ebda98c2d
Merge pull request #27494 from akhilnarang/fix-ratelimiter
fix(rate_limiter): we can't call str.join([]) with NoneTypes in the list
2024-08-23 10:46:33 +05:30
Devin Slauenwhite
a2f4013e1e fix: show link title in generated form hrefs 2024-08-22 20:35:25 -04:00
Raffael Meyer
f7fb0d7b35
fix(Workspace): translatable sidebar sections (#27281) 2024-08-22 14:03:15 +00:00
Akhil Narang
eb509e9ae8
fix(query_report): sentry FRAPPE-2TF
```
TypeError: Cannot read properties of undefined (reading 'map')
  at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1688:39)
  at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)
```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:29:44 +05:30
Akhil Narang
678a404181
fix(table_multiselect): sentry FRAPPE-6QQ
```
TypeError: Cannot read properties of undefined (reading 'fields')
  at frappe.ui.form.ControlTableMultiSelectget_link_field(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table_multiselect.js:151:28)
  at frappe.ui.form.ControlTableMultiSelectset_formatted_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table_multiselect.js:124:27)
  at _a.set_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/data.js:247:8)
  at update_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_input.js:89:8)
  at _a.refresh_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_input.js:110:5)
  at frappe.ui.form.Controlrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_control.js:140:9)
  at frappe.ui.form.Layoutattach_doc_and_docfields(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:490:59)
  at frappe.ui.form.Layoutrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:344:8)
  at frappe.ui.form.Formrefresh_fields(../../../../../apps/frappe/frappe/public/js/frappe/form/form.js:679:15)
  at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/form/form.js:618:16)```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:27:40 +05:30
Akhil Narang
cfc8d7a010
fix(print_utils): simplify checks
Make it more readable, and prevent error

Sentry FRAPPE-4SQ

```
TypeError: Cannot read properties of undefined (reading 'default_letter_head')
  at frappe.ui.get_print_settings(../../../../../apps/frappe/frappe/public/js/frappe/form/print_utils.js:6:65)
  at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1640:29)
  at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:25:42 +05:30