Commit graph

38348 commits

Author SHA1 Message Date
Aradhya
fca026927e refactor: moved all query logic to query class 2022-06-28 19:41:32 +05:30
Aradhya
d0680941ad refactor: frappe.qb.engine
* feat: supporting empty iterables for Contains objects
* fix: explicitly setting empty iterables as tuples to support more operators
* feat: Added locate to frappe.qb Functions
* feat: Added support for functions passed as strings in fields
* feat: Included Criterion objects as fields
* fix: picking up only function intended fields to pass to get_function_objects
* feat: Added iterable for available functions, added support for Field objects
* fix: fixed * passed in fields in lists
2022-06-28 19:41:23 +05:30
Aradhya
d1f5c49b02 refactor(qb-engine): frappe.db.query
* feat: Added support for True as filter and pluck in the query engine

* feat: Added join support

* fix: return if filters are None

* feat: Added support for sets as filters and additional conditions

* fix: fixed IS operator in query builder

* feat: Added support for 'as' in query engine

* fix: fixed 'as' for criterion objects passed directly

* fix: fixed frappe.db.count

* fix: fixed functions in fieldname

* feat: Added support for multiple fields passed as a single string :) fixed None fields in a list

* feat: Added support for "as" in single string fields

* fix: fixed queries with invalid syntax
2022-06-28 19:40:34 +05:30
Aradhya
8cf6d42d17 feat: Trying to replace db_query operations directly with qb 2022-06-10 08:53:46 +05:30
Rushabh Mehta
7a1d5e304c
Merge pull request #17108 from rmehta/custom-formatters
feat(minor): add custom formatters for text type controls
2022-06-09 17:16:49 +05:30
gavin
fc9308f8ba
fix: Use same labels for standard fields throughout interfaces (#17031)
* fix(model)!: Match labels in meta & model

Labels for fields have been inconsistent. In standard filters, doc.name
would be labelled as "Name" while it's "ID" in the edit filters option.
Similarly for other fields, the same view will address the same fields
differently. This PR aims to get rid of such inconsistencies.

Changes:

* [model] Change label ID for name to 'Name'
* [meta] Match labels of owner, modified, modified_by
* [meta] Add labels for more fields - from model.js

* fix!: get_label to fetch labels as Desk does

* fix!(label): Refer to name field as 'ID' over 'Name'

* test: Use 'ID' label instead of 'Name'
2022-06-09 15:34:57 +05:30
Shariq Ansari
f96c623b33
fix: added text editor dialog on hide action (#17117)
* fix: added text editor dialog on hide action

When we edit text editor field and close the dialog the cell in datatable is empty

* chore: bump datatable to 1.16.4
2022-06-09 14:33:08 +05:30
Rushabh Mehta
e66cd830fb fix(minor): test + tabs 2022-06-09 14:17:43 +05:30
gavin
491b5b0760
Merge pull request #17012 from gavindsouza/request-cache
feat(utils): Caching Utils
2022-06-09 13:08:11 +05:30
Ankush Menat
b3b7126f7a
fix: dont set standard fields in child doc using set_value (#17056) 2022-06-09 13:06:58 +05:30
Rushabh Mehta
da9ac52ffb fix(minor): lint 2022-06-09 12:44:47 +05:30
Gavin D'souza
54dd72b8da chore: Import sys in msgprint's namespace 2022-06-09 12:43:56 +05:30
Rushabh Mehta
e790b5e8b1 fix(minor): added UI test 2022-06-09 12:34:09 +05:30
gavin
9ce74fb6c4
Merge branch 'develop' into request-cache 2022-06-09 12:32:03 +05:30
Gavin D'souza
2e5784629b fix: Avoid possible iteration failures passing default in pop 2022-06-09 12:31:05 +05:30
gavin
41da2ba50b
Merge pull request #17123 from gavindsouza/refactor-re-fixes
fix: Regex compilation in boilerplate utils
2022-06-09 12:22:27 +05:30
Rushabh Mehta
65f5910dc3 fix(minor): missing parameter 2022-06-09 12:07:04 +05:30
Rushabh Mehta
3ceafc42fd fix(minor): fewer emojis 2022-06-09 12:07:04 +05:30
Rushabh Mehta
378b44a382 fix(minor): fix flaky test 2022-06-09 12:07:04 +05:30
Rushabh Mehta
17d537517b chore: remove console.log 2022-06-09 12:07:04 +05:30
Rushabh Mehta
cc10479e11 fix(minor): fix for customize form 2022-06-09 12:07:04 +05:30
Rushabh Mehta
9bbc592ed4 chore: add semis 2022-06-09 12:07:04 +05:30
Rushabh Mehta
dd14ac5f93 feat(minor): add custom formatters for text type controls 2022-06-09 12:07:04 +05:30
Gavin D'souza
13b18a9118 fix: Regex compilation in boilerplate utils
Flagged via tests in frappe.tests.test_boilerplate
2022-06-09 12:05:07 +05:30
Suraj Shetty
3a2e0ec2a0
Merge pull request #17122 from surajshetty3416/fix-comment-tag-extractor 2022-06-09 11:48:45 +05:30
Ankush Menat
fb4c53908a
Merge branch 'develop' into fix-comment-tag-extractor 2022-06-09 11:32:51 +05:30
Ankush Menat
5b0312c258 Revert "ci: correct last commit for patch test (#17113)"
This reverts commit 4c8787d523.
2022-06-09 11:13:31 +05:30
Ankush Menat
4c8787d523
ci: correct last commit for patch test (#17113) 2022-06-09 10:58:03 +05:30
Suraj Shetty
27b49743e3 fix: Comment tag extractor code 2022-06-09 09:22:07 +05:30
Suraj Shetty
394c0b5eb7
Merge pull request #17121 from frappe/surajshetty3416-patch-1
fix: Erroneous regex usage
2022-06-09 07:12:58 +05:30
Suraj Shetty
8e2555f510
fix: Erroneous regex usage
Fixes: https://github.com/frappe/frappe/pull/17111#issuecomment-1150118499

Issue introduce via: https://github.com/frappe/frappe/pull/17111
2022-06-09 07:12:04 +05:30
Deepesh Garg
b86744da83
fix: Customize Form button in Menu Item (#17062)
Users having the ability (permissions) to create Custom Field and Property Setter can do everything that a Customize Form can do, irrespective of whether the user has the System Manager role. So the button in the "Menu" should be visible based on permission instead of Role
2022-06-08 14:56:39 +00:00
Gavin D'souza
32b4983197 fix(re): Pass flags on instantiation 2022-06-08 16:31:58 +05:30
Sagar Vora
df28f32b8b
perf: ~90% faster frappe.get_cached_doc (#17107) 2022-06-08 15:49:11 +05:30
gavin
6f6ded256f
Merge pull request #17111 from gavindsouza/refactor-re
perf: Pre-compile and re-use regexp pattern
2022-06-08 15:05:59 +05:30
Vishal Dhayagude
b04af618f2
fix: fix ux for print preview page (#17087)
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2022-06-08 14:58:06 +05:30
Jannat Patel
d9f9ef28de
fix: translatable web templates (#17086) 2022-06-08 14:48:56 +05:30
Tom-Finke
1b5750f0df
feat(UI): Add beforeunload Listener for 'Leave Site' Dialog to dirty forms (#17059) 2022-06-08 14:42:29 +05:30
gavin
0649d7ce19
Merge branch 'develop' into refactor-re 2022-06-08 14:42:24 +05:30
Gavin D'souza
b696fa6da5 perf: Pre-compile and re-use regexp pattern
Converted all possible usages of re.* that weren't compiling the regex
separately and re-using it. Separated out the compiled patterns as
global variables. Repetitive patterns could be made DRY-er.

Would be nicer to have all regexes in a single module so that we could
re-use better, keep track of outdated, and keep checks for possible
reDos' etc
2022-06-08 14:07:38 +05:30
Maharshi Patel
a79a572f65
fix: print & breadcrumbs for forward slash (#17095) 2022-06-08 13:59:52 +05:30
gavin
67736ef727
Merge pull request #16289 from gavindsouza/refactor-file
refactor: File
2022-06-08 13:15:46 +05:30
gavin
d279f1bb87
Merge pull request #17103 from ruthra-kumar/run_tests_on_module_def
feat: run tests on Module Def
2022-06-08 12:45:39 +05:30
gavin
44dba28159
Merge branch 'develop' into refactor-file 2022-06-08 12:43:35 +05:30
Gavin D'souza
b189672307 test: Skip test_multiple_doctypes_sync for Postgres tests 2022-06-08 12:42:34 +05:30
Ankush Menat
b418aea169
Merge pull request #17097 from mmdanny89/mmdanny89-dev
fix: infinite loop graphic bar
2022-06-08 12:09:49 +05:30
Gavin D'souza
e22ab86651 fix: Show img even if URL ending is unknown - let html handle the stuff
it knows

* Hide Preview if request is errored. EAFP.
* Set file attachment limit based on how many attachments have already
  been added. If 1 attachment exists and the limit is 3, File uploader
will allow you to select only 2 more files.
2022-06-08 12:05:06 +05:30
Gavin D'souza
56d97da32e fix: commit after processing request of "unsafe" http method
ref: https://developer.mozilla.org/en-US/docs/Glossary/safe
2022-06-08 12:03:38 +05:30
Naveen
fd8af163ba
ci: Set permissions for GitHub actions (#17102)
chore: Set permissions for GitHub actions

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-06-08 11:55:16 +05:30
ruthra kumar
a202f1a621 feat: run tests all doctypes in module def 2022-06-08 11:54:36 +05:30