vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
37939 commits 1 branch 0 tags 587 MiB
Commit graph

37939 commits

This branch
This branch
All branches
Author SHA1 Message Date
Shariq Ansari
fcfb5ca901
feat: Add font sizes dropdown in text editor(quill) (#16910) 2022-05-17 12:12:03 +05:30
Shariq Ansari
1a4f1a6243
fix(minor): add_options breaking (#16913) 2022-05-16 22:18:01 +05:30
Himanshu
70409a3c7b
fix: set translated text to link field (#15451) 
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour

### Behaviour

- Link field loses focus: show the translated name.
- Link field is focused
    - If old value is present
        - If options **are** one of [Role, DocType]: show the translated name
        - Else: show the name (untranslated) to enable search in untranslated values
    - Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus

## Demo

### Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

#### Before

https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov

#### After

https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov

### Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

#### Before

https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov

#### After

https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
 2022-05-16 13:21:42 +00:00
mergify[bot]
07dd2371b1
fix: Filters Won't Work While Routing in Report (backport #16895) (#16908) 2022-05-16 16:16:41 +05:30
Rushabh Mehta
5958b41c91
Merge pull request #16909 from rmehta/select-fix 
fix(minor): refactor add_options
 2022-05-16 15:56:02 +05:30
Rushabh Mehta
8b854cac70 fix(minor): refactor add_options 2022-05-16 14:55:31 +05:30
Ankush Menat
1bf272b1d4
fix: add dependent status field in reportview (#16903) 2022-05-16 14:05:35 +05:30
Ankush Menat
a9d6147999
fix(server_scripts): warn about restricted context (#16900) 
Server script UX is bad when you don't know what's whitelisted and what isn't... this often requires executing-rewrite-execute cycle for trivial things.

So instead, on saving just compile server script and immediately give warnings for whatever that can be caught at compile time.
 2022-05-16 13:34:25 +05:30
Faris Ansari
4b13d6d7e4
fix(webform): only title on the page should be h1 (#16880) 
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
 2022-05-16 13:33:29 +05:30
Shariq Ansari
8a61c7489f
fix(patch): Reload workspace child tables in pre_model_sync (#16897) 
* chore: used better db API arguments

Co-authored-by: gavin <gavin18d@gmail.com>
 2022-05-14 12:59:54 +05:30
Ankush Menat
26b54221ea test: verify ALL translation file syntax 2022-05-13 16:12:40 +05:30
Ankush Menat
55def8b718 fix: recursion error in translations 
If bad translations is found then while `msgprint` it attempts to load
translation again because of its arg `title = _("Message")`
 2022-05-13 16:12:40 +05:30
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace (#16887) 2022-05-13 15:34:35 +05:30
Suraj Shetty
a5995b2a10
Merge pull request #16805 from phot0n/autoinc-customize-form-fix 
fix: don't allow setting autoincrement autoname from customize form
 2022-05-13 07:27:15 +05:30
Ritwik Puri
968343b302
Merge branch 'develop' into autoinc-customize-form-fix 2022-05-13 00:41:58 +05:30
phot0n
f14fb2326d test(customize form): rename test_autoincrement_autoname to test_change_to_autoincrement_autoname 2022-05-13 00:09:51 +05:30
phot0n
f6dac70033 refactor(minor): convert change_name_type_and_make_sequence function to setup_autoincrement_and_sequence method 
* chore(Customize Form): remove autoincrement naming option from autoname description

* chore: move sequence cache comment from schema.py to database.py

* chore: added docstrings to some functions
 2022-05-13 00:03:19 +05:30
phot0n
b1d61906d1 test: update and rename test_change_autoname 
* chore: remove unnecessary decorators for skiprun
 2022-05-13 00:03:19 +05:30
gavin
04baffb1ab
Merge pull request #16885 from gavindsouza/show-all-role-warning 
fix(ux): Show note on how 'All' Role impacts users
 2022-05-12 18:05:56 +05:30
Chillar Anand
485988682d
refactor: Remove dead code (#16886) 2022-05-12 18:04:44 +05:30
gavin
53d2d64e91
Merge pull request #16890 from ankush/bump_plyr 
chore: bump plyr to latest version
 2022-05-12 18:04:06 +05:30
Ankush Menat
ba5004e5cc chore: bump plyr to latest version 2022-05-12 16:30:30 +05:30
phot0n
82aa8dee08 fix: don't allow autoincrement autoname from customize form 
* test: test_change_autoname for doctype

* test: test_autoincrement_autoname for customize form
 2022-05-12 15:18:02 +05:30
gavin
20f28e760f
Merge pull request #16888 from gavindsouza/drop-site-no-partial-backup 
fix(drop-site): Take full backup before dropping site
 2022-05-12 14:40:21 +05:30
gavin
2c6299e65c fix: Take full backup before dropping site 2022-05-12 14:20:13 +05:30
gavin
34ae87603a
Merge pull request #16840 from phot0n/refactor-insert-many-client 
refactor(minor): move out common functionality from insert and insert_many client functions to a separate function
 2022-05-12 14:03:10 +05:30
gavin
cdb92f2dfa
Merge pull request #16747 from ChillarAnand/atom 
feat: Added force flag to install-app command
 2022-05-12 13:50:16 +05:30
gavin
8a2c351cf1 fix(ux): Show note on how 'All' Role impacts users 
In response to https://github.com/frappe/frappe/issues/16836
 2022-05-12 13:29:57 +05:30
Ankush Menat
8c02971224 chore: misleading typehint 
[skip ci]
 2022-05-12 11:30:05 +05:30
phot0n
0d9a6adcd9 test: test for insert_many client function 2022-05-11 23:59:21 +05:30
phot0n
b1a2007024 fix: use set instead of list in insert_many client function 2022-05-11 23:41:47 +05:30
Ritwik Puri
7fa9c42711
Merge branch 'develop' into atom 2022-05-11 22:35:09 +05:30
phot0n
d28eb94281 test: test for force install-app 
Note: this is a very minimal test, as frappe_docs doesn;t really have any doctypes
 2022-05-11 22:34:18 +05:30
phot0n
c89a66a694 fix: only set home_page in after_install, if the key doesn't have value 2022-05-11 16:18:14 +05:30
phot0n
5b4fb3f2cf fix: don't add navbar items if theyre already present 
* fix: don't set installed_apps global value in after_install hook
 2022-05-11 16:18:14 +05:30
phot0n
ef99b57a08 chore: use secho instead of raising exception if app is already installed 
* chore: singular click import
 2022-05-11 16:18:14 +05:30
phot0n
fc6093515d chore: add comments and add force flag to more places 2022-05-11 16:18:14 +05:30
chillaranand
d2b63d0935 feat: Added force flag to install-app command 2022-05-11 16:18:14 +05:30
Suraj Shetty
5c9542ab3f
Merge pull request #16860 from ollyboy/develop 2022-05-11 14:36:01 +05:30
gavin
ef971017c5
Merge pull request #16876 from netchampfaris/fix-metatags-description 
fix: description metatag
 2022-05-11 14:07:07 +05:30
Faris Ansari
eeab5edf5f test: test for metatag rendering 2022-05-11 13:29:03 +05:30
Faris Ansari
6994cc684f fix(metatags): check if value is set for key 2022-05-11 13:28:38 +05:30
gavin
b5a0410609
Merge pull request #16858 from ankush/realtime_buffering 
fix: duplicate list_update realtime events
 2022-05-11 12:58:06 +05:30
Ankush Menat
c55c8e4f97
refactor(DX): add type hints for some utilities (#16871) 
- Added type hints to majority of most used functions in `utils/data.py`
- added overloads for functions whose output depends on input type. This helps A LOT if your LSP supports type narrowing (like pyright)


Example:
Same function with 3 diff singatures narrowed by input value. 
<img width="1270" alt="Screenshot 2022-05-10 at 8 02 02 PM" src="https://user-images.githubusercontent.com/9079960/167653595-2ab9441f-da40-4645-aa87-9ec0d96cbec9.png">
 2022-05-11 06:14:31 +00:00
gavin
be888bac32
Merge pull request #16868 from gavindsouza/dashboard-view-fixes 
fix: Dashboard view
 2022-05-11 11:39:26 +05:30
Himanshu
5ac729252f
fix: change ordering to creation (#16863) 2022-05-10 19:41:11 +05:30
gavin
3370d227e8
Merge branch 'develop' into dashboard-view-fixes 2022-05-10 17:47:31 +05:30
Gavin D'souza
66ccd103ed fix: Fetch meta to ensure formatting for Dashboard Charts 
* This handles setting meta for dashboard chart of types: Sum, Count,
  Average, Group By
* Dhashboard Charts of type Report have to pass fieldtype in chart data
  Dict to apply formatting. This can't be done magically AFAIK
 2022-05-10 15:03:18 +05:30
Gavin D'souza
c16bec3407 chore: Simplify get_open_count doc usage 2022-05-10 15:00:52 +05:30
Ankush Menat
8a1889301a chore!: remove dead hooks app_icon & app_color 2022-05-10 14:41:01 +05:30