Commit graph

38796 commits

Author SHA1 Message Date
vorasmit
ff734532aa
fix: set primary action after clearing previous action (#17454) 2022-07-12 21:06:52 +05:30
Sagar Vora
7a59fc7ecf
fix: simplify defaults._clear_cache (#17485) 2022-07-12 20:45:49 +05:30
Ritwik Puri
fbb89bdfe9
fix: delete user mention cache when a user is disabled or enabled (#17451)
User Mention cache is deleted on 3 occasions:

* when a new user is inserted
* when allowed_in_mention or user_type value has changed
* when a user is deleted

But we didn't delete it when a user was enabled or disabled as we maintain the mention cache for enabled users
2022-07-12 18:58:07 +05:30
Ankush Menat
ca39cfb11d
feat: support strikethrough in text-editor/comments (#17478)
IMO strikethrough is useful way more often (than many other options that we
already support in editor) so adding it in default config.

closes #17470
2022-07-12 18:38:28 +05:30
Ankush Menat
9530c90c09
fix(quill): don't go beyond container for bubble (#17475)
Container uses bubble type quill editor, options for which seem to spill
out and hide behind the commend container. This fixes the UI glitch.

ref: https://quilljs.com/docs/configuration/#bounds
2022-07-12 18:19:39 +05:30
Sagar Vora
4671460b65
fix: dont scrub key if found in defaults, but falsy (#17467)
* fix: dont scrub key if found in defaults, but falsy

* fix: remove redundant use of `.get`
2022-07-12 17:06:06 +05:30
Suraj Shetty
e6043ef427
fix: Wait for request to complete before firing new request
Sometimes it might take more than 5s
2022-07-12 16:57:20 +05:30
Ankush Menat
415a8b1a7d
Merge pull request #17461 from surajshetty3416/fix-newsletter-performance
perf: Re-use SMTP session while sending bulk emails
2022-07-12 16:14:02 +05:30
Ankush Menat
c1f1895563
Merge pull request #17474 from ruthra-kumar/preserve_type_in_excel_export
fix: Preserve data type in excel export except for composite
2022-07-12 16:13:16 +05:30
Ankush Menat
0a73a3c708 refactor: stringify all non-excel types
style: incorrect EOF

test: excel export types
2022-07-12 15:53:55 +05:30
Suraj Shetty
6bcef3781e fix(email queue): Remove unnecessary indexing 2022-07-12 15:20:44 +05:30
ruthra kumar
dd9fbeff4b fix: Preserve data type in excel export except for composite 2022-07-12 14:03:24 +05:30
Suraj Shetty
34b1ea57f9 fix: Show "Queued" status on newsletter
Show "Queued" status on newsletter if emails are queued and "email sending" is not yet started.
2022-07-12 13:03:06 +05:30
Suraj Shetty
5c72181f22 perf(email queue): Index status, reference_doctype & reference_docname 2022-07-12 12:59:53 +05:30
Suraj Shetty
2b0a3533d3 test: Update test case according to changes 2022-07-12 12:58:15 +05:30
Shariq Ansari
2c2368e973
fix: Datetime field not getting saved if use NOW button. (#17452) 2022-07-12 12:12:39 +05:30
Ankush Menat
9fa69e2610
Merge pull request #17463 from ankush/feat/webhook_previews
feat(UX): generate preview of Webhook request data
2022-07-12 11:27:24 +05:30
Suraj Shetty
a574e3c09e fix: Send emails immediately during tests 2022-07-11 18:55:43 +05:30
Ankush Menat
e652811d55 fix: ignore virtual fields when doing db_update 2022-07-11 18:33:50 +05:30
Ankush Menat
d5820213f0 feat: preview Webhook request data 2022-07-11 18:26:57 +05:30
Ankush Menat
1531e36004 fix: allow JSON array as request body 2022-07-11 18:26:54 +05:30
Ankush Menat
d4fe142674 fix(UX): correctly validate python condition 2022-07-11 18:26:54 +05:30
Suraj Shetty
8f5650de5b fix: Use errored email stats while showing send status 2022-07-11 17:43:56 +05:30
Suraj Shetty
a1bd1b3b23 perf: Index status of recipeint & unsubscribed & email_group of member
- This will improve the performance of few get queries newsletter
2022-07-11 17:42:41 +05:30
Suraj Shetty
bae2db278d fix: Update status color
Because both "Not Sent" & "Not Saved" had same indicator color and it was hard to distinguish
2022-07-11 15:27:43 +05:30
Sagar Vora
a9fd5f5001 fix: dont allow blank content of unsupported type 2022-07-11 14:23:10 +05:30
Sagar Vora
e8623dbc19 fix: simplify condition 2022-07-11 14:10:59 +05:30
Suraj Shetty
802a1ac993 refactor: Newsletter status updator
- Freeze newsletter till emails are queued
- Show newsletter status as "Sending" if emails are in queue
- Remove unused dashboard code
2022-07-11 13:42:15 +05:30
Suraj Shetty
da52098bd3 perf: Batch email queuing while sending emails to large no. of recipients separately
- Batch email queue
- Re-use smtp_session while sending bulk emails (from same sender)
instead of creating new session for everytime.
Note: creation of new email session is very expensive.
2022-07-11 12:24:25 +05:30
Raffael Meyer
bbfdc52e5c
fix: check mimetype if content is present (#17456) 2022-07-11 06:52:23 +00:00
stephen
3aaf59d870
fix: username for Notification Log was wrong for Administrator (#17434)
* fix: username for Notification Log was wrong for Administrator

* refactor: simplify make_notification_logs

- Split overindented code
- Remove check for EPS, if EPS is disabled then why is it creating
  notification?

* fix: fetch email ID from User document before notifying

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-07-11 11:56:47 +05:30
Sagar Vora
fc99c22ea2
fix: ensure that frappe.db.get_defaults works for all parents (#17296)
fix: ensure that frappe.db.get_defaults` for all parents, as designed
2022-07-08 18:08:36 +05:30
Suraj Shetty
0a8a91e30b
Merge pull request #17447 from ankush/test/private_files 2022-07-08 11:28:20 +05:30
Ankush Menat
d04df394a5 test: check for uploaded file to be private 2022-07-08 11:06:49 +05:30
Sagar Vora
6597dedaed
chore!: remove unused APIs from frappe.client (#17446)
chore: remove unused APIs from `frappe.client`
2022-07-08 10:49:39 +05:30
Suraj Shetty
658f5b6aa7
Merge pull request #17437 from surajshetty3416/files-private-by-default
fix: Set files private by default
2022-07-07 18:05:14 +05:30
Ankush Menat
111060224b fix: naming series tool doesn't load if missing numbers 2022-07-07 17:38:52 +05:30
Suraj Shetty
5d01fffac5 fix: Set files private by default 2022-07-07 15:15:41 +05:30
Shariq Ansari
15018b96fa
test: fixed flaky workspace blocks UI test (#17436) 2022-07-07 14:53:25 +05:30
Ankush Menat
bea2df6dcc
perf: drop country_info from boot (#17431)
* fix: unknown function call

* perf: drop country_info from boot

This is ~50kb of data that is sent with every boot.
2022-07-07 14:41:13 +05:30
Ankush Menat
b5128a35fd
refactor: simplify fetching of readable records (#17417)
- remove encoding, use cstr directly
- remove falsy values by default None, empty string.
2022-07-07 14:40:59 +05:30
Shariq Ansari
44117f6702
fix: switch tab if mandatory field is in different tab (#17435) 2022-07-07 14:20:54 +05:30
Bhavesh Maheshwari
f972bb320b
fix: phone field type hidden property break form load (#17426)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-07-07 12:19:23 +05:30
mergify[bot]
010a436569
Merge pull request #17407 from ruthra-kumar/error_on_export_of_composite_cell_value
fix: valueerror on export with composite cell valu
2022-07-07 05:49:18 +00:00
Ankush Menat
1f9a6b010a
perf: add __slots__ to most used classes (#17421)
Added slots for these classes:

- Session - Created on EACH request
- LoginManager - Created on each request
- Monitor - Created on each request if monitor is enabled (usually in
  prod setup)
2022-07-07 11:15:50 +05:30
Ritwik Puri
b115aef414
fix: sanitize all line boundaries for email headers (#17408)
* test: add test case for subject with LF, CR and line separator
2022-07-07 10:43:00 +05:30
Suraj Shetty
281160ba2f
Merge pull request #17429 from frappe/dependabot/npm_and_yarn/moment-2.29.4
build(deps): bump moment from 2.29.2 to 2.29.4
2022-07-07 09:44:47 +05:30
dependabot[bot]
39ded52028
build(deps): bump moment from 2.29.2 to 2.29.4
Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.2...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-07 04:10:25 +00:00
Suraj Shetty
5efbedf06d
Merge pull request #17419 from surajshetty3416/replace-incompatible-libraries 2022-07-07 09:39:56 +05:30
Suraj Shetty
ccebf352c6
Merge branch 'develop' into replace-incompatible-libraries 2022-07-07 09:27:35 +05:30