Commit graph

44805 commits

Author SHA1 Message Date
Corentin Flr
0932bbf10c
fix(OTP): Autofocus OTP input, fix placeholder (#24203)
* fix(OTP): Autofocus OTP input

DOM insertion does not trigger autofocus, only initial load does.

* fix(OTP): Fix placeholder of OTP input
2024-01-08 21:38:16 +05:30
Ankush Menat
9b8a8c155d
fix: Correct logic for can_cancel (#24196)
You can cancel a document IFF:
- Document has no workflow
- Document has workflow but it doesn't have state with docstatus=2.

closes https://github.com/frappe/frappe/issues/19075
2024-01-08 19:15:19 +05:30
Suraj Shetty
f0e8fedb53
Merge pull request #24144 from batonac/patch-3 2024-01-08 17:48:21 +05:30
Akhil Narang
b3f90ef7f7
Merge pull request #24127 from akhilnarang/db-backup-restore-pipefail
refactor: set pipefail in shell before running piped backup/restore commands
2024-01-08 17:43:25 +05:30
Akhil Narang
ebdf88150d
Merge pull request #24145 from akhilnarang/fix-backup-restore
fix(restore): check backup directory and bench directory if we can't find the file
2024-01-08 17:42:58 +05:30
Suraj Shetty
2ef4492cdc
Merge pull request #24194 from surajshetty3416/fix-default-datetime 2024-01-08 17:21:50 +05:30
Suraj Shetty
64e37ec046 fix: Handle empty value of datetime control 2024-01-08 17:19:40 +05:30
Akhil Narang
076687bdbf
Merge pull request #24188 from akhilnarang/dont-convert-email-lowercase
fix(communication): don't change email case
2024-01-08 17:14:05 +05:30
Shariq Ansari
54ecae0656
fix: Allowed standard fields in data export ( creation, owner) (#24187)
Co-authored-by: Pavan Kumar Yekabote <yekabotep@gmail.com>
2024-01-08 17:09:13 +05:30
Akhil Narang
e3bafe15b6
fix(communication): don't change email case
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-08 16:31:03 +05:30
Suraj Shetty
db9878c25d
Merge pull request #24182 from RitvikSardana/develop-ritvik-rowWidth-fix 2024-01-08 16:03:03 +05:30
V Shankar
b58f6a7420
fix: Make Autocomplete option cache like link field (#23888)
* fix: execute query even though input cache exists

* fix: remove invalid autocomplete caching

This cache can get stale when document value changes.

---------

Co-authored-by: Shankar <Shankarv19bcr>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-01-08 15:59:34 +05:30
Ankush Menat
4e188ec531
fix: webhook error logging fails (#24172)
These variables can be unset if webhook fails while creating them.
2024-01-08 15:37:04 +05:30
RitvikSardana
e948afe938 build(deps): bump frappe-datable to v1.17.14 2024-01-08 15:31:21 +05:30
Shariq Ansari
5ad2d2eadc
Merge pull request #24175 from shariquerik/copy-content-on-reply
fix: copy content on reply
2024-01-08 15:18:43 +05:30
Ankush Menat
216b5fa9bf chore: Skip explicit opt out
We dont load posthog js if user opts out, so this starts failing.
2024-01-08 15:12:59 +05:30
Shariq Ansari
c1ebfc64b6 fix: copy content on reply 2024-01-08 15:08:13 +05:30
Shariq Ansari
6d40d1c6da
Merge pull request #24170 from shariquerik/precision-in-webform
fix: added precision field in webform field
2024-01-08 14:57:30 +05:30
Suraj Shetty
4b375006bf
Merge pull request #24157 from rmehta/fix-login-footer-visibility 2024-01-08 14:46:34 +05:30
Shariq Ansari
e2bc379b23 fix: get precision data while getting fields 2024-01-08 14:33:31 +05:30
Shariq Ansari
50e43df26b fix: include Web Form Field in core_doctypes 2024-01-08 14:32:56 +05:30
Rushabh Mehta
20986060ca fix(style): set min height correctly 2024-01-08 14:32:25 +05:30
Shariq Ansari
2969b6eff1 fix: added precision field in webform field 2024-01-08 14:24:16 +05:30
Akhil Narang
b9923571dc
fix: check correct part of backup header
`-- Backup generated by Frappe 15.1.0 on branch fix-backup-restore`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-08 13:06:59 +05:30
Rushabh Mehta
eb0e8262a7
fix(minor): Don't load user_info for Administrator twice. fixes #22211 (#24160) 2024-01-08 12:51:32 +05:30
Ankush Menat
f6388f6357
fix: Skip no-value fields for rename (#24163) 2024-01-08 12:50:34 +05:30
Ankush Menat
c1d687ddbb
fix: ignore user settings on report doc (#24162) 2024-01-08 12:42:13 +05:30
Rushabh Mehta
482813e46d
Merge pull request #24155 from rmehta/fix-help-category-unpublish
fix(minor): Unpublish article when category is unpublished #15361
2024-01-08 12:30:34 +05:30
Rushabh Mehta
5275f393c7 fix(minor): drop icon column, unsupported, fixes #23826 2024-01-08 12:07:10 +05:30
Rushabh Mehta
04646024cb fix(minor): show footer on login via Website Settings, fixes #24153 2024-01-08 11:56:51 +05:30
Rushabh Mehta
cb2e803d0c fix(minor): Unpublish article when category is unpublished #15361 2024-01-08 11:39:02 +05:30
Safwan Samsudeen
d0157f7862
fix: mobile issue with form pop up (#24125)
* fix: mobile configure columns issue

* fix: correct grid view issue

* fix header too
2024-01-07 18:17:30 +05:30
Corentin Flr
c6bdc7fe45
fix(workspace): Fix widget rendering for EditorJS v2.28 (#23918)
* fix(workspace): Ensure Block.render() always return an element

If `has_data` is false, then `this.wrapper` is still empty (because it was just created and `this.make` did nothing), so it's safe to give it back to EditorJS for rendering.

* build(deps): Bump EditorJS
2024-01-07 12:36:55 +05:30
Akhil Narang
745080c56e
fix(test_recorder): get the correct request (#24143)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-06 09:42:53 +05:30
Raffael Meyer
3fd26775b3
fix(Web Form): make button label translatable (#24122)
* fix(web Form): make button label translatable

* fix: context in web form translations
2024-01-05 23:32:53 +05:30
Akhil Narang
232da65e4c
fix(restore): check backup directory and bench directory if we can't find the file
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-05 15:42:31 +05:30
Kevin Shenk
4ec4594c62
fix: notification.py should ignore permissions on fetching on mobile_no receiver list
Similar to fetching the email list in `get_list_of_recipients()`, the `get_info_based_on_role` call to fetch `mobile_no` in `get_receiver_list()` should set `ignore_permissions` in order to allow sms notifications to send based on actions of limited and anonymous users (e.g. web form submissions).
2024-01-05 04:49:33 -05:00
Ankush Menat
f7ff072b5a
test: fix ui tests (#24136)
caused by https://github.com/frappe/frappe/pull/24077
2024-01-04 14:38:24 +00:00
Fadil SIddique
941b5faf65
fix: number card only gives integer (#24047)
* fix: number card only gives integer

* fix: replace float with flt

* fix: minor fix

---------

Co-authored-by: fadilsid <fadil@tridz.com>
2024-01-04 19:47:45 +05:30
Corentin Flr
7f9331fc8d
fix(router): Don't capture clicks on links with target attr (#24110) 2024-01-04 19:42:45 +05:30
Ankush Menat
3916398f1a
fix(recorder): Normalize IN in SQL queries (#24132) 2024-01-04 19:08:59 +05:30
Akhil Narang
9586b5f18a
fix(execute_in_shell): run explicitly in bash
`pipefail` isn't supported in sh, bash is common enough to be installed nearly everywhere

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-04 19:07:28 +05:30
Ankush Menat
022be815dd
Merge pull request #24118 from ankush/imap_failure_messages
fix: Broken IMAP account disabling logic
2024-01-04 18:56:52 +05:30
Akhil Narang
58a13cfb3e
refactor: set pipefail in shell before running piped backup/restore commands
Drop the complicated logic behind storing pid and killing process if first stage of pipe fails

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-04 18:41:37 +05:30
Ankush Menat
cc2bb85484 fix: correct arg type
assign_to expects a list of strings of users not a single string.
2024-01-04 18:39:15 +05:30
Raffael Meyer
edac879d7e
refactor!: remove unused parameter from rebuild_tree, add type hints (#24123)
* refactor!: remove unused parameter from rebuild_tree, add type hints

* fix: remove parent_field parameter from backend calls
2024-01-04 18:13:12 +05:30
Ankush Menat
3836d942ac fix: logic to disable broken account
This doesn't work because when email is broken we still continue and
down the line changes get rolled back.
2024-01-04 17:39:25 +05:30
Ankush Menat
71908f1e00 refactor: respect multi-tenancy
redis set/get don't consider site
2024-01-04 17:39:25 +05:30
Ankush Menat
807cfd66f1 fix: Reset failed attempts ONLY if succesful connection is made 2024-01-04 17:39:25 +05:30
Akhil Narang
6acbdbfc97
Merge pull request #24103 from akhilnarang/background-jobs-recorder
feat: support background jobs in recorder
2024-01-04 17:08:27 +05:30