Commit graph

436 commits

Author SHA1 Message Date
Ankush Menat
4f70200bd5 chore: track update actions per doctype
[skip ci]
2023-06-22 12:10:43 +05:30
gavin
09501da12f
fix(meta): Revert to using conf over _dev_server for cache (#21391) 2023-06-15 17:45:10 +05:30
Shariq Ansari
9e0ed9d2a2 fix: convert string to int 2023-06-13 16:23:39 +05:30
Shariq Ansari
0e962078fe revert: temp fix to load communications 2023-06-13 16:20:07 +05:30
Ankush Menat
22149b5bff chore: increase communication limit
This needs better fix, added temporarily
2023-06-13 12:12:21 +05:30
Ankush Menat
8a30667a97
fix: Fetch non-cached version of Meta on Customize Form. (#21269)
* fix: Replace meta cache when uncached meta is requested

* fix: use meta from DB on customize form

* refactor: make cached kw only, use _dev_server
2023-06-12 14:59:42 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ankush Menat
2ed2f8747d chore: track doc creation
This is alternate to "Activation" level that already exists, activation
level will be phased out over time.
2023-05-29 13:34:24 +05:30
Shariq Ansari
89186b8057 fix: multiple assignments to the same person 2023-04-24 11:30:35 +05:30
Marica
90f8f945b4
feat: Disable Sharing globally (#20318)
* feat: Disable Sharing globally

- Checkbox in System Settings
- If disabled, avoid share UI render
- Share APIs return None (non-obstructing) if share APIs are invoked

* feat: Settings checkbox must toggle share permission globally

- Treat feature like a perm toggler. Essentially noone is allowed to explicity share anything
- Implicit sharing via `ignore_share_permissions` is allowed. Devs can decide where sharing should happen under the hood
- UI is made read only and not hidden. Users must see who doc is already shared with
- Make sure perm APIs used by share feature return false if sharing is disabled
- Rename checkbox to `Disable Document Sharing`

* test: (server side) Impact of disabling sharing on APIs

- Also, fix missed system setting rename in `assign_to`

* fix: Inform assigner if assignee lacks perms and sharing is disabled

- misc: readable conditions

* fix: throw instead of msgprint

* fix: Typo and appropriate message for `throw`

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-03-28 18:13:37 +05:30
Shariq Ansari
ba99f74660 fix: handle image extraction while editing comment 2023-03-16 16:00:06 +05:30
Deepesh Garg
d0cc2043c9
fix: String formatting index in error message (#19977) 2023-02-10 22:26:44 +05:30
Ritwik Puri
47edc63170
fix: support for different delimiter for timeline email linking (#19751) 2023-02-03 11:47:38 +05:30
Raffael Meyer
e82046ef00
ci: bump isort to 5.12.0 (#19836)
* ci: bump isort to 5.12.0

* style: remove trailing whitespace
2023-01-30 15:11:55 +05:30
morehardik
d3d76865f7
fix: check permission before running onload hook #11774 (#19823)
Added fix for issue wherein Document is loaded post permission check
2023-01-29 03:01:29 +05:30
Sagar Vora
0fd3c5a0f0
perf(DX): use cached Meta to create FormMeta (#19736) 2023-01-25 11:56:11 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
be7fd7a58d fix: point to custom field link instead 2023-01-24 12:41:05 +05:30
Ankush Menat
30e9fc4cb6 chore: remove unnessary todo comment 2023-01-23 20:05:28 +05:30
Ankush Menat
391edba10a fix(UX): better error message for dead link fields
Link fields referring to non-existing doctypes are possible when

- Removing customizations.
- Removing app which added a custom field but didn't clean up after
  itself.

[skip ci]
2023-01-23 16:43:57 +05:30
Raffael Meyer
ed30a6d59f
refactor(minor): use DocStatus (#19545) 2023-01-10 17:38:11 +05:30
Shariq Ansari
da6809ec09
revert: checking if user has permission to meta (#19485) 2023-01-05 13:47:14 +05:30
Ankush Menat
025906840d
perf: remove order_by from linked_with checks (#19229) 2022-12-12 15:39:46 +05:30
Ankush Menat
39faf34ba4
fix: ignore empty/None scripts (#19111) 2022-12-05 13:32:45 +05:30
Sagar Vora
b1703117fc
chore: remove unused whitelisting from API (#19000) 2022-11-25 11:59:04 +05:30
Aradhya
3759e5bbcd refactor: lint
fix: removed time.sleep
2022-11-12 20:06:17 +05:30
Aradhya
b33efdc634 refactor: moved is_submittable validation from save to submission queue 2022-10-11 17:16:07 +05:30
Aradhya
eff6c4fc5d fix: checking if doc is submittable before queueing 2022-10-08 17:38:12 +05:30
Aradhya
d8ff47aac2 fix: checking and unlocking the correct doc 2022-10-08 04:50:09 +05:30
phot0n
c790ad51a3 fix(minor): only queue in background for submit action 2022-10-07 16:24:01 +05:30
phot0n
cb796a4e64 refactor(minor): better notification
* changed completed_at fieldname to ended_at (in submission queue doctype)
* added rollback on exception in queue_in_background method
2022-10-06 13:06:03 +05:30
Aradhya
4bdffe73dd refactor: moved background submit to Submission Queue DocType
Co-authored-by: phot0n ritwikpuri5678@gmail.com
2022-10-04 23:06:46 +05:30
Aradhya
198bc39085 refactor: moved submission from document class 2022-10-04 17:20:14 +05:30
Aradhya
eae73ae5d4 feat: log reports for queued submits 2022-10-03 17:36:33 +05:30
Aradhya Tripathi
b787a49428
refactor: removed excess checks
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-10-03 13:46:06 +05:30
Aradhya
8b1a01e4b7 refactor: changed field name & removed queueing from save 2022-09-30 19:25:06 +05:30
Aradhya
7ed111aff7 Merge branch 'bg-submissions' of https://github.com/Aradhya-Tripathi/frappe into bg-submissions 2022-09-28 19:00:47 +05:30
Ankush Menat
967cc26fab feat: capture custom values in frappe monitor
lets monitor add extra info for:
- Save/Submit by doctype
- Report generation time by standard report name
2022-09-25 15:07:30 +05:30
Aradhya
f62d1540cf feat: Background submissions for submittable doctypes 2022-09-24 14:00:55 +05:30
Ankush Menat
2b6fc68088
Revert "fix: drop Meta cache during update" (#18186)
* Revert "fix: drop Meta cache during update (#18182)"

This reverts commit 656f6df257.

* fix: replace meta cache keys

Old keys stored different types of data `dict` changing key to indicate
change in type.
2022-09-19 21:28:45 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly (#18165)
* perf: cache `FormMeta` directly

* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
2022-09-19 16:10:32 +05:30
Sagar Vora
627302d851
fix: set doctype and name in docinfo (#18088) 2022-09-12 14:18:20 +05:30
Ankush Menat
62d65aa843 perf: drop useless indexes from view log 2022-09-09 17:34:46 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30
Ankush Menat
3e2d2a703a test: Use FrappeTestCase everywhere 2022-08-17 16:39:42 +05:30
Sagar Vora
183f60232c perf: specify reference doctype in filters 2022-08-02 06:15:00 +05:30
Sagar Vora
fac7460fb8
chore: remove duplicate field in get_version (#17674) 2022-07-29 15:10:01 +05:30
Ankush Menat
615f0dbcb8 Revert "refactor: desk missing doc handling"
This reverts commit d11fdc3ca4.
2022-07-22 19:24:34 +05:30