Commit graph

49001 commits

Author SHA1 Message Date
Ejaaz Khan
173fe402a6 chore: update datatable version 2025-03-07 17:33:01 +05:30
Shariq Ansari
57d6fba3e7
Merge pull request #31544 from shariquerik/autoname-title-same
fix: do not allow renaming if autoname & title_field is same
2025-03-07 17:13:16 +05:30
Ankush Menat
f8dee98a33
fix: override sanitized column name (#31576) 2025-03-07 15:29:00 +05:30
Akhil Narang
277c5d6ad4
Merge pull request #31522 from akhilnarang/opt-out-host-override
fix(get_url): allow disabling host header override
2025-03-07 13:27:44 +05:30
Ankush Menat
77852fd11f
fix: search instead of match (#31557)
Match isn't correct usage here
2025-03-07 06:59:23 +00:00
gavin
38fd079be5
Merge pull request #31296 from hyaray/patch-10
fix: Translate {doctype} in realtime message for reportview.delete_items
2025-03-06 17:25:49 +01:00
hyaray
7fd0516524
fix: Translate {doctype} in realtime message for reportview.delete_items 2025-03-06 17:15:49 +01:00
gavin
dab863db2c
Merge pull request #31514 from marination/isolated-headlines-v2
fix: Faulty HTML tag check condition in `show_message`
2025-03-06 17:08:21 +01:00
gavin
4a9915c70f
Merge pull request #31410 from gavindsouza/oauth-on_session_creation
fix: Run on_session_creation on OAuth logins
2025-03-06 15:45:18 +01:00
Ejaaz Khan
9400dd0c75
Merge pull request #31062 from aerele/exported-report-name
fix: set report name as pdf name
2025-03-06 16:48:27 +05:30
marination
90c98e488e fix: Use is_html instead of regex
- This util can be a single point of improvement in the future
2025-03-06 11:34:42 +01:00
Suhail
b8ee712cc5
feat: add login via fc button in login page (#31541)
* refactor: show login with frappe cloud button in login page

instead of throwing the user to site-login page, show them all the options

* fix: use is_frappecloud method to check if site is on fc

since `is_fc_site` checks if the user is a system manager and a guest user is not one

* refactor: use a better fc logo

also show login with fc button only for users coming from new signup flow (for now)

* fix: logo alignment with text
2025-03-06 06:59:22 +00:00
Ankush Menat
b95d741ffe
fix(DX): Limit cprofiler output to 200 lines (#31538)
Most of the time, first 100 lines are all you need, so 200 should be
more than enough.
2025-03-06 06:42:40 +00:00
Akhil Narang
a61c62aa07
Merge pull request #31526 from akhilnarang/fixup-blacklisted-function-check
fix: check properly for blacklisted function usage
2025-03-06 11:49:23 +05:30
Shariq Ansari
7fac10a1c1 fix: if autoname is same as title then show only one field in rename modal 2025-03-06 11:47:12 +05:30
Akhil Narang
1dc499e768
Merge pull request #31531 from akhilnarang/fix-awesomebar-xss
fix(awesomebar): sanitise text when searching in list views
2025-03-06 11:46:38 +05:30
Shariq Ansari
de265e9415 fix: do not allow renaming if autoname & title_field is same 2025-03-06 11:46:03 +05:30
Akhil Narang
1d2a0a1269
fix(awesomebar): sanitise text when searching in list views
`<img src=x onerror=alert('XSS')//` would work otherwise

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-05 18:17:25 +05:30
Gavin D'souza
bc81e340c7
fix: Move on_session_creation hook after session is created 2025-03-05 11:27:21 +01:00
ruthra kumar
fba36d57e5
Merge pull request #31178 from ruthra-kumar/analytics_on_prepared_reports
feat: Analytics on prepared reports
2025-03-05 15:37:47 +05:30
Akhil Narang
3c01bf3d5c
fix: check properly for blacklisted function usage
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-05 14:17:39 +05:30
Ankush Menat
6ea1d2c7cb
Merge pull request #31489 from ankush/backpressure
fix: Implement backpressure for background jobs
2025-03-05 11:18:39 +05:30
Ankush Menat
35667e758d fix: Implement backpressure for background jobs 2025-03-05 10:59:00 +05:30
Ankush Menat
de2e0e6b5f fix: CSS Styles of health report heatmap 2025-03-05 09:54:21 +05:30
Sagar Vora
de3dd1ce8e
Merge pull request #31516 from sagarvora/sumbitted
chore: fix typo in new `DocStatus` constant
2025-03-05 08:39:20 +05:30
Sagar Vora
146d50e5d4 chore: fix typo in new DocStatus constant 2025-03-05 08:29:47 +05:30
Sagar Vora
387dcebde1
fix: dont accept filters in role_query (#31408) 2025-03-05 06:43:07 +05:30
Frappe PR Bot
5c5978f33a
chore: update POT file (#31467) 2025-03-05 01:27:28 +01:00
Frappe PR Bot
cf94784529
fix: sync translations from crowdin (#31385)
* fix: Swedish translations

* fix: Bosnian translations

* fix: Swedish translations

* fix: Bosnian translations

* fix: French translations

* fix: Spanish translations

* fix: Arabic translations

* fix: German translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Hungarian translations

* fix: Chinese Simplified translations

* fix: Polish translations

* fix: Russian translations

* fix: Esperanto translations

* fix: Swedish translations

* fix: Bosnian translations

* fix: Swedish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Bosnian translations

* fix: Chinese Simplified translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Swedish translations

* fix: Bosnian translations

* fix: French translations

* fix: Turkish translations
2025-03-05 00:49:37 +01:00
gavin
49fe1cd3cc
fix(UX): Show reason for read only form in headline (#31511)
Alt fix for alert added via https://github.com/frappe/frappe/pull/20077
which looks like an error message and is confusing to new users.
2025-03-05 00:36:28 +01:00
marination
c4a1cad0f8 fix: Faulty HTML tag check condition in show_message
- This faultily excluded cases where the first character is not "<" but "\n\t<div>.."
- In those cases such  html strings were wrongly assumed to not contain tags and were stringified into a div
- This broke the rendering of html type headlines
2025-03-04 21:19:16 +01:00
Soham Kulkarni
c5b0363a43
Merge pull request #31512 from sokumon/translate-report-data
fix: correct data while exporting with translate values
2025-03-05 01:37:44 +05:30
sokumon
992651153d fix: correct data while exporting with translate values 2025-03-05 00:29:42 +05:30
Akhil Narang
a06b1756d7
Merge pull request #31495 from frappe/dependabot/github_actions/actions/download-artifact-4.1.9
chore(deps): bump actions/download-artifact from 4.1.8 to 4.1.9
2025-03-04 19:09:42 +05:30
Akhil Narang
0e80963c8c
Merge pull request #31267 from nabinhait/default-outgoing-email-account
fix: Clearer message for setting default outgoing email account
2025-03-04 18:45:44 +05:30
Soham Kulkarni
f423f8bd66
Merge pull request #31469 from sokumon/translate-report-data
feat: translate report data
2025-03-04 16:22:59 +05:30
Akhil Narang
627b8e04f5
fix(get_url): allow disabling host header override
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-04 15:13:10 +05:30
sokumon
a601f9daa5 fix: use total_row flag to check 2025-03-04 14:27:35 +05:30
sokumon
faf0d42e03 fix: handle total row properly while translating 2025-03-04 14:07:08 +05:30
sokumon
aaa456c2ab fix: only translate strings 2025-03-04 12:06:43 +05:30
Akhil Narang
7cf7bf686f
Merge pull request #31381 from barredterra/report-filters-from-route-options
feat: set report filters from route options
2025-03-04 10:35:21 +05:30
Akhil Narang
2cc0ee2755
fix(data_import): sanitize preview data and filename (#31483)
* fix(import_preview): sanitize preview data

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix(attach): sanitise filename before display

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-04 10:32:51 +05:30
dependabot[bot]
2482c0f160
chore(deps): bump actions/download-artifact from 4.1.8 to 4.1.9
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v4.1.8...v4.1.9)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-03 18:22:19 +00:00
Suhail
5886234b53
refactor: sign up flow changes (#31205)
* fix: logout to site login page if the site is on Frappe Cloud

* fix: check if the site user is logged in before rendering trial banner

* fix: show dropdown even if the site is not on trial plan

* refactor: don't expose communication secret in boot

* feat: show install app button for fc sites

* fix: remove auth from desk

we can simplify it and let user do auth in fc

* fix: install app button condition

* refactor: use `is_fc_site` method

* fix: return boolean value for `is_fc_site` function

* fix: add install app button in /apps page

* fix: don't generate otp for login to fc

* fix: remove install app option from desk

* fix: design changes for trial banner

* fix: add more details to the `current_site_info` endpoint

also don't render trial banner if trial end date is passed

* fix: don't route user to welcome page

always put them on the site's dashboard

* fix: override base_url when needed

also remove misleading class

* fix: show banner to normal user to contact system admin for plan upgrade

* refactor: redirect from /login instead of every /logout code

* fix: rename login to fc to manage billing

also move it above the divider

* refactor: separate out site-login url from login.py
2025-03-03 16:36:15 +00:00
Marica
2022ddf407
refactor: Allow isolated headlines/intros in the form (#31459)
* refactor: Allow isolated headlines/intros in the form

- Each attempt to `show_message` should be rendered as a separate block with its own color and close button
- When grouped together the point of passing individual colors is lost
- The grouping behaviour also seemed implicit.
- An independently set headline could never stand out and the message is lost when grouped with another headline

* fix: Pull docstring out + avoid deprecated "substr" + Border Bottom

* chore: Add color options for color param in `show_message` docstring

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2025-03-03 17:34:43 +01:00
sokumon
c17311fbb0 fix: translate total word 2025-03-03 19:43:45 +05:30
sokumon
299d7bfccb fix: simplify function and better naming 2025-03-03 18:54:03 +05:30
Ejaaz Khan
4db9afce8a
Merge pull request #31486 from iamejaaz/custom-print-error
fix: template error on custom print format
2025-03-03 17:50:08 +05:30
Ejaaz Khan
3f9cb89611 fix: template error on custom print format 2025-03-03 17:34:47 +05:30
Ankush Menat
136098e5d6
fix: Avoid setting prepared reports for errors (#31484) 2025-03-03 12:02:36 +00:00