Commit graph

41137 commits

Author SHA1 Message Date
Ankush Menat
3f1deeba67
fix: can't sign out due to missing roles (#19905) 2023-02-02 22:53:24 +05:30
Ankush Menat
07529ff1c3
fix: Consider parenttype when renaming (#19901) 2023-02-02 17:05:44 +05:30
Suraj Shetty
9598beb0c9
Merge pull request #19853 from gavindsouza/perf-list-update 2023-02-02 14:52:14 +05:30
Ritwik Puri
73078e89ba
Merge pull request #19888 from ankush/drop_tables
fix: drop table if exists for action and links
2023-02-01 22:55:40 +05:30
Ankush Menat
dad0e5cbba fix: drop table if exists for action and links
closes https://github.com/frappe/frappe/issues/19712
2023-02-01 22:37:43 +05:30
Ritwik Puri
dd1cac0acc
Merge pull request #19885 from phot0n/fix-email-queue-sender
fix: use sender from formatted email body for email queue
2023-02-01 22:02:18 +05:30
phot0n
a0d1d1bd0e test: fix test_unsubscribe 2023-02-01 21:37:23 +05:30
phot0n
5236aeb4b0 test: email queue sender with always_use_account_name_as_sender_name and always_use_account_email_id_as_sender 2023-02-01 20:18:51 +05:30
Gavin D'souza
cc7141edfe fix: Use debounce to process_document_refreshes
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-02-01 19:09:01 +05:30
phot0n
f8d7151e19 fix: use sender from formatted email body for email queue 2023-02-01 17:08:25 +05:30
Gavin D'souza
ccb7c8cd80 fix(desk): Filter out other doctypes on list_update event 2023-02-01 17:05:01 +05:30
Gavin D'souza
419503ec06 Merge branch 'develop' into perf-list-update 2023-02-01 16:56:34 +05:30
Shariq Ansari
0f6f599c55
Merge pull request #19871 from developsessions/fix_possible_none_value 2023-02-01 16:40:10 +05:30
Suraj Shetty
99756dbb59
Merge pull request #19533 from gavindsouza/permlevel-apis 2023-02-01 16:24:34 +05:30
Ankush Menat
1b016d34bd
fix: misc migration related fixes (#19874)
* fix: ignore certain validations during migrate

These are recoverable after migration is completed, better to let update
go through first.

* fix: Let people set arbitrary Data field options

It will be treated as vanilla Data field by default but other apps can
chose to modify behaviour based on it.

AFAIK there is no real side effects of this.
2023-02-01 16:02:59 +05:30
Shariq Ansari
1dab286bd8
Merge branch 'develop' into fix_possible_none_value 2023-02-01 15:50:03 +05:30
Shariq Ansari
dbefead489
Merge pull request #19878 from frappe/mergify/bp/develop/pr-19869 2023-02-01 15:45:10 +05:30
sameer Chauhan
967ea894d9 fix: translations update in MutliSelectDialog
fix: translations update in MutliSelectDialog in the title field
(cherry picked from commit 88c77edc0d33c29e2eadbb6dabab83ba46d27774)
2023-02-01 10:12:17 +00:00
gavin
9d10028a35
Merge branch 'develop' into permlevel-apis 2023-02-01 14:59:30 +05:30
developsessions
bcbcc87f4b fix: possible none value evaluation in get_formatted function 2023-02-01 09:24:42 +01:00
Ankush Menat
9d97097c12
fix: dont apply varchar length validation on singles (#19872)
closes https://github.com/frappe/frappe/issues/19833

[skip ci]
2023-02-01 10:22:50 +05:30
Ankush Menat
4ca23dd5fa
fix: Dont setup socketio events on new doc (#19864) 2023-01-31 18:52:13 +05:30
Ankush Menat
b8ba7dcdb3
fix: Setting default print format (#19862)
- Remove check for developer mode, it's not even valid as we dont allow
  setting default print format like this
- Set in custom doctype if custom doctype else prop setter.
- query meta instead of doctype.

[skip ci]
2023-01-31 17:52:35 +05:30
Gavin D'souza
7ce0c4c8b3 Merge branch 'develop' into permlevel-apis 2023-01-31 17:47:59 +05:30
Samuel Danieli
4d08f50a03
fix: PermissionError (#19856)
* fix: PermissionError

* fix: check perm on customize form

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-31 16:04:40 +05:30
Ankush Menat
1fd74e9472 chore: switch base doctype
This is a dummy doctype and doesn't actually affect anything but needs
to have "report" perm.

[skip ci]
2023-01-31 14:54:41 +05:30
gavin
7f34d510f2
fix(db_query): Allow link field to have 'tab' (#19820)
* fix(db_query): Allow link field to have 'tab'

Issue: Occurence of tab was used to check if the selected field is a table name
and not a fieldname. This caused DocTypes with fields like `tablets` or
`table_name` to break List Views.

Change: Check if the field exists in meta to be sure that the selectable
is a field.

* fix: Split once to ensure at most 2 args
2023-01-31 14:43:26 +05:30
Gavin D'souza
636c4701cf perf: Batched List Updates
* Perform batched list updates for a N documents made every second
* list_update callbacks for doc refreshes maintained in cur_list.pending_document_refreshes
2023-01-31 13:26:07 +05:30
Ankush Menat
b3b846472e test: clear defaults after test 2023-01-31 12:35:43 +05:30
Ankush Menat
45280d4801
fix: website theme caching (#19848) 2023-01-31 11:25:14 +05:30
Ritwik Puri
d3a3381af1
Merge pull request #19651 from barredterra/test_address_template
refactor: address template
2023-01-30 18:29:23 +05:30
Ankush Menat
338ccc5a2a
fix: sanitize form dict in error logs (#19835)
[skip ci]
2023-01-30 15:22:21 +05:30
Raffael Meyer
e82046ef00
ci: bump isort to 5.12.0 (#19836)
* ci: bump isort to 5.12.0

* style: remove trailing whitespace
2023-01-30 15:11:55 +05:30
RJPvT
8be98718f7
fix: ldap with 2fa (#19753)
Because we pop password 2fa fails when used with ldap

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-30 14:44:53 +05:30
Leonard Goertz
3e20e7df25
fix: add brackets for docshare or condition (#19650)
Co-authored-by: Leonard Goertz <leonard.goertz@noventive.com>
2023-01-30 14:14:11 +05:30
Ankush Menat
1eab4e4253
fix: Convert doctype name to string (#19832) 2023-01-30 14:11:38 +05:30
Shariq Ansari
9f45406fe8
Merge pull request #19798 from dj12djdjs/fix-grid-search 2023-01-30 13:07:52 +05:30
Shariq Ansari
443f97f827 Merge branch 'develop' into fix-grid-search 2023-01-30 12:49:59 +05:30
Shariq Ansari
e4f818b838 fix: remove row if search_row is not implemented 2023-01-30 12:41:46 +05:30
Ankush Menat
e9d64d4ec0
Merge pull request #19588 from marination/report-sidebar-respect-perm-query
fix: Report sidebar must consider Permission Query
2023-01-30 12:10:38 +05:30
Sabu Siyad
1e115e5e50
chore!: Remove translation tool (page) (#19786)
* refactor(page): remove translation tool files

* refactor(patches): remove translation tool page
2023-01-30 12:09:05 +05:30
Ankush Menat
13162d8fbd fix: Only apply perm query to non-admin users 2023-01-30 11:24:16 +05:30
Marica
57c991f055
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-30 11:12:38 +05:30
marination
1e4d28cc19 fix(test): Remove try-finally & ignore perms on test user's report insertion 2023-01-30 11:08:14 +05:30
Türker Tunalı
e18188ed3e
fix(i18n): Datepicker Turkish translations (#19777)
* feat:Datepicker Turkish translations are added.

* chore: format

[skip ci]

---------
2023-01-30 09:38:35 +05:30
Raffael Meyer
0df4bd27fb
Merge branch 'develop' into test_address_template 2023-01-29 19:34:13 +01:00
Ankush Menat
87008e3930
Merge pull request #19780 from ankush/hooks_audit
feat: Audit hooks report
2023-01-29 20:14:32 +05:30
Ankush Menat
80dcf0b178 feat: Split dict hooks to separate lines 2023-01-29 20:09:45 +05:30
Ankush Menat
4d08a989f5 feat: Audit hooks report 2023-01-29 19:58:34 +05:30
morehardik
d3d76865f7
fix: check permission before running onload hook #11774 (#19823)
Added fix for issue wherein Document is loaded post permission check
2023-01-29 03:01:29 +05:30