Commit graph

38738 commits

Author SHA1 Message Date
Suraj Shetty
4b6ab45c57 refactor: Replace fluxify with vuex
Reason:
fluxify has GPL2 licence which is incompatible with MIT hence using vuex which is a similar library and has MIT license.
2022-07-05 19:45:17 +05:30
Ankush Menat
18af7da807 fix: missing add/remove field button on listview settings
closes https://github.com/frappe/frappe/issues/16783
2022-07-05 18:38:32 +05:30
Ankush Menat
5d2aedc698 fix(postgres): end transaction before DDL
closes https://github.com/frappe/frappe/issues/17210
2022-07-05 17:43:02 +05:30
Ankush Menat
93c2cb757f
Merge pull request #17414 from ankush/url_enhancements
fix: misc url/routing fixes
2022-07-05 17:07:07 +05:30
Ankush Menat
70fbab828c fix: do not update URL on saved reports
"Saved reports" imply that they have already stored filters, columns
etc. Applying URL from filters doesn't make sense here.
2022-07-05 16:45:51 +05:30
Ankush Menat
39c5d0d454 fix: only update URL if active list is still same
If you rapidly move from a list view while it was being refreshed then
changed URL is applied on a page that MIGHT not be the list/report view.

This check ensures that same page is present before updating URL.
2022-07-05 16:35:49 +05:30
Ankush Menat
261fbfcd11
Revert "fix(doc)!: Always cast datetime, date and time fields"
Revert "fix(doc)!: Always cast datetime, date and time fields (#15891)"

This reverts commit d7789ab6ff.
2022-07-05 13:43:32 +05:30
Himanshu
d7789ab6ff
fix(doc)!: Always cast datetime, date and time fields (#15891)
### BREAKING CHANGE
#### Datetime, Date and Time fields will always be cast to respective objects in `setattr`, this will ensure uniformity while accessing the values, no more `getdate`, `get_datetime`, `to_timedelta` wrapper.
- While importing data, the framework does check for `set_only_once`.
- In normal case scenarios, this will work flawlessly since most date fields might not be set_only_once.
- But in Subscription, the date field is set to `set_only_once` and in `after_insert`, `document.save` is called, and while doing so, `set_only_once` is checked [here](1944a547f9/frappe/model/document.py (L566)).
-This works fine if the data imported is in the correct format.
- If the date's data is not in the correct format, the framework throws an error.
- for eg `06-02-2022 00:00:00 != 06-02-2022`
- fixes [Issue/#15370](https://github.com/frappe/frappe/issues/15370)

> no-docs
2022-07-05 07:07:16 +00:00
Ankush Menat
9a03c53572
Merge pull request #17405 from ankush/feat/currency_symbol_loc
feat: configurable location of currency symbol
2022-07-05 11:22:02 +05:30
Ankush Menat
054ad9c30c feat: Allow showing currency symbol to the right 2022-07-05 11:21:23 +05:30
mergify[bot]
fa3f72fef4
Merge pull request #17289 from surajshetty3416/cleanup-libs
chore: Remove unused libraries/files and update licenses
2022-07-05 05:17:14 +00:00
gavin
93ef06f233
Merge pull request #17388 from gavindsouza/ci-mariadb-10_6
ci: Bump mariadb from 10.3 to 10.6
2022-07-05 09:51:02 +05:30
Ankush Menat
faf0d15c51 refactor: load country and currency info in boot
Previously this was done in ERPNext but all currency formatting
functionality depends on this, hence moved to framework. Largely
rewritten from scratch.
2022-07-04 20:29:38 +05:30
Gavin D'souza
db53813a68 ci(install): Set mariadb root password via envvar
ref: https://github.com/frappe/frappe/runs/7175643618
2022-07-04 20:21:28 +05:30
Raffael Meyer
f4fa4d303f
fix: "You viewed/edited/created this" (#17365)
### Issues
In the form timeline we show events like “{user} {created/viewed/edited} this {some_time_ago}”. If user is the current user, we used “You” instead of “Jon Doe”. This works in English, but in other languages it messes up the rest of the sentence.

Because of this, people added wrong translations of “You” that made the grammar work, but also made the message less clear.

Also, the _last viewed_ message used to link to **View Log**. That can be read by system managers only and doesn't hold additional information. So it's just a source of errors for users trying to click on it.

### Fixes

- don't mix up users and salutations. Always show user's full name.
- change the _last viewed_ message to work like the other two, remove link to **View Log**

### Demo

Logged an as Administrator:

English

![Bildschirmfoto 2022-06-30 um 15 28 37](https://user-images.githubusercontent.com/14891507/176689772-dd878c90-4a2c-4a32-aa6c-d2e14a6340e1.png)

German

![Bildschirmfoto 2022-06-30 um 15 28 03](https://user-images.githubusercontent.com/14891507/176689812-ce13bb31-6c70-40f2-8699-6fb0db1d06f9.png)
2022-07-04 14:03:31 +00:00
Ankush Menat
9a5d11234c
fix: validate scheduler, hook method names (#17400)
* chore: warn about missing scheduler / doc events

* fix: pass list instead of filter

filter can only be iterated upon once

* refactor: many typehints in __init__.py
2022-07-04 19:29:16 +05:30
mergify[bot]
3d9e3b9ba2
Merge pull request #17383 from hrwX/reset_tree
fix: refresh tree when the treeview is  loaded
2022-07-04 13:40:29 +00:00
Himanshu
205663c09c
Merge branch 'develop' into reset_tree 2022-07-04 18:43:57 +05:30
Suraj Shetty
a24af60f03 chore: Update attributions.md 2022-07-04 17:15:56 +05:30
Suraj Shetty
74312c07f4 chore: Add Inter LICENSE.txt 2022-07-04 17:10:23 +05:30
Suraj Shetty
f8013cb1fa chore: Remove unused glyphicons 2022-07-04 17:03:37 +05:30
Ankush Menat
87f77d4e8d
fix: make language, source, translation mandatory (#17396)
Translation doesn't make sense without these three fields
2022-07-04 16:46:06 +05:30
Ankush Menat
4e6ea5b554
fix: handle None as amount in fmt_money (#17395) 2022-07-04 16:27:57 +05:30
Suraj Shetty
b406e29242 fix(realtime): Use socketio_port set in config 2022-07-04 15:08:53 +05:30
Suraj Shetty
81436dc688 fix: Remove unused function and listener 2022-07-04 14:59:26 +05:30
Suraj Shetty
bdc90a2938
Merge pull request #17390 from surajshetty3416/fix-bulk-edit-check 2022-07-04 14:06:30 +05:30
Ankush Menat
60c4819373
refactor: safer binding of outer scope in closures (#17389) 2022-07-04 13:39:56 +05:30
Suraj Shetty
862d4625be fix: Retain value in the field instance when field is rendered on a dialog w/o doc 2022-07-04 13:19:55 +05:30
Gavin D'souza
858735dfa9 ci(install): Use mariadb 10.6 client 2022-07-04 12:33:29 +05:30
Gavin D'souza
65c6914068 ci: Bump mariadb from 10.3 to 10.6 2022-07-04 12:33:29 +05:30
Ankush Menat
234c8beed6
ci: faster patch test (#17386)
* ci: slightly faster patch test

This workflow doesn't seem to properly cache built versions :)

* ci: bump pyenv action to latest version

latest version has fix for tool cache


[skip ci]
2022-07-04 12:09:03 +05:30
Ankush Menat
06ce1f33ec refactor: remove unnecessary exception handling 2022-07-04 11:59:54 +05:30
Ankush Menat
567333f91c
Merge pull request #17384 from phot0n/fix-ci-has-label
ci: use different reference for fetched label in has_label
2022-07-04 11:49:50 +05:30
Ankush Menat
0fc2681a09
Merge pull request #17385 from ankush/duplicate_tracebacks
fix: remove duplicate tracebacks
2022-07-04 11:48:13 +05:30
Suraj Shetty
165a0a408f chore: Add licenses to leaflet libraries 2022-07-04 11:38:06 +05:30
Ankush Menat
c12b52a259 refactor: use frappe.get_system_settings
Not sure why this needs YET ANOTHER separate cache.
2022-07-04 11:25:47 +05:30
Ankush Menat
e9a9496ebc fix: duplicate tracebacks in console 2022-07-04 11:25:47 +05:30
Suraj Shetty
cd2aeffce7
Merge branch 'develop' into cleanup-libs 2022-07-04 10:05:43 +05:30
Suraj Shetty
728ff49cec refactor: Get sortable js from node_modules instead of vendoring it
- No point in having a copy since there are no customization done.
2022-07-04 09:17:20 +05:30
Suraj Shetty
8355ca81e0 fix: Add missing licences for vendored library 2022-07-04 08:29:56 +05:30
Suraj Shetty
58d79720c6 chore: Remove unused libraries and files 2022-07-04 08:25:51 +05:30
phot0n
b0cea224c8 ci: consider svg as docs as well 2022-07-03 21:03:44 +05:30
phot0n
6e818caa59 ci: use different reference for fetched label in has_label 2022-07-03 16:41:37 +05:30
hrwx
fb0bc3bdcd fix: refresh tree when the treeview is loaded 2022-07-03 00:48:09 +01:00
Ankush Menat
cc15cc73eb chore: delete old conf files
We dont use pylint and it's not even valid pylint config.

[skip ci]
2022-07-01 18:16:34 +05:30
Suraj Shetty
f3ad2ee6ac chore: Remove unused less files 2022-07-01 18:14:06 +05:30
Suraj Shetty
2ea0b58873 fix: Allow all origins with credentials 2022-07-01 17:54:50 +05:30
mergify[bot]
6924f3e243
Merge pull request #17372 from nihantra/calendar_view_assign
fix: calendar view set in assign time
2022-07-01 09:33:00 +00:00
Nihantra C. Patel
3287bce213
fix: calendar view set in assign time 2022-07-01 13:46:33 +05:30
Ankush Menat
d614bad667
ci: force modern python with pyupgrade (#17370)
also add previous bulk change to git-blame-ignore-revs
2022-07-01 12:09:27 +05:30