vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
40939 commits 1 branch 0 tags 587 MiB
Commit graph

40939 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gavin D'souza
550261b3dc fix(db_query): Set & use existing constants 2023-01-24 13:01:05 +05:30
Gavin D'souza
acb0dc38ae fix: Check if attr exists before checking permlevel 2023-01-24 12:17:57 +05:30
Gavin D'souza
9efe84a644 fix(reportview): Remove aggregate_on_field added in fields 
Essentially reverts changes added via
https://github.com/frappe/frappe/pull/14424 but works just the same
without the additional column :thonk:

The added column's data in mariadb was essentially garbage data. Wasn't
meaningful from what I could tell - couldn't play well with postgres
either
 2023-01-20 19:26:56 +05:30
gavin
4be74bc013
Merge branch 'develop' into permlevel-apis 2023-01-19 11:00:15 +05:30
Ankush Menat
fa55793a52
Merge pull request #19405 from netchampfaris/refactor-qb-engine 
refactor: qb.engine
 2023-01-18 21:17:17 +05:30
Ankush Menat
fb2c6a5573
Merge pull request #19653 from ankush/modify_installed_orderig 
feat: let users modify hook resolution order
 2023-01-18 21:01:25 +05:30
Ankush Menat
c14379ce5c fix: log changes made to installed_apps order 2023-01-18 19:16:09 +05:30
Ankush Menat
1796cae6bf feat: let users modify hook resolution order 
Since hook resolution depends on the order in which apps were installed
on site, it should be made configurable as escape hatch in case a
different resolution order is desired.

Keep in mind that changing order affects every hook, page, customization
so you can't pick and choose priority for individual hooks as of now.

Separate proposals are welcome for such configurabilty.
 2023-01-18 18:45:33 +05:30
Shariq Ansari
555b88ffd9
Merge pull request #19642 from shariquerik/update-profile-redirect-fix 
Fixes https://github.com/frappe/frappe/issues/19377
 2023-01-18 11:25:26 +05:30
Shariq Ansari
1b4b6cce15 fix: Edit Profile link is not redirecting correctly 2023-01-18 10:30:40 +05:30
Ankush Menat
e31db5d502
fix: handle tel: links in emails (#19635) 2023-01-17 20:31:06 +05:30
Suraj Shetty
f9496ff7e5
fix: Initialize "r" to avoid UnboundLocalError (#19630) 
fixes https://github.com/frappe/frappe/issues/19608
 2023-01-17 18:29:07 +05:30
Suraj Shetty
bc13f909fb
fix: Argument name should be letterhead instead of letter_head (#19627) 
fixes https://github.com/frappe/frappe/issues/19515
 2023-01-17 18:10:23 +05:30
Shariq Ansari
72119d44b4
Merge pull request #19624 from shariquerik/number-card-fix 
Fixes https://github.com/frappe/frappe/issues/17209
 2023-01-17 17:35:08 +05:30
Shariq Ansari
52da1a8e4c
Merge branch 'develop' into number-card-fix 2023-01-17 16:49:14 +05:30
Shariq Ansari
c6c9401f06 fix: cannot add number card on dashboard 2023-01-17 16:45:49 +05:30
Suraj Shetty
551f58bde9
fix: Convert extension to lowercase before comparison 2023-01-17 16:32:44 +05:30
Ritwik Puri
6b1e98e0d6
chore: reorder disable_email_accounts_with_oauth to post model sync (#19620) 2023-01-17 14:19:33 +05:30
Faris Ansari
ee17b22110 fix: only replace "tab" at the beginning 2023-01-17 14:04:31 +05:30
Ankush Menat
4bb5b10c7f
fix(DX): better error msg for non-whitelisted methods (#19616) 
[skip ci]
 2023-01-17 12:06:39 +05:30
Ritwik Puri
647ac83abf
chore(patch): send notification to system managers for resetup of oauth enabled email accounts (#19610) 2023-01-17 11:44:04 +05:30
Ankush Menat
53f8154907
chore(flake8): ignore B028 (#19612) 
[skip ci]
 2023-01-17 10:55:54 +05:30
Ritwik Puri
75ae0fa248
chore: remove unnecessary query condition from get_other_system_managers (#19611) 2023-01-17 10:50:07 +05:30
Ankush Menat
433115f62d
test: rollback test transaction after executing cmd (#19606) 
In command tests if connection is active then due to repeatable read
isolation you will continue to read old data which might be modified by
the command you're trying to test.

It makes sense to end transaction after each command execution here.

[skip ci]
 2023-01-16 18:43:52 +05:30
Ankush Menat
c7edd7e57c chore: remove unnecessary assertion 2023-01-16 18:02:40 +05:30
Ankush Menat
366ba4720e
Merge pull request #17869 from resilient-tech/refactor-installed 
refactor!: deprecate sorting based on `apps.txt` in `get_installed_apps`
 2023-01-16 17:56:06 +05:30
Ankush Menat
8adfdcbc1d tests: clear DB transactions before all db calls 
Because of repeatable read isolation,
changes from externally executed command dont reflect until transaction is ended.
 2023-01-16 17:32:29 +05:30
Deepesh Garg
0f5d17663d
fix: Remove setup wizard user image (#19601) 2023-01-16 16:44:04 +05:30
Ritwik Puri
1e6086fd75
fix(minor): only show authorization message if connected app is set (#19605) 2023-01-16 16:22:38 +05:30
Faris Ansari
543458b473 fix: handle empty list as filters 2023-01-16 15:38:15 +05:30
Ritwik Puri
50327203ce
Merge pull request #18750 from revant/oauth-email 
feat: use Connected App for OAuth based Email Account
 2023-01-16 15:24:05 +05:30
gavin
d1b7a69141
Merge branch 'develop' into permlevel-apis 2023-01-16 14:54:36 +05:30
Gavin D'souza
47bcc527f3 fix: Remove logic short circuit / dont reject fields easily 2023-01-16 14:51:31 +05:30
Gavin D'souza
85d6949d04 fix: Raise PermissionError when user doesnt have access to linked table 2023-01-16 14:28:47 +05:30
Gavin D'souza
f0a282e941 test: Add test for linked table permission check 2023-01-16 14:28:13 +05:30
Faris Ansari
5bc5ff100b test: tests for various filter options 2023-01-16 14:12:04 +05:30
Faris Ansari
52e3d8d58b fix: handle empty string passed to filters 2023-01-16 14:11:37 +05:30
Gavin D'souza
7e38d7fe63 test: Make test_child_table_join more resilient 2023-01-16 13:56:37 +05:30
Gavin D'souza
0355f33b77 fix(db_query): Handle permlevel check cases clearer 
- Split to utility functions for clarity
- Add example over code blocks
- Re-arrange blocks based on priority
 2023-01-16 13:54:56 +05:30
Ankush Menat
5e2bbf834f refactor: filter out apps not installed on bench 2023-01-16 13:54:40 +05:30
Sagar Vora
f5cbcec103 fix: defer local.all_apps loading 2023-01-16 13:54:27 +05:30
Sagar Vora
d8b7bc18d7 refactor!: deprecate sorting based on apps.txt in get_installed_apps 2023-01-16 13:54:27 +05:30
phot0n
b5c81cc015 chore(patch): disable all email accounts with oauth mechanism 2023-01-16 12:56:22 +05:30
Gavin D'souza
197de99e35 refactor: Use permitted over available in variable naming 2023-01-16 11:07:56 +05:30
aissa-berrachiche
bfaadfd32d
fix: passwords are updated on every login (#19594) 
Co-authored-by: aberrachiche <aberrachiche@aas.com.sa>
 2023-01-16 11:06:05 +05:30
Shariq Ansari
701415142b
Merge pull request #19597 from shariquerik/test-form-builder-fix 2023-01-16 10:47:40 +05:30
Shariq Ansari
fae098f661
Merge pull request #19587 from shariquerik/hide-workspace-firefox-fix 2023-01-16 10:27:20 +05:30
Shariq Ansari
cd8049e569
Merge pull request #19586 from ruchamahabal/fix-fetch-if-empty 2023-01-16 10:26:42 +05:30
Shariq Ansari
8abd144de6 test: fixed failing UI test 2023-01-16 10:24:45 +05:30
Shariq Ansari
35f4f22c7d
Merge branch 'develop' into fix-fetch-if-empty 2023-01-16 09:34:50 +05:30