Commit graph

22790 commits

Author SHA1 Message Date
Suraj Shetty
7cf5dee097 test: Add assert statement for value 2019-12-14 18:27:58 +05:30
Suraj Shetty
9ce7f6c6ab fix: Typo 2019-12-11 11:32:01 +05:30
Suraj Shetty
a8b3a6b20b test: Add test to check if field is editable 2019-12-11 11:22:09 +05:30
Suraj Shetty
4f477cbc94 fix: Allow field of submitted doc to edit if field has allow_on_submit enabled 2019-12-10 10:55:36 +05:30
mergify[bot]
acc27a147a
Merge pull request #8963 from prssanna/next-doc-fix
fix: Ambiguous column error when going to next doc
2019-12-09 16:58:17 +00:00
Mangesh-Khairnar
710947c66c fix(autocomplete): parse options (#8998)
* fix(autocomplete): parse options

* fix: add ignore validation flag

* fix: minor change
2019-12-09 15:17:06 +00:00
Chinmay Pai
d169f41a54 fix(email): try to encode email part to utf-8 (#8965)
fixes issues with class objects other than str

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 281, in receive
    communication = self.insert_communication(msg, args=args)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 338, in insert_communication
    email = Email(raw)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 372, in __init__
    self.parse()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 393, in parse
    self.process_part(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 445, in process_part
    self.text_content += self.get_payload(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 489, in get_payload
    charset = self.get_charset(part)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/receive.py", line 484, in get_charset
    charset = chardet.detect(frappe.safe_encode(part))['encoding']
  File "/home/frappe/frappe-bench/env/lib/python3.6/site-packages/chardet/__init__.py", line 34, in detect
    '{0}'.format(type(byte_str)))
TypeError: Expected object of type bytes or bytearray, got: <class 'email.message.Message'>

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-09 19:25:43 +05:30
prssanna
3bd310b2e1 fix(tests): add UI test for next previous document navigation 2019-12-09 19:20:55 +05:30
mergify[bot]
34a696f397
Merge pull request #8949 from scmmishra/chart-opts-query-report
fix: query report chart options
2019-12-09 11:38:11 +00:00
mergify[bot]
75a1eb9653
Merge pull request #8994 from scmmishra/summary-details
fix: summary tag should have cursor pointer
2019-12-09 11:32:46 +00:00
mergify[bot]
499897a3c5
Merge pull request #8969 from Alchez/dev-sign-up-role
fix: add default role on sign up via SSO
2019-12-09 11:14:32 +00:00
mergify[bot]
0ec968414c
Merge pull request #8993 from saurabh6790/scheduled_job_type_frequency
fix: add hourly long frequency to scheduled job type
2019-12-09 06:14:47 +00:00
Shivam Mishra
d3fecebd83 feat: summary tag should have cursor pointer 2019-12-09 11:28:44 +05:30
Saurabh
ae418b90c5 fix: add hourly long frequency to scheduled job type 2019-12-09 11:13:45 +05:30
mergify[bot]
c63db4777a
Merge pull request #8980 from rohitwaghchaure/fixed_xml_file_not_able_to_download_develop
fix: not able to download XML file
2019-12-08 07:32:41 +00:00
mergify[bot]
a1e18f9c5b
Merge pull request #8906 from ruchamahabal/list_group_by_filter_fix
fix: list view group by filter ambiguous column name
2019-12-08 06:13:56 +00:00
mergify[bot]
923a823002
Merge pull request #8982 from Thunderbottom/password-reset-fix
fix(security): invalidate reset_password_key on password reset
2019-12-08 04:24:00 +00:00
mergify[bot]
9be88c6961
Merge pull request #8706 from hrwX/pref_global_search
fix: Missing results in global search
2019-12-08 04:18:09 +00:00
Chinmay D. Pai
35024c18fc
fix(security): invalidate reset_password_key on password reset
currently there is no way to invalidate reset_password_key on updating
password through the user settings. so whenever the user sets a new
password we'll invalidate the reset_password_key, so that existing links
to reset user passwords cannot be used.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-07 19:00:54 +05:30
Rohit Waghchaure
80f87a37fb fix: not able to download XML file 2019-12-07 12:53:04 +05:30
mergify[bot]
2743863407
Merge pull request #8977 from Thunderbottom/background-job-fix
fix: use get_status for rq job status
2019-12-06 18:01:44 +00:00
Chinmay D. Pai
196b2ad254
fix: use get_status for rq job status
job.status has been replaced with job.get_status() in the latest release (1.0)

https://github.com/rq/rq/releases/tag/v1.0

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-06 22:43:49 +05:30
rohitwaghchaure
fe78181fde
Merge pull request #8976 from rohitwaghchaure/fixed_patch_reload_doc_doc_for_v12
fix: patch
2019-12-06 18:27:22 +05:30
Rohit Waghchaure
f772e6ab22 fix: patch 2019-12-06 18:22:46 +05:30
rohitwaghchaure
0672efc2a5
Merge pull request #8975 from rohitwaghchaure/fixed_patch_reload_doc_doctype_action
fix: patch
2019-12-06 18:07:51 +05:30
Rohit Waghchaure
86ecf4fbc1 fix: patch 2019-12-06 18:06:52 +05:30
Rucha Mahabal
2d4d853888 test: list view child table filter with created by filter 2019-12-06 17:09:31 +05:30
Saurabh
a4565494d9
Merge pull request #8973 from rmehta/scheduler-log-fix
fix: scheduler log cold start
2019-12-06 16:18:21 +05:30
Rushabh Mehta
e6664bfba9 fix: scheduler log cold start 2019-12-06 16:13:10 +05:30
rohitwaghchaure
63951fb844
Merge pull request #8968 from rohitwaghchaure/fixed_patch_for_drop_column_apply_user_permissions
fix: patch
2019-12-06 15:36:12 +05:30
Rohan Bansal
8590ff0477 fix: add default role on sign up via SSO 2019-12-06 15:28:09 +05:30
Rohit Waghchaure
54e5538065 fix: patch 2019-12-06 15:18:54 +05:30
rohitwaghchaure
2411d0c527
Merge pull request #8946 from rohitwaghchaure/get_css_class_color_not_working_in_calendar
fix: Color not working in the calendar
2019-12-06 13:26:11 +05:30
mergify[bot]
ae5ba4bdaa
Merge pull request #8952 from ruchamahabal/onboarding-ui-fixes
fix: Onboarding Wizard Multiple Fixes
2019-12-06 07:14:36 +00:00
Rucha Mahabal
e07f5ffafe
fix: spacing
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
2019-12-06 12:29:09 +05:30
mergify[bot]
872d194eeb
Merge pull request #8920 from deepeshgarg007/address_fixes
fix: Default and company address fixes
2019-12-06 06:35:04 +00:00
prssanna
84d8db2dff fix: fix ambiguous column error when going to next doc 2019-12-06 11:43:02 +05:30
deepeshgarg007
b4bff1d009 fix: Remove changes in notifications 2019-12-06 09:26:32 +05:30
deepeshgarg007
59d6be6446 fix: revert changes made to get_default_address function 2019-12-06 09:21:24 +05:30
Suraj Shetty
10701738d8
fix: Convert list to tuple 2019-12-06 08:29:02 +05:30
Suraj Shetty
3b61a6cb28 fix: Code cleanup
- Pass values so that db cursor can handle escaping
2019-12-06 07:46:49 +05:30
Himanshu Warekar
c336424fa4 fix: codacy fixes 2019-12-04 23:13:43 +05:30
Himanshu Warekar
f616a7c814 Merge branch 'develop' of https://github.com/frappe/frappe into pref_global_search 2019-12-04 23:13:27 +05:30
Rucha Mahabal
65ac0f3982 fix: resume after reload broken 2019-12-04 19:30:14 +05:30
Rucha Mahabal
e1454c20ec fix: codacy fixes 2019-12-04 18:19:15 +05:30
Rucha Mahabal
0b19bc3790 refactor: simplified calls 2019-12-04 17:56:05 +05:30
Rucha Mahabal
74fe3c71f7 feat: style only onboarding wizard 2019-12-04 17:20:22 +05:30
Rucha Mahabal
a8076cfefe feat: added validation for slide with same order 2019-12-04 17:11:29 +05:30
Rucha Mahabal
36dd074dcc fix: added is_last_slide method in slides 2019-12-04 16:21:18 +05:30
Rucha Mahabal
d9bbd10382 fix: added a 'Continue' type slide 2019-12-04 15:59:38 +05:30