* fix: remove read_only decorator from get_desktop_page
get_desktop_page leads to a call to check_completions which calls save and thus with the read_only decorator calls save on the read replica
* fix: Move write operation out of read only request
* fix: deprecated initHighlighting
Deprecated as of 10.6.0. initHighlighting() is deprecated. Use highlightAll() instead.
---------
Co-authored-by: Apile Tyumre <apiletyumre@iridescentsun.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* fix: use actual file name for private files
* fix: add id to download button
* fix: add fid in view file too
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Users with only 'select' permission can now filter, order by, and
group by all permlevel 0 fields, not just search fields.
- Added _get_filterable_fields() returning all permlevel 0 fields
for select permission users
- Split permission checking into check_select_field_permission()
and check_filter_field_permission()
- select field validation uses check_select_field_permission
- Filter/order/group by validation uses check_filter_field_permission
* fix: update pagination count to reflect inline filter scope in Report View and show appropirate no data message
* refactor: more explicit messages and center no data message
* fix: Translate user facing string
---------
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* fix(schema): drop unique constraint and indexes for deleted doctype fields
* refactor(schema): rename a variable and remove commented code
* test: add test case for dropping unique constraint on field deletion from doctype
* fix(tests): prevent list mutation during iteration
* test(db): guard MariaDB-specific unique index test with db_type_is.MARIADB
* fix(schema): drop unique constraints and indexes for deleted fields on postgres
* fix(schema): make postgres unique cleanup idempotent for deleted fields
* fix(schema): make postgres unique cleanup idempotent on reload
* test: add test case for dropping unique constraint and index on field deletion for postgres
* fix(schema): make postgres unique cleanup idempotent
