Ankush Menat
887d22cb1f
chore: rengerate yarn.lock ( #17747 )
...
yarn lock wasn't updated correctly in last package.json update which
causes failure during update
[skip ci]
2022-08-07 18:55:38 +05:30
Shariq Ansari
0ce7f44d45
fix: Webform Misc Fix ( #17642 )
2022-08-07 15:24:50 +05:30
Ernesto Ruiz
2101a2d576
chore: typo in comment on keyboard.js ( #17742 )
2022-08-06 13:06:42 +05:30
gavin
5385276547
Merge pull request #16748 from gavindsouza/refactor-oauth-tests
...
refactor: Oauth20 tests
2022-08-05 16:09:27 +05:30
gavin
2735d1c558
Merge branch 'develop' into refactor-oauth-tests
2022-08-05 15:37:41 +05:30
Gavin D'souza
e7a16135e0
fix: Setup test_client for each test
2022-08-05 15:12:52 +05:30
Gavin D'souza
7b149d4273
fix: Allow setting kwarg site for make_request test util
2022-08-05 13:54:58 +05:30
Gavin D'souza
b00ae8043f
test: Set sid as client cookie instead of oauth payload
2022-08-05 12:25:04 +05:30
Sagar Vora
f9bfbfec98
perf: reduce DB calls made in get_fetch_values ( #17671 )
...
* perf: reduce DB calls made in `get_fetch_values`
* fix: ensure return value is same as before
* test: add test for `frappe.model.utils.get_fetch_values`
2022-08-05 11:52:37 +05:30
Gavin D'souza
832fbb6c85
chore: Remove dead imports
2022-08-05 11:39:39 +05:30
Gavin D'souza
65273ee828
Merge branch 'develop' of github.com:frappe/frappe into refactor-oauth-tests
2022-08-05 11:38:55 +05:30
Gavin D'souza
060498c3e4
test: Pass sid to requests to maintain a session
2022-08-05 10:41:13 +05:30
vishdha
9a50c30586
fix: add_user_permission with applicale_for arg set not updating in user permission
2022-08-05 00:27:38 +02:00
Ankush Menat
f6210e7c38
Merge pull request #17697 from ankush/ast_translate
...
feat: use babel to extract translation sources
2022-08-04 15:53:42 +05:30
Ankush Menat
7452ac5d37
chore: correct default arg for extract_javascript
...
Tuples need extra comma to make sure it's not treated as string.
[skip ci]
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-08-04 15:52:32 +05:30
Ankush Menat
16fdff8231
chore: remove pointless template strings
2022-08-04 15:33:03 +05:30
Ankush Menat
ec8f20c097
fix: send all messages on boot instead of scanning
...
close https://github.com/frappe/frappe/issues/17684
2022-08-04 15:33:03 +05:30
Ankush Menat
2d7fc1825f
refactor: simplify get_messages_from_file
2022-08-04 15:33:03 +05:30
Ankush Menat
da872a0edf
feat: modified parser for frappe JS translate syntax
2022-08-04 15:33:02 +05:30
Ankush Menat
cd53466b6a
feat: JS extractor and custom JS parser
2022-08-04 15:19:56 +05:30
Ankush Menat
1425842ef0
refactor: extract python translations using babel
...
RIP my cool handwritten AST code :'(
Few things to note:
1. Publicly documented APIs, they don't support capturing kwargs.
2. We can't use documented "lower level" APIs, we need to go _even lower_.
2022-08-04 15:19:55 +05:30
Ankush Menat
ea836a824a
feat: use AST to extract translation sources
2022-08-04 15:19:55 +05:30
Ankush Menat
0cb4da1195
fix: ignore built assets in translation
2022-08-04 15:19:55 +05:30
Ankush Menat
7c80d1e0ab
Merge pull request #17495 from ankush/format_js
...
style: auto-format JS files
2022-08-04 15:19:13 +05:30
Ankush Menat
7c051875b2
chore: ignore js format commit
2022-08-04 14:52:09 +05:30
Ankush Menat
40f27f908a
style: format JS files with prettier
2022-08-04 14:51:01 +05:30
Ankush Menat
015937a03a
test: fix anticipiated test failures
2022-08-04 14:50:24 +05:30
Ankush Menat
7c1b96bc62
style: autoformat JS files
2022-08-04 14:50:24 +05:30
Ankush Menat
a1eaefefda
refactor: simplfiy translate pattern
...
\s already includes \n
2022-08-04 14:50:24 +05:30
Gavin D'souza
2933a06e80
Merge branch 'develop' of github.com:frappe/frappe into refactor-oauth-tests
2022-08-03 16:37:38 +05:30
Ankush Menat
2746ac6aea
Merge pull request #17719 from gavindsouza/trim-fat
...
chore: Minified DocType JSON notation from old verbose notation
2022-08-03 14:05:46 +05:30
Ankush Menat
bdeb032fba
refactor: use separate config key for encryption ( #17720 )
2022-08-03 13:52:02 +05:30
gavin
e4fcf563d2
Merge pull request #17682 from resilient-tech/refactor-only-for
...
refactor: improve `frappe.only_for`
2022-08-03 12:54:32 +05:30
Gavin D'souza
8def87331f
chore: Add minification to blame ignore
2022-08-03 12:26:38 +05:30
Gavin D'souza
85e3ee9403
chore: Minified DocType JSON notation from old verbose notation
2022-08-03 12:22:03 +05:30
Gavin D'souza
2ae50f911a
chore: Minimize OAuth Client DocType
2022-08-03 12:01:36 +05:30
Gavin D'souza
750618ca7c
fix: Re-raise original exception from tenacity's retry
2022-08-03 12:01:12 +05:30
Gavin D'souza
f7d5cb504a
test(oauth-client): Generate new client for each test
2022-08-03 12:00:09 +05:30
Ritwik Puri
9b620bb648
fix: set /app as redirect for pageview home button ( #17715 )
2022-08-03 11:53:10 +05:30
Sagar Vora
eb1c9fff68
fix: translate each role
2022-08-02 19:28:33 +05:30
Sagar Vora
74c26ac34d
fix: use throw
2022-08-02 19:16:53 +05:30
Sagar Vora
53118367b2
fix: use warn util
2022-08-02 19:08:02 +05:30
Gavin D'souza
7f2c9e84b3
feat(minor): Expose use_cookies kwarg to test client
2022-08-02 17:30:07 +05:30
Gavin D'souza
b14f8f4e03
feat(minor): Expose force to doc.delete
2022-08-02 17:30:07 +05:30
Gavin D'souza
d6ba7caf92
chore: Add typing for Document.doc_before_save
2022-08-02 17:30:07 +05:30
Gavin D'souza
e32ecb394d
refactor: Oauth20 tests
...
Use App client app directly instead of requests. This removes dependency
on needing a web server running for your tests. Also, contributes to
coverage now. We can see which lines are impacted with each use case.
2022-08-02 17:30:07 +05:30
Sagar Sharma
d88d9f5186
fix: max_positive_value for Integer types ( #17712 )
...
* fix: max_positive_value for Integer types
* style: formatting
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-08-02 15:48:54 +05:30
Sagar Vora
ebb0cd13fe
perf: reduce DB call in frappe.client.get ( #17665 )
2022-08-02 15:38:39 +05:30
P-Godfroid
2d1fe02dba
fix: Append to condition misleading message ( #17696 )
...
* Update Append to doctype description
Hello,
To append email to a doctype to enable automatic creation, there are two required fields listed
However, there is a third one required which is lacking in the above description (as seen below), because the email settings of the document must be enabled.
I propose to simply modify the sentence to the following :
Append as communication against this DocType (must have fields ("Status", "Subject") and "Sender" defined in the related doctype Email Settings).
To avoid any problem, in the code, it becomes the following :
Append as communication against this DocType (must have fields (\"Status\", \"Subject\") and \"Sender\" defined in the related doctype Email Settings).
The same must be applied in email_domain.json and in lots of csv in translations of course.
Pierre
* Update email_domain.json
* Updated sentence email account
* Updated sentence of email domain
* More brackets
* More brackets
* Typo
* Update email_account.json
* No dot
2022-08-02 15:20:19 +05:30
Ankush Menat
63c3c8ff84
Merge pull request #17702 from gavindsouza/global-search-fixes
...
fix(global_search): Trigger rebuilding on Custom Field's `in_global_search` property change
2022-08-02 15:06:36 +05:30
