Commit graph

51974 commits

Author SHA1 Message Date
Akhil Narang
9e380bc33c
fix(query): don't create 2 error logs for the same thing (#34925)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-28 12:39:31 +05:30
Aarol D'Souza
a7d8495d7b
test: skip DB-specific tests using new unimplemented_for decorator (#34749)
* test: skip DB-specific tests using new unimplemented_for decorator

* test: use unimplemented to skip tests with implementation problems

* test: update unimplemented to consider multi-DBs

* test: skip test_unbuffered_cursor using unimplemented for pg and sqlite

* test: update unimplemented wrapper
2025-11-28 06:51:45 +00:00
Soham Kulkarni
b958200996
Merge pull request #34930 from sokumon/desktop-fixes 2025-11-28 11:41:45 +05:30
sokumon
60598bf214 fix(menu): apply correct z-index 2025-11-28 02:53:21 +05:30
sokumon
314701bad2 fix: image in desktop screen 2025-11-28 02:33:18 +05:30
Soham Kulkarni
91a2883645
Merge pull request #34929 from sokumon/menu-refactor 2025-11-28 02:13:39 +05:30
sokumon
609683d48a fix: make the sidebar header use menu class 2025-11-28 01:11:16 +05:30
Soham Kulkarni
d89d63af27
Merge pull request #34928 from sagarvora/fix-awesomebar-opening-twice 2025-11-28 01:06:55 +05:30
Sagar Vora
fbf44bc584 fix: prevent awesomebar from opening twice on desktop
When navigating from desktop -> list view -> back to desktop,
the setup_awesomebar() was called again via on_page_show,
creating multiple AwesomeBar instances with their own modals
and event listeners.

Added a guard to ensure setup_awesomebar() only runs once per
DesktopPage instance.

Fixes #34923
2025-11-28 00:07:42 +05:30
Sagar Vora
c5aa1d9e01
fix(Table MultiSelect): support creating new linked doc and trigger events reliably (#34885)
- Store field_obj reference instead of deep cloning control in frappe._from_link
- Route back to original form before setting value (fixes self-linking doctype case)
- Move _add event trigger to set_model_value() for reliable event firing
- Add Table MultiSelect support in update_calling_link validation
- Remove unused deep_clone utility from frappe.utils
2025-11-27 23:53:17 +05:30
sokumon
194f34fe5d chore: rename app to desk 2025-11-27 20:57:41 +05:30
sokumon
320f1a6345 fix: remove the need of passing name in menu 2025-11-27 20:55:59 +05:30
sokumon
f92226880e refactor: menu component 2025-11-27 20:43:02 +05:30
MochaMind
b958d1bbe8
fix: sync translations from crowdin (#34927) 2025-11-27 14:42:43 +01:00
Soham Kulkarni
ac8ce02804
Merge pull request #34896 from ishtiyaq130/cursor-pointer-issue 2025-11-27 18:32:17 +05:30
Soham Kulkarni
c2ba2f3494
Merge pull request #34924 from sokumon/desktop-fixes 2025-11-27 18:09:18 +05:30
sokumon
478238d6d9 chore: run linter 2025-11-27 18:03:33 +05:30
ishtiyak
9f2569acb6 fix: cursor pointer showing on avatar in desktop 2025-11-27 18:01:32 +05:30
sokumon
8769269bfd fix: show cursor on the element where menu is triggered 2025-11-27 17:39:12 +05:30
Ejaaz Khan
6635e3ae3a
Merge pull request #34919 from iamejaaz/51875-hide-dropdown-icon
fix(Toolbar): hide dropdown button if no childrens inside
2025-11-27 16:56:15 +05:30
Sagar Vora
27361de172
Merge pull request #34887 from sagarvora/fix-multiselect-parse-validate 2025-11-27 15:17:21 +05:30
Sagar Vora
882c6b3471 fix: improve table multiselect validation and UX
- Move validation from parse to validate method for proper flow
- Trigger row_add event only after successful validation
- Clear input field when validation fails
- Fix parse method signature in link control
2025-11-27 14:54:45 +05:30
Ejaaz Khan
33ffa277d8 fix(Toolbar): hide dropdown button if no childrens inside 2025-11-27 14:34:05 +05:30
Sagar Vora
4621cb33fc
Merge pull request #34917 from sagarvora/console-err-in-user 2025-11-27 12:36:11 +05:30
MochaMind
7b16b228c3
fix: sync translations from crowdin (#34889)
* fix: Spanish translations

* fix: Arabic translations

* fix: Czech translations

* fix: Danish translations

* fix: German translations

* fix: Hungarian translations

* fix: Italian translations

* fix: Dutch translations

* fix: Polish translations

* fix: Portuguese translations

* fix: Russian translations

* fix: Serbian (Cyrillic) translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Chinese Simplified translations

* fix: Vietnamese translations

* fix: Portuguese, Brazilian translations

* fix: Indonesian translations

* fix: Persian translations

* fix: Tamil translations

* fix: Thai translations

* fix: Croatian translations

* fix: Burmese translations

* fix: Bosnian translations

* fix: Norwegian Bokmal translations

* fix: Serbian (Latin) translations

* fix: Esperanto translations

* fix: French translations

* fix: Slovenian translations

* fix: Serbian (Cyrillic) translations

* fix: Persian translations

* fix: Serbian (Latin) translations
2025-11-27 12:20:56 +05:30
Sagar Vora
a79b95f361 fix: TypeError when loading website users 2025-11-27 12:12:53 +05:30
Ejaaz Khan
8208ff2d17
Merge pull request #34899 from iamejaaz/cool-awesomebar
feat: cool awesomebar
2025-11-27 10:27:25 +05:30
Ejaaz Khan
bdb8261dad fix: multiple modal opens on desktop 2025-11-26 23:43:26 +05:30
Ejaaz Khan
166de452fe fix: transalte view name instead of variable 2025-11-26 23:13:04 +05:30
Ejaaz Khan
040dd0e5f9 fix: help modal does not open on first click 2025-11-26 23:06:32 +05:30
Ejaaz Khan
215d00f636 fix: semgrip translation issue 2025-11-26 22:43:32 +05:30
Ejaaz Khan
d041d26ef1 refactor: focus input on show modal event 2025-11-26 22:35:22 +05:30
Soham Kulkarni
5dfb5e321a
Merge pull request #34913 from sokumon/desktop-mobile 2025-11-26 21:06:38 +05:30
sokumon
745292844c fix: dont allow reordering of icons on mobile 2025-11-26 20:39:22 +05:30
Ankush Menat
382f34eddc
fix: set autoname for workspace sidebar item (#34910)
Automatically handle hash collision issues because of bad previous
exports
2025-11-26 12:47:15 +00:00
Akhil Narang
1bcdec6283
fix(query): check standard field definitions (#34828)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-26 18:14:03 +05:30
Ejaaz Khan
715b9e26ba fix: remove icon from translations 2025-11-26 17:32:56 +05:30
Akhil Narang
b640faa80b
fix: allow selecting optional fields (#34901)
Simplification/follow up to 9455721c77

Resolves #34861

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-26 17:31:17 +05:30
Ejaaz Khan
4e2587fd4f test: fixed failing test cases of cool awesomebar 2025-11-26 17:18:22 +05:30
Akhil Narang
c7dcc0e097
Revert "fix: use number format from currency document if defined (#34886)" (#34906)
This reverts commit a8c835190d.
2025-11-26 10:50:28 +00:00
Ejaaz Khan
252fde05b0 test: add test case to open search modal 2025-11-26 15:43:48 +05:30
Akhil Narang
a1ba7969e1
fix(sqlite): user_sync query was wrong (#34897)
Adjust to use `ON CONFLICT` in a similar manner as the others

```
 File "apps/frappe/frappe/model/rename_doc.py", line 192, in rename_doc
    update_user_settings(old, new, link_fields)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/rename_doc.py", line 276, in update_user_settings
    sync_user_settings()
    ~~~~~~~~~~~~~~~~~~^^
  File "apps/frappe/frappe/model/utils/user_settings.py", line 52, in sync_user_settings
    frappe.db.multisql(
    ^^^^^^^^^^^^^^^^^^^
    ...<12 lines>...
    	as_dict=1,

  File "apps/frappe/frappe/database/database.py", line 1416, in multisql
    return self.sql(query, values, **kwargs)
           ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/sqlite/database.py", line 454, in sql
    return super().sql(*args, **kwargs)
           ~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/database.py", line 272, in sql
    self.execute_query(query, values)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/database/sqlite/database.py", line 443, in execute_query
    return self._cursor.execute(query, values or ())
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
sqlite3.ProgrammingError: Incorrect number of bindings supplied. The current statement uses 3, and there are 4 supplied.
```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-26 15:15:05 +05:30
Soham Kulkarni
443a600ba1
Merge pull request #34900 from sokumon/update-package 2025-11-26 13:28:56 +05:30
sokumon
8c69f3e542 fix(ci): update pypdf 2025-11-26 12:40:27 +05:30
Ejaaz Khan
ac448227be feat: cool awesomebar 2025-11-26 12:22:28 +05:30
Ayush Chaudhari
c4de4fe649
fix: fix module search (#34872) 2025-11-26 10:51:37 +05:30
Hussain Nagaria
a8c835190d
fix: use number format from currency document if defined (#34886)
* fix: use number format from currency if defined

* refactor: extract out function
2025-11-25 12:44:18 +00:00
Soham Kulkarni
ae701e9541
Merge pull request #34875 from sokumon/export-all-sidebars 2025-11-25 16:28:53 +05:30
sokumon
6b19f3c303 chore: resolve conflicts in Productivity sidebar export 2025-11-25 16:03:02 +05:30
sokumon
c40f2ea597 fix: dont autogenerate if icon is present for app 2025-11-25 15:47:35 +05:30