Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options ( #25211 )
...
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
2639bfe945
fix: dont translate numbers ( #25208 )
...
This is not shown in UI and only used for UI logic of toggling button.
closes https://github.com/frappe/frappe/issues/25202
2024-03-04 06:19:40 +00:00
Suraj Shetty
9a1bd6c1ac
fix: No need to sort keys while saving JSON to DB ( #25205 )
...
* fix: No need to sort keys while saving JSON to DB
Also, adding indent is unnecessary.
2024-03-04 05:44:46 +00:00
Ankush Menat
53536aa012
perf: reduce JS duplication ( #25199 )
...
* fix: remove duplicate localforage in bundles
This was shipped with both control and desk bundle
* fix: Avoid duplicate inclusion of DataTable
2024-03-03 20:50:21 +05:30
Ankush Menat
b60c64cacc
fix: rollback invalid customize form changes ( #25198 )
...
* fix: rollback invalid customize form changes
* fix: commit before doing DDL
2024-03-03 17:17:12 +05:30
Frappe PR Bot
4282239fd5
chore: New translations main.pot (Persian) ( #25201 )
2024-03-03 15:19:59 +05:30
Suraj Shetty
89db4ff1a6
Merge pull request #25200 from surajshetty3416/fix-email-validation
2024-03-02 21:34:56 +05:30
Suraj Shetty
b398377739
Merge branch 'develop' into fix-email-validation
2024-03-02 21:23:24 +05:30
Suraj Shetty
ec4261bd77
fix: Do not check for email validation on empty string
2024-03-02 21:20:51 +05:30
Corentin Flr
f4b6f95832
fix(search): Don't break when query doesn't return title ( #25168 )
2024-03-02 19:34:52 +05:30
Frappe PR Bot
8b8c65cd5a
chore: sync translations from crowdin ( #25181 )
...
* New translations main.pot (French)
* New translations main.pot (German)
* New translations main.pot (Spanish)
* New translations main.pot (Arabic)
* New translations main.pot (Persian)
2024-03-02 19:30:31 +05:30
Raffael Meyer
05d9c5df8f
fix(grid): don't add next row while paging ( #25183 )
2024-03-02 19:30:13 +05:30
Maxim Sysoev
eff50e1cd3
fix: filter Implementation is set operator ( #25182 )
...
* Implementation is set operator. fix issue #25180
* Refactored filtrer operator `is`,
Add tests
* fix: Correct implementation for `is set`
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-02 13:59:30 +00:00
Ankush Menat
daf43cff79
test: add test case for in ("") ( #25189 )
2024-03-02 06:00:02 +00:00
Akhil Narang
590a9cd0bc
Merge pull request #25184 from barredterra/refactor-link
...
refactor: validate_link_and_fetch
2024-03-01 18:38:26 +05:30
barredterra
1f969a40eb
refactor: validate_link_and_fetch
...
Remove redundant parameters
2024-03-01 13:31:34 +01:00
Raffael Meyer
81785ae52b
perf: "load more" and "increase page length" ( #25081 )
...
* refactor: saparate click handlers for "load more" and "change page length"
* perf: "load more" or "increase page length"
Only request the required additional data, not all data.
2024-02-29 21:49:32 +05:30
Ankush Menat
0fff2755d6
test: separate out risky tests ( #25179 )
2024-02-29 16:10:08 +00:00
Ankush Menat
f7bff58935
fix: use name for RQ worker instead of PID ( #25175 )
...
Also avoid complex naming schemes.
2024-02-29 14:38:48 +00:00
Ankush Menat
39c511a9b3
Merge pull request #25170 from ankush/delete_conflict
...
fix: race condition on deletes
2024-02-29 18:17:24 +05:30
Ankush Menat
b4fe7223c1
fix(postgres): treat LockNotAvailable as timeout
...
It's a lock timeout in a way.
2024-02-29 18:04:05 +05:30
Ankush Menat
0c9cc2e6ce
test: NOWAIT functionality
2024-02-29 17:46:30 +05:30
Ankush Menat
5116768a54
test: utils for simulating two connections
2024-02-29 17:31:46 +05:30
Ankush Menat
fc5ce044e6
fix: prevent deletion if document is locked
2024-02-29 16:34:39 +05:30
Ankush Menat
e810fb7eca
feat: nowait to skip blocking locks
2024-02-29 16:30:24 +05:30
Ankush Menat
8f00aae160
fix: lock the doc before deleting
...
Locking only prevents this kinda race conditions:
- User A deletes doc
- User B modifies doc so that it's not deletable anymore.
2024-02-29 16:22:02 +05:30
Ankush Menat
f2b07d6c13
Merge pull request #25162 from frappe/pot_develop_2024-02-29
...
chore: update POT file
2024-02-29 10:29:17 +05:30
frappe-pr-bot
0129770957
chore: update POT file
2024-02-29 04:42:35 +00:00
Ankush Menat
1061793b8d
Merge pull request #24467 from barredterra/potfile-ci
...
ci: auto-generate potfile
2024-02-29 10:10:26 +05:30
Ankush Menat
9c93d86294
ci: use bot's PAT
2024-02-29 10:00:39 +05:30
Ankush Menat
69dad391e4
Merge branch 'develop' into potfile-ci
2024-02-29 09:58:02 +05:30
Ankush Menat
af69dab130
fix(UX): reload form after renaming field ( #25159 )
2024-02-29 04:26:52 +00:00
Frappe PR Bot
a15ddf8d1b
chore: sync translations from crowdin ( #25158 )
...
* New translations main.pot (German)
* New translations main.pot (Persian)
2024-02-29 04:26:35 +00:00
Ankush Menat
b044ffedf1
fix: Only validate fetch from when user modifies it
2024-02-28 20:42:49 +05:30
Raffael Meyer
5d8383e724
Merge pull request #25155 from barredterra/lang-fa
2024-02-28 15:57:51 +01:00
barredterra
142d2d4249
feat: add persian language
2024-02-28 15:39:13 +01:00
barredterra
e61424bdeb
chore: remove locale dir from .gitignore
2024-02-28 15:38:45 +01:00
Raffael Meyer
ac05c7db6e
fix: escape single quotes ( #25104 )
...
Resolves https://github.com/frappe/frappe/pull/25078#discussion_r1504084483
2024-02-28 19:52:57 +05:30
Akhil Narang
88c5da4d62
Merge pull request #25149 from akhilnarang/minor-fixes
...
fix(setup_module_map): fix caching
2024-02-28 17:53:32 +05:30
Akhil Narang
e6be7d6648
fix(setup_module_map): fix caching
...
Use a separate cache key depending on the arguments passed
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-28 17:41:18 +05:30
Ankush Menat
bab3ee33f0
fix: always show is_standard on web form ( #25144 )
...
This causes more confusion when it's hidden.
2024-02-28 12:07:28 +00:00
Ankush Menat
99a6883e5c
fix(UX): correctly disable standard web form form ( #25143 )
2024-02-28 17:33:46 +05:30
Ankush Menat
84642a6f4e
Merge pull request #25132 from Shankarv19bcr/file_update
...
fix: update file attached_to details in submitted doc
2024-02-28 17:07:15 +05:30
Ankush Menat
9bbb5ea409
Merge pull request #25137 from ankush/print_failure_ux
...
fix: escalate print failures
2024-02-28 17:01:02 +05:30
Ankush Menat
dbc2e092f1
fix: escalate print failures
...
Print failures shouldn't generate PDF with failure message but instead escalate the error.
This prevent all the PDFs that just contain "PermissionError" from being sent.
2024-02-28 16:42:03 +05:30
Ankush Menat
3237abdc7b
Merge pull request #25135 from ankush/guess_default_language
...
fix(UX): set default print language from print format
2024-02-28 15:31:34 +05:30
Ankush Menat
c00a34d023
fix(UX): set default print language from print format
2024-02-28 15:25:58 +05:30
Ankush Menat
c293a35dda
Merge pull request #25131 from ankush/specify_lang_communication
...
fix: specify print_language in communication attachments
2024-02-28 14:32:28 +05:30
Shankarv19bcr
5ef208d1f1
fix: update file attached_to details in submitted doc
2024-02-28 14:21:42 +05:30
Ankush Menat
a4ddb7491d
fix: specify print_language in communication attachments
2024-02-28 14:19:28 +05:30
