Commit graph

41077 commits

Author SHA1 Message Date
developsessions
bcbcc87f4b fix: possible none value evaluation in get_formatted function 2023-02-01 09:24:42 +01:00
Ankush Menat
9d97097c12
fix: dont apply varchar length validation on singles (#19872)
closes https://github.com/frappe/frappe/issues/19833

[skip ci]
2023-02-01 10:22:50 +05:30
Ankush Menat
4ca23dd5fa
fix: Dont setup socketio events on new doc (#19864) 2023-01-31 18:52:13 +05:30
Ankush Menat
b8ba7dcdb3
fix: Setting default print format (#19862)
- Remove check for developer mode, it's not even valid as we dont allow
  setting default print format like this
- Set in custom doctype if custom doctype else prop setter.
- query meta instead of doctype.

[skip ci]
2023-01-31 17:52:35 +05:30
Samuel Danieli
4d08f50a03
fix: PermissionError (#19856)
* fix: PermissionError

* fix: check perm on customize form

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-31 16:04:40 +05:30
Ankush Menat
1fd74e9472 chore: switch base doctype
This is a dummy doctype and doesn't actually affect anything but needs
to have "report" perm.

[skip ci]
2023-01-31 14:54:41 +05:30
gavin
7f34d510f2
fix(db_query): Allow link field to have 'tab' (#19820)
* fix(db_query): Allow link field to have 'tab'

Issue: Occurence of tab was used to check if the selected field is a table name
and not a fieldname. This caused DocTypes with fields like `tablets` or
`table_name` to break List Views.

Change: Check if the field exists in meta to be sure that the selectable
is a field.

* fix: Split once to ensure at most 2 args
2023-01-31 14:43:26 +05:30
Ankush Menat
b3b846472e test: clear defaults after test 2023-01-31 12:35:43 +05:30
Ankush Menat
45280d4801
fix: website theme caching (#19848) 2023-01-31 11:25:14 +05:30
Ritwik Puri
d3a3381af1
Merge pull request #19651 from barredterra/test_address_template
refactor: address template
2023-01-30 18:29:23 +05:30
Ankush Menat
338ccc5a2a
fix: sanitize form dict in error logs (#19835)
[skip ci]
2023-01-30 15:22:21 +05:30
Raffael Meyer
e82046ef00
ci: bump isort to 5.12.0 (#19836)
* ci: bump isort to 5.12.0

* style: remove trailing whitespace
2023-01-30 15:11:55 +05:30
RJPvT
8be98718f7
fix: ldap with 2fa (#19753)
Because we pop password 2fa fails when used with ldap

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-30 14:44:53 +05:30
Leonard Goertz
3e20e7df25
fix: add brackets for docshare or condition (#19650)
Co-authored-by: Leonard Goertz <leonard.goertz@noventive.com>
2023-01-30 14:14:11 +05:30
Ankush Menat
1eab4e4253
fix: Convert doctype name to string (#19832) 2023-01-30 14:11:38 +05:30
Shariq Ansari
9f45406fe8
Merge pull request #19798 from dj12djdjs/fix-grid-search 2023-01-30 13:07:52 +05:30
Shariq Ansari
443f97f827 Merge branch 'develop' into fix-grid-search 2023-01-30 12:49:59 +05:30
Shariq Ansari
e4f818b838 fix: remove row if search_row is not implemented 2023-01-30 12:41:46 +05:30
Ankush Menat
e9d64d4ec0
Merge pull request #19588 from marination/report-sidebar-respect-perm-query
fix: Report sidebar must consider Permission Query
2023-01-30 12:10:38 +05:30
Sabu Siyad
1e115e5e50
chore!: Remove translation tool (page) (#19786)
* refactor(page): remove translation tool files

* refactor(patches): remove translation tool page
2023-01-30 12:09:05 +05:30
Ankush Menat
13162d8fbd fix: Only apply perm query to non-admin users 2023-01-30 11:24:16 +05:30
Marica
57c991f055
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-30 11:12:38 +05:30
marination
1e4d28cc19 fix(test): Remove try-finally & ignore perms on test user's report insertion 2023-01-30 11:08:14 +05:30
Türker Tunalı
e18188ed3e
fix(i18n): Datepicker Turkish translations (#19777)
* feat:Datepicker Turkish translations are added.

* chore: format

[skip ci]

---------
2023-01-30 09:38:35 +05:30
Raffael Meyer
0df4bd27fb
Merge branch 'develop' into test_address_template 2023-01-29 19:34:13 +01:00
Ankush Menat
87008e3930
Merge pull request #19780 from ankush/hooks_audit
feat: Audit hooks report
2023-01-29 20:14:32 +05:30
Ankush Menat
80dcf0b178 feat: Split dict hooks to separate lines 2023-01-29 20:09:45 +05:30
Ankush Menat
4d08a989f5 feat: Audit hooks report 2023-01-29 19:58:34 +05:30
morehardik
d3d76865f7
fix: check permission before running onload hook #11774 (#19823)
Added fix for issue wherein Document is loaded post permission check
2023-01-29 03:01:29 +05:30
Shariq Ansari
72f5208a43
Merge pull request #19792 from barredterra/responsive-freeze-message 2023-01-28 12:36:28 +05:30
gavin
ee80d6a504
feat(cli): Pass extra args to DB console (#19809) 2023-01-27 22:57:19 +05:30
barredterra
b812f73339 feat: better freeze message 2023-01-27 15:57:02 +01:00
Ankush Menat
b8deb72411
fix: prepared report patch (#19807)
- the patch is failing if system setting is updated and column is gone
- the message is misleading "invalid column", it should be "missing field".
2023-01-27 14:26:54 +05:30
Ritwik Puri
bc9ed4a422
chore: remove prepared report event from system settings controller (#19808)
[skip ci]
2023-01-27 14:19:05 +05:30
Ankush Menat
70ee9272b1
fix: sanitize traceback for common secrets (#19805) 2023-01-27 12:44:33 +05:30
Shariq Ansari
7047a2853a
Merge pull request #19790 from barredterra/freeze-message-bulk-delete 2023-01-27 11:03:07 +05:30
Shariq Ansari
5b8a8bb59f
Merge branch 'develop' into freeze-message-bulk-delete 2023-01-27 10:43:34 +05:30
Sagar Vora
db9b25ec0e
fix(MariaDBTable): dont attempt to drop index twice (#19783) 2023-01-27 09:27:11 +05:30
Ankush Menat
cbd5e1156d
Merge pull request #19799 from barredterra/disable-pip-audit
ci: temporarily disable pip-audit
2023-01-27 09:10:57 +05:30
Ankush Menat
c0fab395a7 ci(vuln check): skip dropbox package and use cache 2023-01-27 09:05:56 +05:30
Devin Slauenwhite
165c670a49 Merge branch 'fix-grid-search' of github.com:dj12djdjs/frappe into fix-grid-search 2023-01-26 17:18:26 -05:00
Devin Slauenwhite
10104abeb2 fix: limit search rows to >= 20 2023-01-26 17:15:22 -05:00
Devin Slauenwhite
e759547d9d
Merge branch 'develop' into fix-grid-search 2023-01-26 16:40:40 -05:00
Devin Slauenwhite
67c5a8d75a fix: remove incompatible logic 2023-01-26 16:31:07 -05:00
Devin Slauenwhite
e93345d20e fix: grid search without frm 2023-01-26 16:20:43 -05:00
Ritwik Puri
f83775e24d
fix: respect disable sidebar stats on list view (#19665)
fix: respect disable sidebar stats on list view
2023-01-26 21:30:26 +05:30
Ritwik Puri
576d95a143
Merge pull request #19788 from barredterra/almost-equal-with-precision
fix: assertAlmostEqual with precision
2023-01-26 21:19:13 +05:30
barredterra
9d9c06985e fix: use count instead of concatenated docnames 2023-01-26 14:49:50 +01:00
barredterra
8fe6b8f3d9 fix: add freeze message for bulk delete 2023-01-26 13:53:03 +01:00
Shariq Ansari
ba6a969f3c
Merge pull request #19787 from shariquerik/ui-test-fix-1 2023-01-26 17:23:25 +05:30