barredterra
fe907673b4
ci: fix issues in POT script
2024-02-11 20:26:25 +01:00
Ankush Menat
d0de5da21e
Merge pull request #24857 from ankush/refactor_password_reset
...
refactor: Reset password flow
2024-02-11 20:56:13 +05:30
Rehan Ansari
b8e1979864
chore: typo in frappeclient.py ( #24854 )
2024-02-11 11:06:30 +00:00
Ankush Menat
78264a7f16
fix(UX): usability of reset password page
...
- password managers use paste, added that event to trigger our code
- if no password policy then skip. Way too much needless business logic in HTML here.
2024-02-11 16:30:32 +05:30
Ankush Menat
11ea7e4179
feat: socketio using authorization headers
...
Earlier socketio only worked in browser where browser would send cookie
(cause same domain) and hence socketio server used it to auth
connection.
This however is limited and doesn't allow simply creating socket
connection from apps.
Authorization headers on other hand are simple to implement.
2024-02-11 16:16:34 +05:30
Ankush Menat
38565a80e3
test: redo reset password tests
2024-02-11 14:30:50 +05:30
Ankush Menat
4c925e0325
refactor: Reset password flow
...
- Hash one time reset tokens instead of storing them as is
- Up the perm level
- Use better source of randomness for generating token
- minor code cleanup here and there
2024-02-11 14:25:26 +05:30
Ankush Menat
74071c1231
chore: remove default UI tours
...
Experiment 🤷
2024-02-11 14:25:26 +05:30
Ankush Menat
17ebc5ee4d
chore: disable flaky UI test ( #24847 )
2024-02-10 18:08:40 +05:30
tonspar
c12b753648
fix: make_request - prevents an error during response parsing if the response body is empty. ( #24613 )
...
* Update utils.py
Sometimes the returned response body is empty. This change prevents the error during frappe response parsing. For example DELETE request returns no content.
* Revert "Update utils.py"
This reverts commit edbfb6960a175da142e9114d8096e5f09665da1b.
* fix: Avoid parsing empty responses in make_request
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-10 08:50:22 +00:00
XRP Systems
b70e0e8071
fix: Added Mongolian language ( #24803 )
2024-02-10 08:41:56 +00:00
Corentin Flr
4f5de3b0de
fix(boilerplate): Fix WebsiteGenerator HTML templates ( #24806 )
2024-02-10 13:57:17 +05:30
Nihalroshan55
c21935ba9e
fix: added prefix none as default in export_fixtures ( #24816 )
...
* added prefix none as default in export_fixtures
* refactor: declare prefix default later later
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-10 08:21:56 +00:00
Ankush Menat
37489d3715
chore: keep old field data for role profile around
...
Avoids potential data loss, it will get cleaned up over time.
2024-02-10 13:45:55 +05:30
Ankush Menat
19044c4be4
Merge pull request #24745 from niraj2477/multiple-role-profile
...
feat: Allow multiple role profile for user
2024-02-10 13:11:44 +05:30
Ankush Menat
7e8b671059
test: role ordering doesn't matter
2024-02-10 12:58:23 +05:30
Ankush Menat
fd2e6e4045
fix: disable role editor if role profiles are present
2024-02-10 12:52:38 +05:30
Ankush Menat
60aae9bbb2
fix: role profile > user dashboard links
2024-02-10 12:52:38 +05:30
Ankush Menat
72c2207e0f
refactor: useless use of dict in frappe.get_doc
2024-02-10 12:52:38 +05:30
Ankush Menat
638aeaddd8
refactor: remove code duplication for role profile logic
2024-02-10 12:52:38 +05:30
Ankush Menat
bfa1aebcc6
fix: deduplicate role profiles
2024-02-10 12:52:35 +05:30
Ankush Menat
f609025472
fix: roles getting re-inserted on every save
2024-02-10 12:24:19 +05:30
Ankush Menat
72b40135ce
refactor: avoid implementing duplicate logic for role profile
...
Unless we are getting any performance benefit, I don't see the need to
have two different implementations for it.
also, queue job in long queue to reduce chance of failure
2024-02-10 12:24:19 +05:30
Ankush Menat
fbb4dd7e96
perf: use cached doc for fetching role profiles
2024-02-10 12:24:19 +05:30
Ankush Menat
ff35e4b854
refactor: backward compatiblity code for role_profile_name
2024-02-10 12:24:19 +05:30
Ankush Menat
ba5ee5c339
refactor: use get_all instead of get_list
...
There won't be any perm checks here.
2024-02-10 12:24:19 +05:30
Raffael Meyer
b3b02c809f
Merge pull request #24684 from barredterra/label-in-link-to-form
2024-02-09 21:03:07 +01:00
Raffael Meyer
6fc898a9e8
Merge pull request #24838 from barredterra/can-submit
2024-02-09 21:00:41 +01:00
marination
65c8a37636
test: Comment + Comm.n file extraction & Attachments default to public for Communication
...
- Note: DocType Communication's records are used for emails that have the file link embedded in its content
- fix: The files extracted from a Communication must be public so that they are visible in an email (link in email)
- Test: Check if file is created appropriately from a Comment and a Communication
2024-02-09 20:28:21 +01:00
barredterra
51743e5952
feat: frapp.model.can_submit (JS)
2024-02-09 16:19:12 +01:00
Ankush Menat
4e1ed2908c
perf: use unique file url ( #24830 )
2024-02-09 14:52:30 +00:00
Ankush Menat
ed6613ce8e
test: use meta for fetching settings
2024-02-09 19:58:41 +05:30
Ankush Menat
7fbae4cfc8
Merge branch 'develop' into multiple-role-profile
2024-02-09 19:55:12 +05:30
lbrandh
4ceb5c32b7
fix: preferred_language cookie ( #24819 )
2024-02-09 13:59:44 +00:00
Ankush Menat
60c832defd
chore: disable mergify auto merges ( #24825 )
2024-02-09 13:59:40 +00:00
marination
7445de9b1c
fix: Use doctype setting to set auto-extracted file as private
...
- Use `make_attachments_public` to determine the file privacy while auto creating files from the text editor field
- Currently, all files in the text editor field are automatically public
2024-02-09 14:55:24 +01:00
mergify[bot]
7e83d63b9c
Merge pull request #24818 from surajshetty3416/fix-email-validation-failure
...
fix: Ignore "Invalid Doctype" validation if ignore flag is passed
2024-02-09 11:54:57 +00:00
Ankush Menat
ef923e4cc9
test: use known functions for testing
...
Random functions can have annotations but no annotations on arguments
2024-02-09 17:11:48 +05:30
Suraj Shetty
7991c896a8
fix: Unset contact_name to avoid linking of contact in case of failure
2024-02-09 16:21:29 +05:30
Suraj Shetty
803c02258a
fix: Ignore "Invalid Doctype" validation if ignore flag is passed
2024-02-09 14:08:24 +05:30
Akhil Narang
91789ed9d1
Merge pull request #24772 from akhilnarang/ruff
...
ci: switch to ruff for linting
2024-02-07 17:17:14 +05:30
Akhil Narang
8c5657823d
chore: update list of revisions for git blame to ignore
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:45 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Akhil Narang
fbb0e44791
ci: switch to ruff for linting
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 16:38:41 +05:30
Abraham Kalungi
25a3baa632
fix: Remove Open Filter On Communication Doctype ( #24800 )
2024-02-07 13:13:04 +05:30
Ankush Menat
ca3ef817b0
fix: Avoid sending password back ( #24794 )
2024-02-06 20:05:42 +05:30
Ankush Menat
7753ed28fb
fix(DX): show user who modified in diff view ( #24790 )
2024-02-06 13:00:31 +00:00
barredterra
0184aa7823
test: get_url_to_form
2024-02-06 12:50:01 +01:00
barredterra
c282103867
fix: make get_url_to_form accept single doctype
2024-02-06 12:49:31 +01:00
14987
56efb7d2f7
fix: Resolve lint issue
2024-02-06 16:27:34 +05:30
