Abdeali Chharchhodawala
d6c19e856d
refactor: proper msg for users with role ( #35099 )
...
* refactor: proper msg for users with role
* refactor: better UI for showing users with role
* refactor: filter with role name instead usernames
* chore: simplify user list display in permission manager
2025-12-18 18:45:01 +05:30
Ejaaz Khan
45c0696c57
Merge pull request #35245 from sokumon/form-sidebar
...
feat: init form sidebar redesign
2025-12-18 17:56:46 +05:30
Ejaaz Khan
fbe22accb1
feat: re-design attachment and image section
2025-12-18 17:44:27 +05:30
Ankush Menat
c944981a3e
fix: Lock email queue before sending ( #35334 )
...
Avoids duplicate flushes.
2025-12-18 10:36:24 +00:00
Soham Kulkarni
8cf4af84f4
fix: always allow folders to be shown ( #35325 )
2025-12-18 14:41:07 +05:30
sokumon
709169a538
chore: clean desktop icon controller
2025-12-18 14:20:00 +05:30
rohitwaghchaure
6e944f8d55
Merge pull request #35307 from rohitwaghchaure/fixed-support-53592-4
...
fix: qty reset on selecting new item
2025-12-18 14:14:21 +05:30
Ejaaz Khan
424222dc81
fix: change url from app to desk
2025-12-18 14:01:52 +05:30
sokumon
c92a23d958
fix: always allow folders to be shown
2025-12-18 13:39:25 +05:30
Ejaaz Khan
fb0296f210
feat: redesign sidebar assignment
2025-12-18 12:57:54 +05:30
Soham Kulkarni
b559fee24e
fix: add default list.html for web view ( #35300 )
2025-12-18 12:16:05 +05:30
Ankush Menat
2505fa9c8c
Merge pull request #35308 from akhilnarang/qb-ifnull-optimization
...
perf: Split ifnull into two conditions
2025-12-18 10:31:30 +05:30
Ankush Menat
3177f6f5de
Merge pull request #35306 from frappe/fix/ss-cl
...
fix: don't auto enable create log for `All` and `Cron`
2025-12-18 10:30:31 +05:30
Ejaaz Khan
fc09193fbd
feat: move like to sidebar
2025-12-18 00:53:01 +05:30
Sagar Vora
cc731988ce
Merge pull request #35303 from sagarvora/improve-perm-conds
2025-12-17 22:38:36 +05:30
Sagar Vora
d1ffd99fe8
fix(query): wrap CombinedRawCriterion in parentheses for correct precedence
...
Without proper grouping, OR conditions from shared docs could bypass WHERE filters:
WHERE filter=X AND perm_cond OR shared_cond -- shared_cond ignores filter!
With proper grouping:
WHERE filter=X AND (perm_cond OR shared_cond) -- correct behavior
2025-12-17 22:28:52 +05:30
Soham Kulkarni
f6521ded0b
Merge pull request #35314 from sokumon/sidebar-fixes
...
fix: dont show sidebar for setup wizard
2025-12-17 21:46:48 +05:30
sokumon
48e82d1d3e
fix: dont show sidebar for setup wizard
2025-12-17 21:05:36 +05:30
Soham Kulkarni
b53cb2092c
Merge pull request #35311 from sokumon/rename-icons
2025-12-17 21:01:34 +05:30
sokumon
a8e24f9b10
chore: rename icons to match labels
2025-12-17 20:49:25 +05:30
Sagar Vora
b76706ac28
test: improve single query test
2025-12-17 19:30:32 +05:30
Sagar Vora
c7e9e01eb8
chore: fix linter issues
2025-12-17 19:04:00 +05:30
Sagar Vora
591d9a3535
fix: update logic for child tables
2025-12-17 19:03:15 +05:30
Ankush Menat
7be9fec036
perf: Split ifnull into two conditions
...
This produces better query plan with index intersection using 2
conditions instead of fulltable scan on dumb condition
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-17 17:47:08 +05:30
Rohit Waghchaure
a1cf7d0407
fix: qty reset on selecting new item
2025-12-17 17:44:05 +05:30
Hussain Nagaria
a9a4c79819
fix: don't auto enable create log for All and Cron
2025-12-17 17:35:48 +05:30
Ankush Menat
35dc034c7d
Merge pull request #35301 from ankush/sendmail_now
...
fix!: Sendmail shouldn't implicitly commit transaction
2025-12-17 16:47:18 +05:30
Ankush Menat
9979314b32
test: commit to trigger sendmail
2025-12-17 16:36:06 +05:30
Ankush Menat
5922f29806
chore: remove unncessary print
2025-12-17 16:30:46 +05:30
Sagar Vora
2b822cc63f
refactor(query): simplify permission logic in add_permission_conditions
...
- Extract _raise_permission_error helper for reuse
- Simplify get_user_permission_conditions to return list[Criterion]
- Rewrite add_permission_conditions to match documented logic:
- No role perms → apply only share permissions
- Role perms → (owner OR user perms) AND query conditions
- Shared docs OR other conditions when applicable
- Move apply_permissions check inside add_permission_conditions
2025-12-17 15:59:37 +05:30
Ankush Menat
71692b487b
fix!: sendmail now=True after current transaction is commited
...
Sendmail implicitly commits transaction to update status.
Do it after the parent transaction is commited.
closes https://github.com/frappe/frappe/issues/33343
2025-12-17 15:53:16 +05:30
Ankush Menat
c4c18427b1
Merge pull request #35298 from ankush/password_strenth
...
fix(UX): Add description for password strength levels
2025-12-17 15:33:52 +05:30
Soham Kulkarni
06619819b5
Merge pull request #35297 from sokumon/quick-desktop-1
2025-12-17 15:19:34 +05:30
Ankush Menat
3f79f179f2
fix(UX): Add description for password strength levels
...
As per zxcvbn
2025-12-17 15:07:23 +05:30
sokumon
c4b2636c6a
fix: add quick way to go back to desktop
2025-12-17 14:46:46 +05:30
Ankush Menat
7205e1e075
Merge pull request #35273 from akhilnarang/fix-shared-docs-query
...
fix(query): use `AND` if adding shared query
2025-12-17 14:35:58 +05:30
Ankush Menat
32d003c981
fix: Allow GIF uploads ( #35295 )
2025-12-17 08:48:31 +00:00
Soham Kulkarni
cbe74dbe2e
Merge pull request #35149 from sokumon/user-specific-sidebar
2025-12-17 14:08:36 +05:30
Hussain Nagaria
48b6663a6d
fix(ux): enable create log for server scripts by default ( #35291 )
...
* fix(ux): enable create log for server scripts by default
2025-12-17 08:06:14 +00:00
Akhil Narang
dce98dc7e4
Merge pull request #35293 from akhilnarang/bump-filelock
...
build(deps): bump filelock
2025-12-17 13:12:38 +05:30
Akhil Narang
7ba28d1674
Merge pull request #35290 from akhilnarang/fix-recursion
...
fix(meta): use raw SQL to avoid recursively querying meta in some cases
2025-12-17 13:11:52 +05:30
sokumon
fd85f8354a
fix: use for user field
2025-12-17 13:08:41 +05:30
Akhil Narang
44e47918b6
build(deps): bump filelock
...
Resolves CVE-2025-68146
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-17 12:39:01 +05:30
Ankush Menat
722634a112
Merge pull request #35007 from barredterra/cache-empty-search_link
...
perf: cache empty search links
2025-12-17 12:35:38 +05:30
Akhil Narang
42d8cae26e
fix(meta): use raw SQL to avoid recursively querying meta in some cases
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-17 11:21:22 +05:30
sokumon
95c275f4bc
refactor: setting the correct sidebar
2025-12-17 02:04:37 +05:30
sokumon
1c5c61ea5a
feat: swap user specific sidebar
2025-12-17 02:04:37 +05:30
sokumon
0642d59d6a
feat: make sidebar editor awesome again
2025-12-17 02:04:37 +05:30
Ejaaz Khan
9e72c10f62
Merge remote-tracking branch 'upstream' into form-sidebar
2025-12-17 01:56:34 +05:30
Ejaaz Khan
0a0a7d5d8c
feat: re-design sidebar with Image
2025-12-17 01:45:02 +05:30
