Corentin Flr
e3d00e9117
fix(workspace): Don't allow Welcome as default workspace
...
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2024-03-19 16:24:13 +01:00
Corentin Flr
3ec47b0975
feat(workspace): Allow user to choose a default workspace
2024-03-06 11:15:53 +01:00
Ankush Menat
ab7487cd17
Merge pull request #25252 from akhilnarang/check-dependent-apps-before-uninstall
...
fix(uninstall): don't allow uninstalling an app if we have other apps dependent on it
2024-03-06 14:13:48 +05:30
Akhil Narang
0576a085d7
fix(uninstall): don't allow uninstalling an app if we have other apps dependent on it
...
Support ticket 10929 / Sentry FRAPPE-3T8
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-06 13:50:00 +05:30
Ankush Menat
457654cf40
fix: loosen validation on fetch from columns ( #25247 )
...
Any existing DB column can work so no need to check for meta explicitly.
2024-03-06 07:07:32 +00:00
Ankush Menat
5c475686dd
Merge pull request #25248 from ankush/delete_eps_user
...
fix: Delete EPS logs before deleting user
2024-03-06 12:25:36 +05:30
Ankush Menat
081be53e17
fix(UX): Nudge to disable user instead of deleting
2024-03-06 12:11:35 +05:30
Ankush Menat
072c2a1ca3
fix: Delete EPS logs before deleting user
2024-03-06 12:06:08 +05:30
Ankush Menat
71c3fce146
Revert "perf: reduce JS duplication ( #25199 )" ( #25246 )
...
This reverts commit 53536aa012
2024-03-06 04:05:17 +00:00
Frappe PR Bot
f0f6825b09
fix: sync translations from crowdin ( #25244 )
...
* fix: German translations
* fix: Spanish translations
2024-03-06 09:15:02 +05:30
Raffael Meyer
b92dff6ee3
chore: update crowdin configuration ( #25240 )
...
- change PR type to "fix"
- add pull request label "translation"
- set conventional commit message
2024-03-05 20:57:50 +05:30
Frappe PR Bot
eeb6b67ab9
chore: sync translations from crowdin ( #25236 )
2024-03-05 11:25:53 +01:00
Ankush Menat
8ab2911654
ci: don't skip validations in CI ( #25226 )
2024-03-04 12:43:53 +00:00
Akhil Narang
7b259fd75c
chore: don't allow printing more than 50 documents for now ( #25229 )
...
The 2 minute timeout gets exhausted pretty quickly, until we can move
this to the background, this will atleast prevent people from seeing
an error after the request times out.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-04 17:41:53 +05:30
Ankush Menat
ebd47429a5
chore: grammar?
...
This looks weird without fullstop when there are suggestions
2024-03-04 16:32:48 +05:30
Ankush Menat
ef5a173db0
fix: misleading CLI error message for missing command ( #25049 )
2024-03-04 10:45:46 +00:00
Kunhi
7d7468c45f
fix(UX): list filter take zero as null ( #25156 )
...
* fix: list filter take zero as null
* chore: fallback if null only
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-03-04 15:42:35 +05:30
Raffael Meyer
bfb1c3e7e1
fix: add "If Owner" column to roles viewer ( #25218 )
2024-03-04 15:33:55 +05:30
Ankush Menat
7a854efc03
refactor: Use JSON for session data ( #25207 )
...
JSON is proper format compared to using safe_eval which is a hack to convert
string repr of dict object back into python object.
2024-03-04 06:47:48 +00:00
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options ( #25211 )
...
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
2639bfe945
fix: dont translate numbers ( #25208 )
...
This is not shown in UI and only used for UI logic of toggling button.
closes https://github.com/frappe/frappe/issues/25202
2024-03-04 06:19:40 +00:00
Suraj Shetty
9a1bd6c1ac
fix: No need to sort keys while saving JSON to DB ( #25205 )
...
* fix: No need to sort keys while saving JSON to DB
Also, adding indent is unnecessary.
2024-03-04 05:44:46 +00:00
Ankush Menat
53536aa012
perf: reduce JS duplication ( #25199 )
...
* fix: remove duplicate localforage in bundles
This was shipped with both control and desk bundle
* fix: Avoid duplicate inclusion of DataTable
2024-03-03 20:50:21 +05:30
Ankush Menat
b60c64cacc
fix: rollback invalid customize form changes ( #25198 )
...
* fix: rollback invalid customize form changes
* fix: commit before doing DDL
2024-03-03 17:17:12 +05:30
Frappe PR Bot
4282239fd5
chore: New translations main.pot (Persian) ( #25201 )
2024-03-03 15:19:59 +05:30
Suraj Shetty
89db4ff1a6
Merge pull request #25200 from surajshetty3416/fix-email-validation
2024-03-02 21:34:56 +05:30
Suraj Shetty
b398377739
Merge branch 'develop' into fix-email-validation
2024-03-02 21:23:24 +05:30
Suraj Shetty
ec4261bd77
fix: Do not check for email validation on empty string
2024-03-02 21:20:51 +05:30
Corentin Flr
f4b6f95832
fix(search): Don't break when query doesn't return title ( #25168 )
2024-03-02 19:34:52 +05:30
Frappe PR Bot
8b8c65cd5a
chore: sync translations from crowdin ( #25181 )
...
* New translations main.pot (French)
* New translations main.pot (German)
* New translations main.pot (Spanish)
* New translations main.pot (Arabic)
* New translations main.pot (Persian)
2024-03-02 19:30:31 +05:30
Raffael Meyer
05d9c5df8f
fix(grid): don't add next row while paging ( #25183 )
2024-03-02 19:30:13 +05:30
Maxim Sysoev
eff50e1cd3
fix: filter Implementation is set operator ( #25182 )
...
* Implementation is set operator. fix issue #25180
* Refactored filtrer operator `is`,
Add tests
* fix: Correct implementation for `is set`
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-02 13:59:30 +00:00
Ankush Menat
daf43cff79
test: add test case for in ("") ( #25189 )
2024-03-02 06:00:02 +00:00
Akhil Narang
590a9cd0bc
Merge pull request #25184 from barredterra/refactor-link
...
refactor: validate_link_and_fetch
2024-03-01 18:38:26 +05:30
barredterra
1f969a40eb
refactor: validate_link_and_fetch
...
Remove redundant parameters
2024-03-01 13:31:34 +01:00
Raffael Meyer
81785ae52b
perf: "load more" and "increase page length" ( #25081 )
...
* refactor: saparate click handlers for "load more" and "change page length"
* perf: "load more" or "increase page length"
Only request the required additional data, not all data.
2024-02-29 21:49:32 +05:30
Ankush Menat
0fff2755d6
test: separate out risky tests ( #25179 )
2024-02-29 16:10:08 +00:00
Ankush Menat
f7bff58935
fix: use name for RQ worker instead of PID ( #25175 )
...
Also avoid complex naming schemes.
2024-02-29 14:38:48 +00:00
Ankush Menat
39c511a9b3
Merge pull request #25170 from ankush/delete_conflict
...
fix: race condition on deletes
2024-02-29 18:17:24 +05:30
Ankush Menat
b4fe7223c1
fix(postgres): treat LockNotAvailable as timeout
...
It's a lock timeout in a way.
2024-02-29 18:04:05 +05:30
Ankush Menat
0c9cc2e6ce
test: NOWAIT functionality
2024-02-29 17:46:30 +05:30
Ankush Menat
5116768a54
test: utils for simulating two connections
2024-02-29 17:31:46 +05:30
Ankush Menat
fc5ce044e6
fix: prevent deletion if document is locked
2024-02-29 16:34:39 +05:30
Ankush Menat
e810fb7eca
feat: nowait to skip blocking locks
2024-02-29 16:30:24 +05:30
Ankush Menat
8f00aae160
fix: lock the doc before deleting
...
Locking only prevents this kinda race conditions:
- User A deletes doc
- User B modifies doc so that it's not deletable anymore.
2024-02-29 16:22:02 +05:30
Ankush Menat
f2b07d6c13
Merge pull request #25162 from frappe/pot_develop_2024-02-29
...
chore: update POT file
2024-02-29 10:29:17 +05:30
frappe-pr-bot
0129770957
chore: update POT file
2024-02-29 04:42:35 +00:00
Ankush Menat
1061793b8d
Merge pull request #24467 from barredterra/potfile-ci
...
ci: auto-generate potfile
2024-02-29 10:10:26 +05:30
Ankush Menat
9c93d86294
ci: use bot's PAT
2024-02-29 10:00:39 +05:30
Ankush Menat
69dad391e4
Merge branch 'develop' into potfile-ci
2024-02-29 09:58:02 +05:30
