Ankush Menat
eb8da5fd59
fix!: Correct resolution order for template page ( #20927 )
...
Current resolution is confusing mess:
1. Evaluation is done in order of installed app, first install wins
2. Except frappe, frappe is treated as lowest priority.
Following same principle of "last write wins" everywhere similar to
previous PRs:
- https://github.com/frappe/frappe/pull/17869
- https://github.com/frappe/frappe/pull/20648
- https://github.com/frappe/frappe/pull/19653
Closes https://github.com/frappe/frappe/issues/20377
2023-05-07 13:19:23 +05:30
Ritwik Puri
4b103888a7
chore: remove default None from address_dict param
2023-05-06 22:48:19 +05:30
Ritwik Puri
88bdefcc30
fix: type hints for get_address_display ( #20923 )
2023-05-06 21:36:07 +05:30
Ankush Menat
715dc569e9
fix: reload communication before re-save ( #20914 )
2023-05-06 15:51:07 +05:30
Raffael Meyer
bb14fe61c8
fix: remove wrong translations ( #20917 )
2023-05-06 02:00:36 +05:30
Raffael Meyer
504b33ceb8
fix: translate lowercase operators to german ( #20912 )
2023-05-05 18:22:59 +05:30
Ritwik Puri
4418aa3129
chore: remove unscrubbing while displaying link field filters
2023-05-05 16:56:08 +05:30
Raffael Meyer
4af75f2462
fix: translation files ( #20750 )
...
- remove leading "DocType: XXX"
- remove leading path and line number
- add trailing comma (three columns total)
2023-05-05 15:58:56 +05:30
Ankush Menat
cbbb6a7d85
chore: track onboarding progress
...
Easy self-onboarding has been hardest to get right in complex business
apps, even though we have worked on this for long long time we have no
clear idea on how well it works, or if it's severly lacking.
We want to improve this by first understanding how efficient current
system is.
This PR adds basic telemetry for which steps are being completed, which
are skipped and what onboarding group is dismissed completely.
2023-05-05 12:54:14 +05:30
Shariq Ansari
fa80cfd2cf
Merge pull request #20853 from rtdany10/bulk-print-changes
2023-05-05 11:27:26 +05:30
William Luke
e0ed7d3b97
fix(oauth): add exp to idToken ( #20694 )
2023-05-05 01:19:03 +05:30
Ritwik Puri
f5ba787f4b
Merge pull request #20856 from resilient-tech/perf-private-file
2023-05-05 00:46:16 +05:30
Raffael Meyer
0473f7b44f
feat: helper method for address display ( #20900 )
2023-05-04 23:36:58 +05:30
Shariq Ansari
235c5d71ed
Merge branch 'develop' into bulk-print-changes
2023-05-04 19:57:13 +05:30
Suraj Shetty
a84da0139a
Merge pull request #20810 from gavindsouza/fix-20689
2023-05-04 18:32:16 +05:30
Rohan
01a0a0fc0a
fix: ignore virtual doctypes during data export ( #20891 )
2023-05-04 17:43:22 +05:30
Shariq Ansari
8759a7b41c
fix: message.py executing script ( #20887 )
2023-05-04 17:33:10 +05:30
Ikko Eltociear Ashimine
3efaee9597
docs: fix typo in database.py ( #20894 )
2023-05-04 17:07:08 +05:30
Leonard Goertz
4b7c73514e
fix: ensure that get_last_email returns the most recent email ( #20711 )
...
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-05-04 14:00:06 +05:30
Ritwik Puri
a254a256f8
Merge pull request #20884 from barredterra/translate-operator
...
fix: make operator in link filters translatable
2023-05-04 00:05:33 +05:30
barredterra
7892a8bdb6
fix: translate operator in link filters
2023-05-03 17:04:06 +02:00
Sagar Vora
26512c4d13
Merge pull request #20871 from resilient-tech/no-sync-call-in-requests
2023-05-02 13:49:57 +05:30
Sagar Vora
8418d3c7e2
fix: only call RQ synchronously as fallback during migration
2023-05-02 13:46:50 +05:30
Sagar Vora
9dc2a32952
Merge pull request #20859 from resilient-tech/use-isdisjoint
2023-04-27 18:25:08 +05:30
Sagar Vora
64aaa55d76
chore: remove dead code
2023-04-27 17:50:26 +05:30
Sagar Vora
53c9869ce3
style: use set.isdisjoint when comparing roles (+ minor refactor)
2023-04-27 17:39:33 +05:30
Ankush Menat
2f975c7eb9
fix: pass parent document type for number card ( #20857 )
2023-04-27 17:00:52 +05:30
Sagar Vora
9cf7f2b311
perf: get all file data at once when downloading private file
2023-04-27 16:12:02 +05:30
gavin
c4ecd33357
Merge branch 'develop' into fix-20689
2023-04-27 14:38:32 +05:30
Gavin D'souza
63a605876f
fix: Pass current dt as fallback parent_doctype
2023-04-27 14:37:15 +05:30
Dany Robert
9ec5c8cab2
chore: linters
2023-04-26 14:13:13 +00:00
Dany Robert
8d03f51dbe
fix(multi-pdf): change response type to pdf
2023-04-26 14:05:54 +00:00
Dany Robert
d00bfcdc12
fix: set default letterhead and print format
2023-04-26 14:04:03 +00:00
Ankush Menat
7042dca5dd
Merge pull request #20825 from ankush/posthog_poc
...
feat: telemetry using posthog
2023-04-26 15:54:30 +05:30
Ankush Menat
109a549a23
fix: pass reference_doctype to search query methods ( #20842 )
...
frappe.call ensures that it's only passed to functions which can accept
it, so nothing to worry about ~ backward compatible change.
2023-04-25 18:31:14 +05:30
Ankush Menat
db4cd1a84b
refactor: reduce duplication
2023-04-25 15:03:11 +05:30
Ankush Menat
93c326b971
feat: let user opt out of telemetry from setup
2023-04-25 14:46:53 +05:30
Ankush Menat
f63c420798
feat: add python posthog library
2023-04-25 13:10:14 +05:30
Ankush Menat
6c3f29efe7
feat: setup wizard progress telemetry
2023-04-25 11:54:56 +05:30
Ankush Menat
87a88195ec
feat: telemetry using posthog
2023-04-25 10:33:28 +05:30
Ankush Menat
0d1c7fee42
feat: let users disable telemetry from system settings
2023-04-25 10:33:28 +05:30
Ritwik Puri
e6279e08f2
Merge pull request #20823 from phot0n/dnr-update-counter
...
refactor(minor): remove update counter dialog and make counter editable by default
2023-04-25 01:06:17 +05:30
phot0n
71f45eba68
fix: add confirmation when updating counter and make document type mandatory
2023-04-25 01:02:12 +05:30
Raffael Meyer
f7b2b59f9a
fix: don't translate before unscrubbing ( #20814 )
2023-04-24 19:16:11 +05:30
Raffael Meyer
e384d94fcc
fix: make role info translatable ( #20813 )
2023-04-24 18:58:22 +05:30
Raffael Meyer
fc10325074
fix: improve delete_contact_and_address ( #20381 )
2023-04-24 18:51:42 +05:30
mergify[bot]
f95a042756
Merge pull request #20517 from barredterra/gc-perms
...
fix: role perms on Google Contacts
2023-04-24 13:11:09 +00:00
Ankush Menat
eeda161e98
fix: handle SMTPRecipientsRefused retries ( #20819 )
...
* fix: remove trailing and leading quotes from email
* chore: typo
* fix: dont retry `SMTPRecipientsRefused`
If refused once it's unlikely to work again just by retrying. There's no
mechanism to prevent infinite retry. This will still attempt for
MAX_RETRY_COUNT.
* Revert "fix: remove trailing and leading quotes from email"
This reverts commit 2676ac2c7fe76c34049da05a209554fee6b3d911.
refer https://github.com/frappe/frappe/pull/20819#discussion_r1175166987
2023-04-24 17:34:24 +05:30
Shariq Ansari
145ba36cea
Merge pull request #20822 from shariquerik/multiple-assignment-fix
2023-04-24 16:31:26 +05:30
phot0n
7ae60ff268
refactor(minor): remove update counter dialog and make counter editable by default
2023-04-24 13:06:51 +05:30