Commit graph

40866 commits

Author SHA1 Message Date
marination
f6a68062d9 chore: Add comments to avoid incompatible queries with _run_with_permission_query 2023-01-16 19:15:16 +05:30
marination
968648e1b6 test: Test if permission query via server script is applied on cached allowed reports 2023-01-16 18:38:26 +05:30
marination
8bd1b7b019 fix: Remove unnecessary get_sql 2023-01-16 17:09:21 +05:30
Marica
6164817748
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-16 16:51:43 +05:30
marination
2702bf60aa refactor: Use Query instead of MySQLQueryBuilder
- Use `Query` from database/utils which will consider postgres query type as well
- Reduce LOC where unnecessary

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2023-01-16 16:51:11 +05:30
Deepesh Garg
0f5d17663d
fix: Remove setup wizard user image (#19601) 2023-01-16 16:44:04 +05:30
Ritwik Puri
1e6086fd75
fix(minor): only show authorization message if connected app is set (#19605) 2023-01-16 16:22:38 +05:30
Ritwik Puri
50327203ce
Merge pull request #18750 from revant/oauth-email
feat: use Connected App for OAuth based Email Account
2023-01-16 15:24:05 +05:30
phot0n
b5c81cc015 chore(patch): disable all email accounts with oauth mechanism 2023-01-16 12:56:22 +05:30
aissa-berrachiche
bfaadfd32d
fix: passwords are updated on every login (#19594)
Co-authored-by: aberrachiche <aberrachiche@aas.com.sa>
2023-01-16 11:06:05 +05:30
Shariq Ansari
701415142b
Merge pull request #19597 from shariquerik/test-form-builder-fix 2023-01-16 10:47:40 +05:30
Shariq Ansari
fae098f661
Merge pull request #19587 from shariquerik/hide-workspace-firefox-fix 2023-01-16 10:27:20 +05:30
Shariq Ansari
cd8049e569
Merge pull request #19586 from ruchamahabal/fix-fetch-if-empty 2023-01-16 10:26:42 +05:30
Shariq Ansari
8abd144de6 test: fixed failing UI test 2023-01-16 10:24:45 +05:30
Shariq Ansari
35f4f22c7d
Merge branch 'develop' into fix-fetch-if-empty 2023-01-16 09:34:50 +05:30
phot0n
88d4d5e10d chore: minor cleanup - removed unnecessary branches and comments 2023-01-15 21:02:21 +05:30
phot0n
c2ceceea6e fix: use OAUTHLIB_RELAX_TOKEN_SCOPE for ignoring scope change
without this we get an error regarding the mismatch of scopes from microsoft
2023-01-15 21:02:21 +05:30
marination
0ba158979d fix: Make run_with_permission_query private (not a general util)
- Also switch query and doctype parameter positions in `_run_with_permission_query`
2023-01-13 21:30:54 +05:30
marination
c41b5e9511 fix: Report sidebar must consider Permission Query
- On boot cache permissible reports, filter out reports blocked by Permission Query
- Sidebar report selector uses boot cache to get allowed reports, which now respects Permission Query
- Convert qb query to str and append permission query and then execute

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2023-01-13 21:23:47 +05:30
Shariq Ansari
66d35ed3f4 fix: if workspace has children always show drop-icon in edit mode 2023-01-13 17:08:46 +05:30
Shariq Ansari
d7a50e4dfd fix: Hide drop-icon if all children is hidden
Hide section if all workspaces are hidden
2023-01-13 17:00:46 +05:30
Shariq Ansari
20ff30896a
Merge pull request #19477 from shariquerik/form-builder-fixes-1
Fixes https://github.com/frappe/frappe/issues/19476
2023-01-13 14:55:18 +05:30
Rucha Mahabal
381ae564aa fix: fetch_if_empty not honoured on the client-side 2023-01-13 14:30:13 +05:30
Ritwik Puri
27a2689678
fix: slug doctype when building url to report with filters (#19581) 2023-01-12 23:36:46 +05:30
Shariq Ansari
e9ac718199 fix: cannot focus on disabled input field in firefox
made it readonly
2023-01-12 21:56:52 +05:30
Shariq Ansari
4ba615608c
Merge branch 'develop' into form-builder-fixes-1 2023-01-12 21:00:45 +05:30
Shariq Ansari
e29d9451bf fix: removed :has() pseudo class since it is not yet supported in firefox 2023-01-12 20:57:17 +05:30
Pruthvi Patel
2e87b405fe
chore(docstring): fix docstring to match the value of MAX_WRITES_PER_TRANSACTION (#19572) 2023-01-12 17:47:59 +05:30
Shariq Ansari
b099b6fdf8
Merge pull request #19574 from shariquerik/hide-workspace-fix 2023-01-12 16:07:24 +05:30
Shariq Ansari
771fb9fdb3
Merge branch 'develop' into hide-workspace-fix 2023-01-12 15:38:55 +05:30
Shariq Ansari
1552b70e95 fix: hide unhide workspace css not working in firefox
reverting css part for now
2023-01-12 15:36:00 +05:30
Shariq Ansari
9cdd4e835d feat: duplicate field 2023-01-11 23:14:10 +05:30
Shariq Ansari
c9d3449bd3 fix: cmd/ctrl+s to save the form 2023-01-11 22:50:58 +05:30
Shariq Ansari
597dd1f619 fix: show field documentation_url icon if set 2023-01-11 20:58:13 +05:30
Shariq Ansari
bae711cff2 fix: changing documentation_url docfields type from Small Text to Data(URL) 2023-01-11 20:57:11 +05:30
Shariq Ansari
737fec7c26
Merge branch 'develop' into form-builder-fixes-1 2023-01-11 20:52:03 +05:30
jiangying
0898ac2a0e
docs: fix docstring for get_list filters (#19569)
* chore: fix doc in frappe/__init__.py

should be filter as a list of dicts

* Update __init__.py

* doc: remove `filter as a list of dicts`
2023-01-11 17:16:19 +05:30
Ankush Menat
0855e1969a chore: editorconfig handle doctype.json files
[skip ci]
2023-01-11 17:08:48 +05:30
Ankush Menat
266b9a05e1
docs: clarify what s3 endpoint does (#19566)
Endpoint is used for calling non-AWS s3 compatible backends. You dont
need to fiddle with this for AWS S3.

[skip ci]
2023-01-11 15:43:24 +05:30
Ankush Menat
4443a0743d
fix(UX): Leaderboard company field validation (#19562)
[skip ci]
2023-01-11 14:22:08 +05:30
Ankush Menat
3f82839c53
fix: strength check on password control (#19561)
* fix: strength check on password control

* fix: no password strength verification on login
2023-01-11 13:13:17 +05:30
dependabot[bot]
be23576631
chore(deps): bump decode-uri-component from 0.2.0 to 0.2.2 (#19090)
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-11 11:18:35 +05:30
Ankush Menat
327300b6c9
fix(UX): Better message for update after submit. (#19558)
[skip ci]
2023-01-10 19:35:45 +05:30
Ankush Menat
1b1e4de35e
chore!: dead code (#19551)
This was added for some very old patch code.

[skip ci]
2023-01-10 18:53:08 +05:30
Raffael Meyer
ed30a6d59f
refactor(minor): use DocStatus (#19545) 2023-01-10 17:38:11 +05:30
Ankush Menat
894f0affcc
fix(DX): Print alter query if it fails during migration (#19552) 2023-01-10 16:55:29 +05:30
Suraj Shetty
0d62cbb470
Update SECURITY.md 2023-01-10 16:49:44 +05:30
Ankush Menat
49fd3a5372 ci: update codecov.yml flags 2023-01-10 13:19:12 +05:30
Ankush Menat
41f8fb1a68
fix: Log settings - Handle validation failures (#19549)
There's only one sane way to get past validations - remove the rows, so
just do it instead of asking users to do it.

[skip ci]
2023-01-10 12:30:01 +05:30
Ankush Menat
1eaca4e1d5
fix: RSS feed escaping (#19546)
if title contains reserved chars then malformed XML is generated.

Try title with ampersand in it.

[skip ci]
2023-01-10 11:45:31 +05:30