Raffael Meyer
8eb8c64fbd
fix(Navbar Settings): reload page after save ( #26274 )
...
* fix(Navbar Settings): reload page after save
* test: file uploader flake
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-05-01 13:20:04 +00:00
Ankush Menat
0a34f8b28e
fix!: remove "remove empty rows" behaviour ( #26269 )
...
This doesn't make sense:
1. A field which is not in list view can be modified
2. A modified field can actually have falsy value
2024-05-01 07:33:30 +00:00
Raffael Meyer
42be1455f8
fix(oauth2): refresh token is optional ( #26266 )
...
Don't overwrite refresh_token with an empty string, if no new refresh_token is received (i.e. the old one is still valid).
Ref: https://www.rfc-editor.org/rfc/rfc6749#section-5.1
2024-05-01 12:35:58 +05:30
Ankush Menat
ee64b2cb6c
fix!: Only use webserver_port in developer mode ( #26268 )
2024-05-01 12:11:01 +05:30
Maharshi Patel
72b1db0ae5
revert: fix: pointless conditions about systemd/supervisor ( #26267 )
...
commit added port numbers in urls which broke links on fc.
2024-04-30 20:31:48 +00:00
Raffael Meyer
0696123661
fix(Data Import): don't attempt to show logs for unsaved import ( #26263 )
2024-04-30 16:46:46 +00:00
Ankush Menat
a7e8139c65
Merge pull request #26262 from ankush/sys_helth
...
fix: misc sys health report fixes
2024-04-30 20:35:50 +05:30
Ankush Menat
1a3c23290f
refactor: avoid deprecated method
2024-04-30 20:22:42 +05:30
Ankush Menat
b5bc8b308d
fix: system health ergonomics
...
- if redis is down it takes 10 second and doesn't indicate that
correctly
- full traceback is shared in debug log, if some step fails
2024-04-30 20:20:53 +05:30
mergify[bot]
6301b208e4
fix: Treeview DB lookup should perform the same preperation operation… (backport #26199 ) ( #26258 )
...
* fix: Treeview DB lookup should perform the same preperation operations as method update_nsm in file nestedset.py (#26199 )
(cherry picked from commit 7d25aedaafde97c5b911cd8ea727d7afdf1e844e)
# Conflicts:
# frappe/desk/treeview.py
* chore: conflicts
---------
Co-authored-by: Fritz <fixundfertig123@web.de>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-04-30 14:20:46 +00:00
Ankush Menat
9567efe20b
test: file uploader flaky test ( #26254 )
...
Previous window left open kills all other tests with no way to know
which one
2024-04-30 14:18:18 +00:00
Rutwik Hiwalkar
ba2715582b
fix: init db conn for unbuffered cursor if not set ( #26220 )
...
* fix: init db conn for unbuffered cursor if not set
* chore: check conn and not cursor
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-04-30 12:54:12 +00:00
Nahuel Operto
c0e779998d
fix: lstrip for query writes detection ( #26180 )
2024-04-30 18:09:22 +05:30
Raffael Meyer
774f5cc1c6
fix(Data Import): don't rely on permission for Data Import Log ( #26228 )
2024-04-30 18:00:24 +05:30
Ankush Menat
c1e8d8e791
test: flaky link field test ( #26246 )
2024-04-30 11:12:49 +00:00
Exequiel Arona
2263acf80c
feat: workspace extraction improvements ( #26169 )
...
* feat: add extractor for count format of shortcut
* feat: add extraction of description string
2024-04-30 16:14:34 +05:30
Maharshi Patel
6a6ded156f
chore: warn if wkhtmltopdf is invalid ( #26174 )
...
* chore: warn if wkhtmltopdf is invalid
wkhtmltopdf ( with patched qt ) is required to generate pdfs properly.
when user clicks on PDF, pdf will be generated and downloaded.
however, on print preview page warning will be shown.
* chore: refactor based on review comments
* chore: return False incase of exception
* chore: refactor and better naming
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-04-30 10:36:56 +00:00
Ankush Menat
f244f3c76f
fix: perm query for dashboard ( #26239 )
2024-04-30 09:43:51 +00:00
Ankush Menat
775f113145
test: wait for duration control ( #26235 )
2024-04-30 06:45:26 +00:00
Ankush Menat
97123a2d93
fix: Dirty form when grid rows are moved ( #26230 )
2024-04-30 06:14:59 +00:00
Ankush Menat
99e4f55940
fix(UX): warning when printing unsaved documents ( #26229 )
2024-04-30 06:08:58 +00:00
Ankush Menat
dd82ab415c
fix: add missing impl for is_column_missing ( #26225 )
...
I removed it assuming it's already implemented in actual classes, but
it's alias for is_missing_column.
2024-04-29 16:46:12 +00:00
Raffael Meyer
2eece08d8b
fix(report builder): responsive footer ( #26222 )
2024-04-29 18:20:02 +02:00
Rutwik Hiwalkar
2415936fa2
Merge pull request #26172 from rutwikhdev/fix-multistep-webform
...
fix: multistep webform page navigation
2024-04-29 20:09:08 +05:30
Ankush Menat
ba4ea0ed7a
Merge pull request #26213 from ankush/fix_arabic_cal
...
fix: calendar in Arabic
2024-04-29 19:30:38 +05:30
Ankush Menat
72d81afc72
fix(calendar): always use english dates for API calls
2024-04-29 19:15:56 +05:30
Ankush Menat
602ff8273f
Revert "fix(ar): render fullcalendar in english ( #26207 )"
...
This reverts commit e4ed1b98e4
2024-04-29 19:04:12 +05:30
Ankush Menat
a7b7af8311
fix: Evaluate assets in sequence ( #26208 )
...
Fetching can be done in parallel and out of order but execution should
depend on order specified in args otherwise it breaks things like
calander which has 2 JS file and 2nd one depends on first one.
2024-04-29 13:26:20 +00:00
Ankush Menat
e4ed1b98e4
fix(ar): render fullcalendar in english ( #26207 )
...
It doesn't work in arabic - doesn't show anything.
Looks like upstream bug, best we can try for now is to render it in
English instead.
2024-04-29 18:42:12 +05:30
Akhil Narang
b28cc5ca5b
Merge pull request #26204 from cogk/fix-typo-install_apps-might-be-none
...
chore(new_site): Avoid iterating None
2024-04-29 17:35:37 +05:30
Corentin Flr
f0c7de39dc
chore(new_site): Avoid iterating None
2024-04-29 13:41:00 +02:00
King Phyte
05766680f7
fix: restoring site breaks when checking backup version ( #26186 )
...
* fix: restoring site breaks when checking backup version
The `backup_version` variable exists if and only if the `if match` branch executes, but it is used in a condition in a scope where it may not exist. Changing the variable to `match` leads to correct behaviour.
* fix: restoring site breaks when checking backup version
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
* fix: version check when restoring site should be done from `match` scope
* chore: add a `return None` for better readability
No functional difference, just easier to understand/read the code.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-04-29 16:34:29 +05:30
Ankush Menat
ff31290d33
Merge pull request #25971 from rutwikhdev/discard-transactions
...
feat: Discard transactions
2024-04-29 16:08:37 +05:30
Ankush Menat
7b0074e059
refactor!: override_doctype -> Must extend base class ( #26152 )
...
* fix: pointless conditions about systemd/supervisor
What does this have to do with hostname?
* fix!: Overriden doctypes must inherit same base class
There is almost never a real need to completely override a class. After
this change we'll only allow extending and not overriding completely.
2024-04-29 10:21:53 +00:00
Akhil Narang
bcc190b620
Merge pull request #26165 from akhilnarang/fix-csv-delimiter-check
...
fix(report_utils): ensure that delimiter and separator can't be empty
2024-04-29 15:40:25 +05:30
Raffael Meyer
a53a632638
Merge pull request #26198 from barredterra/options-extractor
2024-04-29 11:53:43 +02:00
barredterra
b530de4098
fix: don't extract icon names
2024-04-29 11:41:19 +02:00
barredterra
530aaaec26
refactor: remove redundant excluded fields
...
These are already caught by the `option.isdigit()` check.
2024-04-29 11:40:02 +02:00
Ankush Menat
0d2479fd37
Merge pull request #26193 from ankush/oauth_roles
...
feat: limit oauth client to roles
2024-04-29 14:48:52 +05:30
Ankush Menat
ae4eb87458
feat: Limit OAuth Client by roles
2024-04-29 14:18:49 +05:30
Akhil Narang
6d55292bb7
Merge pull request #26179 from barredterra/contact-msg-title
...
fix: compute modal title server side
2024-04-29 13:50:08 +05:30
Ankush Menat
926c888374
fix(UX): bulk delete error messages
2024-04-29 10:59:39 +05:30
barredterra
33d59d6e58
fix: compute modal title server side
2024-04-26 17:41:00 +02:00
Ankush Menat
71dfffa7ec
fix: Don't optimize images implicitly ( #26177 )
...
Makes screenshots in comments unreadable with no way to opt out of it.
2024-04-26 13:22:18 +00:00
Exequiel Arona
dc64678625
fix: clean up print ( #26170 )
2024-04-26 18:22:33 +05:30
Rutwik Hiwalkar
ee75d42f4b
fix: multistep webform page navigation
2024-04-26 15:05:38 +05:30
Akhil Narang
9e8808f06c
Merge pull request #26145 from akhilnarang/fix-failed-backup-deletion
...
fix(backup): delete failed backup even if something fails during the backup process
2024-04-25 18:09:52 +05:30
Akhil Narang
af611d4bcb
fix(report_utils): ensure that delimiter and separator can't be empty
...
This results in them setting as `undefined`, which ends up as a string
in python, and the delimiter ends up as `'u'`, and the separator as
`'undefined'`.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-25 17:26:12 +05:30
Akhil Narang
e455b7b452
Merge pull request #26163 from barredterra/csv-decimal-sep
...
feat(CSV export): allow custom decimal separator
2024-04-25 16:55:55 +05:30
barredterra
3fe9190762
feat(CSV export): allow custom decimal separator
2024-04-25 12:24:24 +02:00
