Akhil Narang
90bd55690a
refactor(query_report): simplify logic
...
Reduce one level of nesting
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-27 19:24:43 +05:30
Akhil Narang
b17238f997
fix(query_report): fix indentation, add some newlines
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-27 19:24:43 +05:30
jabir-elat
b754bdb03d
refactor(query_report): filter check
2024-09-27 19:24:28 +05:30
jabir-elat
e4485bebb0
fix(query_report): enforced user permissions on report filters for linked doctypes
2024-09-27 19:18:51 +05:30
Akhil Narang
5fb247c4e1
Merge pull request #26693 from cogk/fix-attachment-name-with-percent
...
fix: Fix file/email attachment name containing percent sign
2024-09-16 18:23:37 +05:30
Corentin Forler
772df163cf
fix(file): Remove illegal chars in file_name
...
- / and \ cannot work as file names
- % is not allowed verbatim in URLs
- ? and # are not allowed because confused with query/hash separators
2024-09-16 13:47:27 +02:00
Corentin Flr
6b7c0007fe
test(File): Add test for attachments with percent-encoded file names
2024-09-16 13:47:27 +02:00
Corentin Flr
71f111e267
fix(InboundEmail): Unquote percent-encoded file names
2024-09-16 13:47:27 +02:00
Corentin Flr
b23f24a4fc
fix(File): Disallow percent sign in file_name
2024-09-16 13:47:27 +02:00
Corentin Flr
aa9f0d365c
fix(File): Unquote file_url only once
2024-09-16 13:47:27 +02:00
Akhil Narang
64ec68ff00
Merge pull request #27746 from Lyes7/fix/fix-workflow-typos
...
fix: workflow typos
2024-09-16 16:22:10 +05:30
Akhil Narang
fc8259a2a5
Merge pull request #27772 from gavindsouza/delete_doc-check_if_submittable
...
fix(delete_doc): Check if submittable before docstatus validation
2024-09-16 15:41:30 +05:30
Akhil Narang
817c5fff9e
Merge pull request #27786 from akhilnarang/improve-decryption-failed-message
...
chore(decrypt): mention the key in error if specificed
2024-09-16 13:13:17 +05:30
Akhil Narang
9098538023
chore(twofactor): specify key to display during decryption failures
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-16 13:00:38 +05:30
Akhil Narang
c2001919a5
chore(decrypt): mention the key in error if specificed
...
This would allow the user to know which key is failing, and just update that if required
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-16 12:51:49 +05:30
Akhil Narang
dda20b6577
Merge pull request #27782 from akhilnarang/update-password-message
...
fix(setup_wizard): update wording for password field for non-admins
2024-09-16 11:55:33 +05:30
Akhil Narang
69179e8e94
fix(setup_wizard): update wording for password field for non-admins
...
It's an optional field because the user already exists, clarify that
that this can just update their password, otherwise the original
password will still work.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-16 11:40:06 +05:30
David Arnold
8ef064b14a
Merge pull request #27776 from frappe/perf/count-on-db-exists
...
fix: align signature with backend; use count for perf on filters
2024-09-14 13:02:25 +02:00
David
89d4e6670b
fix: align signature with backend; use count for perf on filters
2024-09-14 12:49:20 +02:00
Gavin D'souza
15f6fcdf3e
fix(delete_doc): Check if submittable before docstatus validation
2024-09-13 18:50:50 +02:00
David Arnold
203dd95ebe
Merge pull request #27765 from frappe/refactor/cli-context-lsp-support
...
refactor: type hint cli context
2024-09-13 17:37:49 +02:00
David
202cce8a0d
refactor: type hint cli context
2024-09-13 17:25:43 +02:00
David Arnold
a46b94527b
Merge pull request #27753 from frappe/feat/add-friedly-error-handler-on-cli
...
feat: friendly error wrapper on cli
2024-09-13 17:20:29 +02:00
David
f2b42b6d5c
chore: also improve the pdb test mode
2024-09-13 17:07:04 +02:00
David (aider)
0e92dc3a97
feat: friendly error wrapper on cli
2024-09-13 17:07:04 +02:00
David Arnold
40f2387780
Merge pull request #27763 from frappe/fix/correct-execute-command
...
fix!: execute command
2024-09-13 17:05:07 +02:00
David
6a95540bf5
fix: nicer error message on bench execute
2024-09-13 16:52:16 +02:00
David
0c6fffa348
fix!: execute command
...
BREAKING: return values of bench execute are not quoted anymore
For example, `bech execute frappe.bold --arg 'hi'`
- now returns: `<strong>hi</strong>`
- instead of: `"<strong>hi</strong>"`
2024-09-13 16:52:15 +02:00
Akhil Narang
d42e5be4da
Merge pull request #27723 from s-aga-r/fix-system-manager-emails
...
fix: prevent sending emails to System Manager when email notifications are disabled
2024-09-13 18:27:53 +05:30
Akhil Narang
346082643b
chore: format
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-13 18:23:00 +05:30
Akhil Narang
c044680c3f
Merge pull request #27505 from dj12djdjs/fix-link-title-href
...
fix: show link title in generated form hrefs
2024-09-13 18:17:15 +05:30
David Arnold
ee71bee135
Merge pull request #27766 from frappe/refactor/frappe-init-call-pre-pr
...
chore: fix all invocation of init for singledispatch -> min 1 positional arg
2024-09-13 12:06:50 +02:00
David
d87b786687
chore: fix all invocation of init for singledispatch -> min 1 positional arg
2024-09-13 11:53:52 +02:00
David Arnold
29d61588c8
Merge pull request #26753 from blaggacao/perf/more-critical-requests-cachable
...
perf: make more resources in the critical path cacheable
2024-09-13 10:42:19 +02:00
David
2fccd18dd1
feat: make more resources in the critical path cacheable
2024-09-13 10:29:19 +02:00
David Arnold
c224a171c2
Merge pull request #27759 from frappe/fix/json-serializer
...
fix: improve serializer
2024-09-13 10:22:28 +02:00
Akhil Narang
af7636e362
Merge pull request #27760 from akhilnarang/fix-validate-doc-rename-permission-check
...
fix(rename_doc): check permissions for the specific document
2024-09-13 11:37:12 +05:30
Akhil Narang
a87de09e79
fix(rename_doc): check permissions for the specific document
...
A user can have access to write to a document without having access to the whole doctype
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-13 11:16:53 +05:30
David
7d5b63a267
fix: improve serializer
2024-09-12 21:06:10 +02:00
Raffael Meyer
3d103eab94
fix: form should pass df to formatter ( #27756 )
2024-09-12 20:57:46 +02:00
David Arnold
59421b1452
Merge pull request #27755 from Ponnusamy1-V/time_field_fix
...
fix: Time field not updating the manual edit to the time picker (editing the values directly in the input field)
2024-09-12 17:09:57 +02:00
Ponnusamy1-V
e2b1bc4dcb
style: pre-commit
2024-09-12 20:16:24 +05:30
Ponnusamy1-V
be7e81db59
fix: time picker doesn't show correct value
2024-09-12 20:05:46 +05:30
David Arnold
672bd73b02
Merge pull request #27738 from frappe/chore/make-config-namespace-available
...
refactor!: make room in the frappe.config namespace
2024-09-12 12:32:25 +02:00
David
091df9fe2b
refactor!: make room in the frappe.config namespace
...
BRAKING: fappe.config namespace moved to
frappe.utils.modules namespace
2024-09-12 12:18:58 +02:00
Lyes7
9b89eba337
fix: workflow typos
2024-09-12 10:18:49 +01:00
Akhil Narang
6a38638c4c
Merge pull request #27747 from akhilnarang/printview-doc-title-str
...
fix(printview): ensure document title is a string
2024-09-12 13:47:51 +05:30
Akhil Narang
182dc7213d
fix(printview): ensure document title is a string
...
Nothing is stopping people from setting non-string types as their title
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-12 13:34:59 +05:30
David Arnold
cca88f3a47
Merge pull request #27742 from frappe/chore/no-stale-on-draft
...
chore: exempt draft prs from stale bot
2024-09-12 08:00:10 +02:00
David Arnold
e606c23823
Merge pull request #27697 from blaggacao/feat/notification-with-minutes-offset
...
feat/notification with minutes offset
2024-09-12 07:12:01 +02:00
