Ankush Menat
a4ddb7491d
fix: specify print_language in communication attachments
2024-02-28 14:19:28 +05:30
Ankush Menat
91d10ffb31
Merge pull request #25128 from ankush/lang_print_format
...
fix: Use current language in attachment prints
2024-02-28 14:03:06 +05:30
Ankush Menat
870c92f7ea
fix: Use current language in attachment prints
2024-02-28 13:50:48 +05:30
Ankush Menat
fe9fbf82d0
fix: validate fetch from ( #25116 )
2024-02-27 23:38:49 +05:30
Ankush Menat
c60edc9a77
refactor: file perm check ( #25106 )
2024-02-27 16:45:29 +00:00
Niraj Gautam
911846368f
feat: Add doc rename hook in server script ( #25085 )
...
* feat: Add doc rename hook in server script
* feat: Add test case for doc event in server script
2024-02-27 22:07:22 +05:30
Ankush Menat
01d29283f1
fix: restrict method for security critical endpoints ( #25105 )
2024-02-27 16:10:33 +00:00
Ankush Menat
24499d93f8
fix: notify user that they were impersonated
2024-02-24 18:31:10 +05:30
Ankush Menat
be47ee0e31
fix: track all impersonated changes
2024-02-24 18:25:09 +05:30
Ankush Menat
0fd4d6b67f
fix: log activity for impersonations
2024-02-24 18:25:09 +05:30
Ankush Menat
c58ac809ac
fix: Flag impersonated sessions
2024-02-24 18:25:09 +05:30
Ankush Menat
ecc9ff378e
feat: impersonate any user as Administrator
2024-02-24 18:25:07 +05:30
Md Hussain Nagaria
690cb7d372
refactor: scheduled job type enhancements ( #25007 )
...
* refactor: remove autoname
* chore(Scheduled Job Type): enable show title in link
* chore: validate duplicate job
* test: throws on duplicate scheduled job
* feat: attach frequency and cron_format to `frappe.job`
* refactor: add unique constraint on db level
* fix: attach to frappe.job only if defined
* test: scheduled job name will get updated on frequency update
* test: wrap duplicate inserts in db savepoint/rollback
* fix: rollback without savepoint
* test: use loose Exception for raise assertion
2024-02-23 10:12:51 +00:00
Nikhil Kothari
bc68afa5b6
fix: spelling of "recording" in button ( #25025 )
2024-02-23 10:40:31 +05:30
Ankush Menat
9d0a24f3de
fix: handle email without content adding links ( #24994 )
2024-02-21 19:18:21 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Ankush Menat
718b5b8bee
fix: Private images in PDFs from background jobs ( #24980 )
...
* refactor: Private images rendering in PDFs
Private images currently render fine if PDF is generated during a
request as we pass the cookiejar to WKHTML.
Background jobs however fail completeley because they can't retrieve
private images without cookiejar.
This PR converts all image types to base64 encoded sources in HTML
itself, so wkhtmltopdf doesn't have to a fire a request.
* test: private images in pdf
2024-02-21 10:38:02 +00:00
Ankush Menat
b794f868cc
fix: never apply role profiles to standard user ( #24968 )
2024-02-20 14:07:50 +00:00
Ankush Menat
e306e01660
Merge pull request #24947 from ankush/chore/remove_patch
...
fix: remove patch for hashing existing tokens
2024-02-19 18:44:39 +05:30
Ankush Menat
9a0fc2e9d9
fix: remove patch for hashing existing tokens
2024-02-19 18:38:21 +05:30
Ankush Menat
0a886b7ca8
perf: defer imports during CLI
2024-02-19 18:10:07 +05:30
Ankush Menat
e88c078c9d
fix: validate cron format
2024-02-19 13:27:34 +05:30
Ankush Menat
68d1a9ec07
fix: delete cron jobs when switching server script type
2024-02-19 13:11:45 +05:30
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label ( #24903 )
2024-02-18 19:42:15 +05:30
Ankush Menat
78264a7f16
fix(UX): usability of reset password page
...
- password managers use paste, added that event to trigger our code
- if no password policy then skip. Way too much needless business logic in HTML here.
2024-02-11 16:30:32 +05:30
Ankush Menat
38565a80e3
test: redo reset password tests
2024-02-11 14:30:50 +05:30
Ankush Menat
4c925e0325
refactor: Reset password flow
...
- Hash one time reset tokens instead of storing them as is
- Up the perm level
- Use better source of randomness for generating token
- minor code cleanup here and there
2024-02-11 14:25:26 +05:30
Ankush Menat
74071c1231
chore: remove default UI tours
...
Experiment 🤷
2024-02-11 14:25:26 +05:30
Corentin Flr
4f5de3b0de
fix(boilerplate): Fix WebsiteGenerator HTML templates ( #24806 )
2024-02-10 13:57:17 +05:30
Ankush Menat
19044c4be4
Merge pull request #24745 from niraj2477/multiple-role-profile
...
feat: Allow multiple role profile for user
2024-02-10 13:11:44 +05:30
Ankush Menat
7e8b671059
test: role ordering doesn't matter
2024-02-10 12:58:23 +05:30
Ankush Menat
fd2e6e4045
fix: disable role editor if role profiles are present
2024-02-10 12:52:38 +05:30
Ankush Menat
60aae9bbb2
fix: role profile > user dashboard links
2024-02-10 12:52:38 +05:30
Ankush Menat
72c2207e0f
refactor: useless use of dict in frappe.get_doc
2024-02-10 12:52:38 +05:30
Ankush Menat
638aeaddd8
refactor: remove code duplication for role profile logic
2024-02-10 12:52:38 +05:30
Ankush Menat
bfa1aebcc6
fix: deduplicate role profiles
2024-02-10 12:52:35 +05:30
Ankush Menat
f609025472
fix: roles getting re-inserted on every save
2024-02-10 12:24:19 +05:30
Ankush Menat
72b40135ce
refactor: avoid implementing duplicate logic for role profile
...
Unless we are getting any performance benefit, I don't see the need to
have two different implementations for it.
also, queue job in long queue to reduce chance of failure
2024-02-10 12:24:19 +05:30
Ankush Menat
fbb4dd7e96
perf: use cached doc for fetching role profiles
2024-02-10 12:24:19 +05:30
Ankush Menat
ff35e4b854
refactor: backward compatiblity code for role_profile_name
2024-02-10 12:24:19 +05:30
Ankush Menat
4e1ed2908c
perf: use unique file url ( #24830 )
2024-02-09 14:52:30 +00:00
Ankush Menat
7fbae4cfc8
Merge branch 'develop' into multiple-role-profile
2024-02-09 19:55:12 +05:30
Suraj Shetty
7991c896a8
fix: Unset contact_name to avoid linking of contact in case of failure
2024-02-09 16:21:29 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Abraham Kalungi
25a3baa632
fix: Remove Open Filter On Communication Doctype ( #24800 )
2024-02-07 13:13:04 +05:30
Ankush Menat
ca3ef817b0
fix: Avoid sending password back ( #24794 )
2024-02-06 20:05:42 +05:30
14987
56efb7d2f7
fix: Resolve lint issue
2024-02-06 16:27:34 +05:30
14987
a01868a0c9
fix: Modify function to update role of user on role profile change
2024-02-06 16:23:21 +05:30
14987
3a3dd14c2c
fix: Move old field to table multiselect
2024-02-06 16:20:59 +05:30
Robert Duncan
d6b126ac6f
fix: console import progress off-by-one ( #24777 )
...
* fix: importer console progress off-by-one
* fix: improve progress message
* chore: typo
---------
Co-authored-by: Robert Duncan <robir@puter.local>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-06 09:48:06 +00:00
