Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label ( #24903 )
2024-02-18 19:42:15 +05:30
Raffael Meyer
526359b20c
Merge pull request #24905 from barredterra/invite-contact-as-user
...
fix: invite contact as user
2024-02-17 16:53:06 +01:00
barredterra
bbd42839e3
fix: invite contact as user
2024-02-16 20:43:37 +01:00
Raffael Meyer
d0ea79daf2
Merge pull request #24879 from barredterra/refactor-setup_backup_tables
2024-02-16 14:42:43 +01:00
Raffael Meyer
e812143e1d
Merge pull request #24898 from barredterra/fix-version-check
2024-02-15 12:16:56 +01:00
barredterra
72dca18c9e
docs: imporve docstrings
2024-02-15 11:54:14 +01:00
barredterra
ee67b46d4e
refactor: get_(old)_backup_version methods
2024-02-15 11:54:03 +01:00
barredterra
ed597693bb
refactor: better variable name
2024-02-15 11:31:06 +01:00
barredterra
76a830574d
fix: wrong operator in version check
2024-02-15 11:30:33 +01:00
Raffael Meyer
f9b5d60ec9
Merge pull request #23701 from pps190/fix-grid-defaults
2024-02-14 18:41:23 +01:00
Devin Slauenwhite
fb8507b1fb
chore: correct linter failure
...
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2024-02-14 10:44:34 -05:00
Devin Slauenwhite
c2eff72f02
fix: replace $.extend with spread operator
...
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2024-02-14 09:54:52 -05:00
barredterra
30d63b165b
refactor: split into multiple methods
2024-02-13 11:44:50 +01:00
barredterra
2a85c4c5d9
refactor: no inline if-statement
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-02-13 11:29:30 +01:00
Suraj Shetty
f092ae9fd4
Merge pull request #24880 from frappe/dependabot/github_actions/pre-commit/action-3.0.1
2024-02-13 08:51:09 +05:30
dependabot[bot]
b0e90f35d0
chore(deps): bump pre-commit/action from 3.0.0 to 3.0.1
...
Bumps [pre-commit/action](https://github.com/pre-commit/action ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/pre-commit/action/releases )
- [Commits](https://github.com/pre-commit/action/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: pre-commit/action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 18:14:29 +00:00
barredterra
2e4dd1ba77
refactor: setup_backup_tables
2024-02-12 18:16:47 +01:00
Sagar Vora
70867b47a4
Merge pull request #24872 from sagarvora/tz-tz
2024-02-12 16:59:01 +05:30
Sagar Vora
2704e94395
fix: add default timezone for Tanzania
2024-02-12 16:45:49 +05:30
Ankush Menat
4350f94616
refactor: add_column ( #24867 )
...
- Skip cache which can be invalid
- Do check at db level
2024-02-12 07:45:18 +00:00
Ankush Menat
7b197f1a2b
Merge pull request #24862 from ankush/workflow_action_faster
...
perf: faster workflow action processing
2024-02-12 12:51:47 +05:30
Ankush Menat
8c5aaeb437
test: avoid fiddling with workflow action columns
2024-02-12 12:38:05 +05:30
Ankush Menat
140a01e2cf
perf: cache permission results
...
For each transition, we end up redoing perm check. Nothing has really changed there though.
2024-02-12 11:32:38 +05:30
Ankush Menat
b0a4425230
perf: process workflow email receipients from background
2024-02-12 11:20:17 +05:30
Ankush Menat
8344bce09a
refactor: remove needless coupling of return values
2024-02-12 11:14:57 +05:30
Ankush Menat
16fa5ec9bd
fix: enqueue_after_commit instead of instantly
2024-02-12 10:51:11 +05:30
Ankush Menat
d0de5da21e
Merge pull request #24857 from ankush/refactor_password_reset
...
refactor: Reset password flow
2024-02-11 20:56:13 +05:30
Rehan Ansari
b8e1979864
chore: typo in frappeclient.py ( #24854 )
2024-02-11 11:06:30 +00:00
Ankush Menat
78264a7f16
fix(UX): usability of reset password page
...
- password managers use paste, added that event to trigger our code
- if no password policy then skip. Way too much needless business logic in HTML here.
2024-02-11 16:30:32 +05:30
Ankush Menat
38565a80e3
test: redo reset password tests
2024-02-11 14:30:50 +05:30
Ankush Menat
4c925e0325
refactor: Reset password flow
...
- Hash one time reset tokens instead of storing them as is
- Up the perm level
- Use better source of randomness for generating token
- minor code cleanup here and there
2024-02-11 14:25:26 +05:30
Ankush Menat
74071c1231
chore: remove default UI tours
...
Experiment 🤷
2024-02-11 14:25:26 +05:30
Ankush Menat
17ebc5ee4d
chore: disable flaky UI test ( #24847 )
2024-02-10 18:08:40 +05:30
tonspar
c12b753648
fix: make_request - prevents an error during response parsing if the response body is empty. ( #24613 )
...
* Update utils.py
Sometimes the returned response body is empty. This change prevents the error during frappe response parsing. For example DELETE request returns no content.
* Revert "Update utils.py"
This reverts commit edbfb6960a175da142e9114d8096e5f09665da1b.
* fix: Avoid parsing empty responses in make_request
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-10 08:50:22 +00:00
XRP Systems
b70e0e8071
fix: Added Mongolian language ( #24803 )
2024-02-10 08:41:56 +00:00
Corentin Flr
4f5de3b0de
fix(boilerplate): Fix WebsiteGenerator HTML templates ( #24806 )
2024-02-10 13:57:17 +05:30
Nihalroshan55
c21935ba9e
fix: added prefix none as default in export_fixtures ( #24816 )
...
* added prefix none as default in export_fixtures
* refactor: declare prefix default later later
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-10 08:21:56 +00:00
Ankush Menat
37489d3715
chore: keep old field data for role profile around
...
Avoids potential data loss, it will get cleaned up over time.
2024-02-10 13:45:55 +05:30
Ankush Menat
19044c4be4
Merge pull request #24745 from niraj2477/multiple-role-profile
...
feat: Allow multiple role profile for user
2024-02-10 13:11:44 +05:30
Ankush Menat
7e8b671059
test: role ordering doesn't matter
2024-02-10 12:58:23 +05:30
Ankush Menat
fd2e6e4045
fix: disable role editor if role profiles are present
2024-02-10 12:52:38 +05:30
Ankush Menat
60aae9bbb2
fix: role profile > user dashboard links
2024-02-10 12:52:38 +05:30
Ankush Menat
72c2207e0f
refactor: useless use of dict in frappe.get_doc
2024-02-10 12:52:38 +05:30
Ankush Menat
638aeaddd8
refactor: remove code duplication for role profile logic
2024-02-10 12:52:38 +05:30
Ankush Menat
bfa1aebcc6
fix: deduplicate role profiles
2024-02-10 12:52:35 +05:30
Ankush Menat
f609025472
fix: roles getting re-inserted on every save
2024-02-10 12:24:19 +05:30
Ankush Menat
72b40135ce
refactor: avoid implementing duplicate logic for role profile
...
Unless we are getting any performance benefit, I don't see the need to
have two different implementations for it.
also, queue job in long queue to reduce chance of failure
2024-02-10 12:24:19 +05:30
Ankush Menat
fbb4dd7e96
perf: use cached doc for fetching role profiles
2024-02-10 12:24:19 +05:30
Ankush Menat
ff35e4b854
refactor: backward compatiblity code for role_profile_name
2024-02-10 12:24:19 +05:30
Ankush Menat
ba5ee5c339
refactor: use get_all instead of get_list
...
There won't be any perm checks here.
2024-02-10 12:24:19 +05:30
